unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lin Sun <sunlin7.mail@gmail.com>
To: 70707@debbugs.gnu.org
Subject: bug#70707: 30.0.50; [PATCH] ; Check the process param in function (python-shell-completion-at-point)
Date: Wed, 1 May 2024 22:49:29 +0000	[thread overview]
Message-ID: <CABCREdoJw4zr8Pid-QwiUWTe6jkdcSHwztDMq3JNSOD9K3Vy+w@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 628 bytes --]

Hi,

There is an unexpected error message happening with function
`python-shell-completion-at-point`.
> Wrong type argument: processp, nil
It happened because the function does NOT check the process param.
The patch will check the param and display a user error message gracefully.

Steps to reproduce the issue.
1. $ emacs -q /tmp/a.py # start emacs and open a python source file
2. type "C-c C-p" (or M-x run-python) to start a python shell
3. type exit() to stop the python process but the buffer still exists
4. M-x python-shell-completion-at-point  will get the error message

Please help review the patch. Thanks. Regards

[-- Attachment #2: 0001-Check-the-process-param-in-function-python-shell-com.patch --]
[-- Type: text/x-patch, Size: 1100 bytes --]

From aa44c95c7f13f2d68be83260e618cf4d806b313b Mon Sep 17 00:00:00 2001
From: Lin Sun <sunlin7@hotmail.com>
Date: Wed, 1 May 2024 06:55:31 +0000
Subject: [PATCH] ; Check the process param in function
 (python-shell-completion-at-point)

* lisp/progmodes/python.el (python-shell-completion-at-point):
  Check the process param at the beginning of the function.
---
 lisp/progmodes/python.el | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el
index d6c29e5ffc..4b2e2f8215 100644
--- a/lisp/progmodes/python.el
+++ b/lisp/progmodes/python.el
@@ -4708,6 +4708,8 @@ python-shell-completion-at-point
 Optional argument PROCESS forces completions to be retrieved
 using that one instead of current buffer's process."
   (setq process (or process (get-buffer-process (current-buffer))))
+  (unless process
+    (user-error "No active python inferior process"))
   (let* ((is-shell-buffer (derived-mode-p 'inferior-python-mode))
          (line-start (if is-shell-buffer
                          ;; Working on a shell buffer: use prompt end.
-- 
2.20.5


             reply	other threads:[~2024-05-01 22:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-01 22:49 Lin Sun [this message]
2024-05-02 15:36 ` bug#70707: 30.0.50; [PATCH] ; Check the process param in function (python-shell-completion-at-point) Lin Sun
2024-05-06  0:44   ` Lin Sun
2024-05-06 15:12     ` kobarity
2024-05-06 15:49       ` Lin Sun
2024-05-06 16:37         ` Lin Sun
2024-05-09  7:58       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABCREdoJw4zr8Pid-QwiUWTe6jkdcSHwztDMq3JNSOD9K3Vy+w@mail.gmail.com \
    --to=sunlin7.mail@gmail.com \
    --cc=70707@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).