From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lin Sun Newsgroups: gmane.emacs.bugs Subject: bug#70722: [PATCH] ; Migrate to python3 for (package-test-update-archives-async) Date: Thu, 9 May 2024 16:19:04 +0000 Message-ID: References: <86sez0jb7i.fsf@gnu.org> <86bk5f75bv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15865"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 70722@debbugs.gnu.org To: kobarity Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 09 18:19:48 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s56Um-0003vU-6b for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 May 2024 18:19:48 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s56Ue-0003lr-W2; Thu, 09 May 2024 12:19:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s56Ub-0003lL-E6 for bug-gnu-emacs@gnu.org; Thu, 09 May 2024 12:19:37 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s56Ua-0005w2-29 for bug-gnu-emacs@gnu.org; Thu, 09 May 2024 12:19:37 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s56V0-0007ko-3k for bug-gnu-emacs@gnu.org; Thu, 09 May 2024 12:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lin Sun Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 May 2024 16:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70722 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70722-submit@debbugs.gnu.org id=B70722.171527159329792 (code B ref 70722); Thu, 09 May 2024 16:20:02 +0000 Original-Received: (at 70722) by debbugs.gnu.org; 9 May 2024 16:19:53 +0000 Original-Received: from localhost ([127.0.0.1]:56126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s56Uq-0007kS-LH for submit@debbugs.gnu.org; Thu, 09 May 2024 12:19:53 -0400 Original-Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]:57624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s56Um-0007k1-H6 for 70722@debbugs.gnu.org; Thu, 09 May 2024 12:19:49 -0400 Original-Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-51f72a29f13so1296071e87.3 for <70722@debbugs.gnu.org>; Thu, 09 May 2024 09:19:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715271556; x=1715876356; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DbOy0LVj39frCUiu6hL60moCURO03dHEw3paXYRW148=; b=ZpB9KYz3D7tPxL13Go9otR+ykouUJUUJht4gyMknDNM+8PJ/jPVT4k1u+SdcIwbvQs LjPIfLHnLRC3SWS5a3TP0IczLHaLM4uUDaeoBUmGg3XsJexFc75i2fqHFQy/fa9q8sY4 xIA658MowiySBWfwYS3GR1UmBPU+2jGsGd3nJha78EdakoyIRghvy9zbwj2QGrFZ2xhF +vrRYFnFVAAQwEFXdLNtHNtOxV3h9g7VpcHavjqnpq0nqpNWx7uTVEEvoXhLr02pzQjc fL26VtTwzDoNnx0AkgjPZqcWn/5jxCtBM7jtNAZ+7kC0259EFT3O+OAvdeXMFyBLRx2F ydQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715271556; x=1715876356; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DbOy0LVj39frCUiu6hL60moCURO03dHEw3paXYRW148=; b=lRp3k+J/1S2dMNCb4JQ0/hhYCSt2fI9DzF4uoTMWQi2H+l+KHeIDPoZRDKkUk2CpGk wEWKKz4/77QcldjNO0VS1t9sHjpuNS8Xog7GtMEJQTq5WNrdeOUDUW+tvaTEbuZIUuf0 yPjMP3zT2je/1hUtSuKG1o/rwYbyZu3M1uA1yeLZefuESLhD3U5ddNJ2ohUhrRriuH5S 9FAdyhZGy05xf1gwntchRw5ut7iLvxH/6j9Tnl5Zo5/4X545e1P3oxj9rbNfhbi6fDLi RX4N0bRVncoBMDM5H7WLJQ3ORlnfYJg+Scdi/qubKEjOzdNMpXWxXXNhrG7gxmWkGF34 YWkA== X-Forwarded-Encrypted: i=1; AJvYcCWE8OZqq6fpzFejtwGu4z8ycSbOZK6DnGZBin9SrKEIVmZMWyLf/0acbDiQuxhsOTwN2KRnFc6TKL4iLVDwJ/d6ZFcpwcc= X-Gm-Message-State: AOJu0YxZyQdKdjRN6993xzM3t0kh7AltMoLT+gdyifrN78YrkEdcP06j so8wlqUH6lxkIUA1XGyk/ANOp9col79FXVS+z3BChrhroMTtaUdicn9FJBpPc4sDWXn8RDVeLZI HSB5NwY85ptR0udgvOhVXv2dTtDQ= X-Google-Smtp-Source: AGHT+IHIt7RVdmGbwMYwMmlykKT9YL2sjMcp+oADgGZFXkjtV5H02q5EeSmZ/99B6pI/yYxerz79Y439dskVbVruUxM= X-Received: by 2002:ac2:4e0f:0:b0:51d:a1ca:5f26 with SMTP id 2adb3069b0e04-5221006f7b4mr4415e87.20.1715271555978; Thu, 09 May 2024 09:19:15 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284763 Archived-At: On Thu, May 9, 2024 at 4:00=E2=80=AFPM kobarity wrote: > > > Eli Zaretskii wrote: > > > > > From: Lin Sun > > > Date: Mon, 6 May 2024 00:28:07 +0000 > > > Cc: 70722@debbugs.gnu.org > > > > > > On Thu, May 2, 2024 at 6:55=E2=80=AFPM Eli Zaretskii w= rote: > > > > > > > > > From: Lin Sun > > > > > Date: Thu, 2 May 2024 18:11:04 +0000 > > > > > > > > > > The test case "package-test-update-archives-async" still tries to > > > > > search "python2" for testing, while python2 was at the end of its= life > > > > > years ago. > > > > > So move the test case from python2 to python3. > > > > > > > > I'd prefer to make the test support both Python 2.x and Python 3.x. > > > > The fact that python.org end-of-life'd Python 2 doesn't mean we hav= e > > > > to jump to attention and follow suit. Old systems might still have > > > > Python 2 installed, and there's no need to drop them. > > > > > > > > I do agree that we should try looking for Python 3 first, and only > > > > afterwards for Python 2. > > > > > > > > Also, I think the test should start by looking for just "python", > > > > before the versioned variants. > > > > > > > > E.g., on my system (executable-find "python3") returns nil, althoug= h I > > > > have Python 3.x installed -- but it's installed under the name > > > > "python". > > > Thanks for the comment, and it's true that python2 will still exist > > > for many years. > > > And I had changed the test case to adapt python/python3/python2 autom= atically. > > > Please help review the new patch. Thanks. > > > > Thanks. > > > > kobarity, any comments, or should I install this? > > I agree with the policy to support both Python 2/3. > How about a patch like the one attached? Hi Kobarity, your patch is a better one! :thumbsup: