From: Lin Sun <sunlin7.mail@gmail.com>
To: kobarity <kobarity@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, 70722@debbugs.gnu.org
Subject: bug#70722: [PATCH] ; Migrate to python3 for (package-test-update-archives-async)
Date: Thu, 9 May 2024 16:19:04 +0000 [thread overview]
Message-ID: <CABCREdoCcV=rcNkrkHX5iEcm7J6vfth1XGto4aFg0SJg7V4ndQ@mail.gmail.com> (raw)
In-Reply-To: <eke7frurt1pu.wl-kobarity@gmail.com>
On Thu, May 9, 2024 at 4:00 PM kobarity <kobarity@gmail.com> wrote:
>
>
> Eli Zaretskii wrote:
> >
> > > From: Lin Sun <sunlin7.mail@gmail.com>
> > > Date: Mon, 6 May 2024 00:28:07 +0000
> > > Cc: 70722@debbugs.gnu.org
> > >
> > > On Thu, May 2, 2024 at 6:55 PM Eli Zaretskii <eliz@gnu.org> wrote:
> > > >
> > > > > From: Lin Sun <sunlin7.mail@gmail.com>
> > > > > Date: Thu, 2 May 2024 18:11:04 +0000
> > > > >
> > > > > The test case "package-test-update-archives-async" still tries to
> > > > > search "python2" for testing, while python2 was at the end of its life
> > > > > years ago.
> > > > > So move the test case from python2 to python3.
> > > >
> > > > I'd prefer to make the test support both Python 2.x and Python 3.x.
> > > > The fact that python.org end-of-life'd Python 2 doesn't mean we have
> > > > to jump to attention and follow suit. Old systems might still have
> > > > Python 2 installed, and there's no need to drop them.
> > > >
> > > > I do agree that we should try looking for Python 3 first, and only
> > > > afterwards for Python 2.
> > > >
> > > > Also, I think the test should start by looking for just "python",
> > > > before the versioned variants.
> > > >
> > > > E.g., on my system (executable-find "python3") returns nil, although I
> > > > have Python 3.x installed -- but it's installed under the name
> > > > "python".
> > > Thanks for the comment, and it's true that python2 will still exist
> > > for many years.
> > > And I had changed the test case to adapt python/python3/python2 automatically.
> > > Please help review the new patch. Thanks.
> >
> > Thanks.
> >
> > kobarity, any comments, or should I install this?
>
> I agree with the policy to support both Python 2/3.
> How about a patch like the one attached?
Hi Kobarity, your patch is a better one! :thumbsup:
next prev parent reply other threads:[~2024-05-09 16:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 18:11 bug#70722: [PATCH] ; Migrate to python3 for (package-test-update-archives-async) Lin Sun
2024-05-02 18:54 ` Eli Zaretskii
2024-05-06 0:28 ` Lin Sun
2024-05-09 8:33 ` Eli Zaretskii
2024-05-09 16:00 ` kobarity
2024-05-09 16:19 ` Lin Sun [this message]
2024-05-11 10:07 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABCREdoCcV=rcNkrkHX5iEcm7J6vfth1XGto4aFg0SJg7V4ndQ@mail.gmail.com' \
--to=sunlin7.mail@gmail.com \
--cc=70722@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=kobarity@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).