From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Nicholas Drozd Newsgroups: gmane.emacs.bugs Subject: bug#33804: [PATCH] * src/editfns.c (insert-char): Skip unnecessary fixnum check Date: Wed, 19 Dec 2018 10:48:24 -0600 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1545238025 31556 195.159.176.226 (19 Dec 2018 16:47:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 19 Dec 2018 16:47:05 +0000 (UTC) To: 33804@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 19 17:47:01 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZezt-000841-1F for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Dec 2018 17:47:01 +0100 Original-Received: from localhost ([::1]:33004 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZf1z-0006y7-Mz for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Dec 2018 11:49:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33360) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZf1q-0006xf-T9 for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2018 11:49:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZf1q-0000W4-BH for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2018 11:49:02 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50763) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gZf1q-0000VX-71 for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2018 11:49:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gZf1q-0005Qv-1Q for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2018 11:49:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Nicholas Drozd Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Dec 2018 16:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 33804 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.154523813220868 (code B ref -1); Wed, 19 Dec 2018 16:49:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 19 Dec 2018 16:48:52 +0000 Original-Received: from localhost ([127.0.0.1]:55021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZf1g-0005QV-1l for submit@debbugs.gnu.org; Wed, 19 Dec 2018 11:48:52 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:51838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZf1f-0005QG-1E for submit@debbugs.gnu.org; Wed, 19 Dec 2018 11:48:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZf1Y-0000FC-O9 for submit@debbugs.gnu.org; Wed, 19 Dec 2018 11:48:45 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:49907) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gZf1Y-0000Ep-KB for submit@debbugs.gnu.org; Wed, 19 Dec 2018 11:48:44 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33170) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZf1X-0006nj-LM for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2018 11:48:44 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZf1U-0000Ap-UM for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2018 11:48:42 -0500 Original-Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]:45190) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gZf1T-00007I-US for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2018 11:48:40 -0500 Original-Received: by mail-lf1-x12e.google.com with SMTP id b20so15526156lfa.12 for ; Wed, 19 Dec 2018 08:48:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=Ga52XnQ0T0KKJoT2GmInx9h9NJ7s2AGAwb4eoD/l0SQ=; b=rwWrcliXWkAI8+oz0trUOBiwgnp3IVmhOiS7Ssks+f9ZhBj79CEwOkRVBWyW1ioHJZ /2hXXrszRI7LOP0g0N28bC/xss1zjm/QGoEMx+3SbcUuw87sRF48HhXuW2Vd0WPsTsX/ rdRJs/+z+wn1hDWDuloj3nj7rYlraZmGRHe4ZvPxmZVOR+C7ndWI5DpC+L7jyontgNsy tYSsw6Q0KTW3w1yXBzfvvlLlmwYucFJpZSfshksHpJcUQIPV/D/W3FRPim6KdHa7c/kp 5YhuFudngOXuPNypCwkAI+NcjQJZUbAix68SAdIqw2Zr2f5wbcvxdGdU5UzT5DRSgaFn evRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=Ga52XnQ0T0KKJoT2GmInx9h9NJ7s2AGAwb4eoD/l0SQ=; b=Q/exJ8BWZ3ftFKbjxDMIsXnT204g5veSCe/yzzbUtCrteEIbMbeESfkYyUJRj6RxSr eUO4p/ckS612Cna7yw9Y+3aX/aaSIcc/srqlDYchVAmO5LlrJsYCkv5yi09OqenC7L6h 1kBmxi/VokPGJQeWeh9drqOfhZbxmw/If962NHiDRz3TDWaMoESbPgbklE6jNYU4821g +UedrNLgYohpRkxx8QJ7btKNMDBhrdRCKENV9vAwtarYboNELAEKu3ASQaNn4JvADFW2 yOkzX0tMZgo2v2G7+hwfpr5HSumvmrArmd51MSxOcHLnyEcPC1dqls1fGmWGdG5gmk3M wILQ== X-Gm-Message-State: AA+aEWYSSH3pNJj6nTNiY/hBrUx1btLqhABkc42gO+0Yby2He11B00P9 SpM9e+Ztk1++0sW15vbEDF+apAxUVucW6sR6q9NlLG55CYs= X-Google-Smtp-Source: AFSGD/WzC5ociLqaPIcIQcFU8AM2pxgYAbecJQpWeyAVO7a7mSJcFTitUi+8Xxkv9e24j8fK4bOcabCniaEQ2pZd8Mk= X-Received: by 2002:a19:db4a:: with SMTP id s71mr13687273lfg.36.1545238116081; Wed, 19 Dec 2018 08:48:36 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153602 Archived-At: COUNT gets set to 1 when it is passed in as nil, and in that case there is no need to check its type. --- src/editfns.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/editfns.c b/src/editfns.c index 8df4ed107e..9bfab74a9a 100644 --- a/src/editfns.c +++ b/src/editfns.c @@ -1471,7 +1471,8 @@ called interactively, INHERIT is t. */) CHECK_CHARACTER (character); if (NILP (count)) XSETFASTINT (count, 1); - CHECK_FIXNUM (count); + else + CHECK_FIXNUM (count); c = XFIXNAT (character); if (!NILP (BVAR (current_buffer, enable_multibyte_characters))) -- 2.17.1