From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Nicholas Drozd Newsgroups: gmane.emacs.bugs Subject: bug#34291: Some EWW patches Date: Mon, 4 Feb 2019 18:26:49 -0600 Message-ID: References: <83d0oavuen.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000003c5a05811aab87" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="141152"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34291@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 05 01:28:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gqob1-000aXO-2g for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Feb 2019 01:28:15 +0100 Original-Received: from localhost ([127.0.0.1]:51779 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqob0-0004b2-0u for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Feb 2019 19:28:14 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38099) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqoaq-0004ZG-5U for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2019 19:28:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gqoao-0004IP-PR for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2019 19:28:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60649) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gqoao-0004IG-Ln for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2019 19:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gqoao-00072v-Cy for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2019 19:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Nicholas Drozd Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Feb 2019 00:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34291 X-GNU-PR-Package: emacs Original-Received: via spool by 34291-submit@debbugs.gnu.org id=B34291.154932643127021 (code B ref 34291); Tue, 05 Feb 2019 00:28:02 +0000 Original-Received: (at 34291) by debbugs.gnu.org; 5 Feb 2019 00:27:11 +0000 Original-Received: from localhost ([127.0.0.1]:59930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gqoZz-00071l-65 for submit@debbugs.gnu.org; Mon, 04 Feb 2019 19:27:11 -0500 Original-Received: from mail-lf1-f50.google.com ([209.85.167.50]:40390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gqoZw-00071U-5I for 34291@debbugs.gnu.org; Mon, 04 Feb 2019 19:27:08 -0500 Original-Received: by mail-lf1-f50.google.com with SMTP id v5so1341841lfe.7 for <34291@debbugs.gnu.org>; Mon, 04 Feb 2019 16:27:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/sLNJzBt8BVGxOMoW+Wze6RNVzgc2+jtGpRJr/zXvgc=; b=ZVW2el/dtygsw6IK/ZbOGNdt1OC1l7kuXD44Wsd0vm+usIUWdIlhO9XCEoipjHhL/7 1LM7mJWzLR38ogYn86+YwGtDOGXttcMxmTyEmwSeMh33PIKpssZtjFdYHRlqmajoFTqM dHHp7slTyuJuQiveQng20ibHX/IypENrVWW9tZovAI/Ob5U0eX1isSpyskvUWRgTuke5 Y0mKjrQshcfwtUcaTKmo/U/JCLRnmF0TRws2r1GnZSbWvwONH+w1sPB0UpUKlOHtklWQ Kes1bwV5hKXE2gBk++/baojA4ftbmNEFuha4ch1O2AXU/hj4p/iiZPDBRK9+BkbFrqiG AX/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/sLNJzBt8BVGxOMoW+Wze6RNVzgc2+jtGpRJr/zXvgc=; b=JZ68Pbl0/VjRFXrN3en7ZJUfMPUUh6y9k9tsoL6ME3g2LUtk1IPE0o7A3QBA0afT4e tesj/zbkXNZM7OTmLElhMcn7NpPAE5UK0O+jKRZgjo4OXK7Jv1Ytf2MR2//wKHgV1PLh 5RrkVxOf/mjCr3JoPyIUNIKmZcRV4PELGnZ2TBpFX89OHSfiQPoA55ZOfTQMs+X5I26Q A2cHrIZXhxcun1osSbKDBO9+f8X7D1wofq88uol+3HZ+nSxWxsqbUGH+AmuEk8iur1LZ dP4H7u1bWFKfIISkcTh/+Hl3b/Pbu2rQpEWA4SiMasn3YHaajqfYdyC0IUpZmYzmL0xf 8Qzg== X-Gm-Message-State: AHQUAub98cu8H+TNHHFXlIsO1UnPsAqYiu9aYvkGOSD1ujysNGZwHAQ3 NFr1ptOaQhwjd6wb5GL+CrDvHJcl9LgSijDjK6I= X-Google-Smtp-Source: AHgI3IYETbs2gxJYpKBw5wPRKq5s7IF2ORRmWsy2UG7Br8KgS3ujSBH79utvF8qm04cKTYH3aguW3yka8stfE84cBy0= X-Received: by 2002:a19:a98f:: with SMTP id s137mr1347663lfe.18.1549326421543; Mon, 04 Feb 2019 16:27:01 -0800 (PST) In-Reply-To: <83d0oavuen.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155104 Archived-At: --000000000000003c5a05811aab87 Content-Type: text/plain; charset="UTF-8" Feel free to fix any remaining formatting / style issues. On Sat, Feb 2, 2019 at 1:54 PM Eli Zaretskii wrote: > > > From: Nicholas Drozd > > Date: Sat, 2 Feb 2019 13:26:16 -0600 > > > > Subject: [PATCH 3/3] * lisp/net/eww.el (eww-download-callback): Fix download > > URL path > > > > Previously this wasn't handling download URLs correctly, resulting in > > all downloaded pages being named "!", "!(1)", etc. > > > > Take "https://emptysqua.re/blog/getaddrinfo-cpython-mac-and-bsd/" as > > an example. `url-path-and-query' breaks this down to > > "/blog/getaddrinfo-cpython-mac-and-bsd/", and this gets passed to > > `file-name-nondirectory'. But that path looks like a directory because > > of the trailing slash, so `eww-decode-url-file-name' would end up with > > an empty string. Instead, remove the trailing slash so that a nonempty > > file name is passed in. > > This log message lacks the ChangeLog-style list of functions that are > being changes, with short descriptions of the changes in each one. > (Same problem with the second patch.) > > Also, please leave 2 spaces between sentences. > > > - (path (car (url-path-and-query obj))) > > + (path (string-remove-suffix "/" (car (url-path-and-query obj)))) > > Please use directory-file-name here instead of string-remove-suffix. > > Btw, isn't it better to remove all the leading directories, leaving > just the last component (a.k.a. the "basename")? > > > * lisp/net/eww.el (eww-download) > > * doc/misc/eww.texi (Basics) > > This should tell what was changed in each function/node. See > CONTRIBUTE, and the examples in the ChangeLog files in the tree. > > > +the current page. The file will be written to the directory specified > ^^ > Two spaces between sentences, please. > > > +in @code{eww-download-directory} (Default: @file{~/Downloads/}). > > The "Default" part should not be capitalized (it's not a separate > sentence). > > Thanks. --000000000000003c5a05811aab87 Content-Type: text/x-patch; charset="US-ASCII"; name="0002-Use-link-under-point-or-current-URL-for-eww-download.patch" Content-Disposition: attachment; filename="0002-Use-link-under-point-or-current-URL-for-eww-download.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jrr0slkx1 RnJvbSBlNTY5ZDI0YTFmODAwNDE5NDczZTI5M2RkMTM1NDBjNTk1YzZiNTdlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWNrIERyb3pkIDxuaWNob2xhc2Ryb3pkQGdtYWlsLmNvbT4K RGF0ZTogU2F0LCAyIEZlYiAyMDE5IDEyOjM1OjAyIC0wNjAwClN1YmplY3Q6IFtQQVRDSCAyLzNd IFVzZSBsaW5rIHVuZGVyIHBvaW50IG9yIGN1cnJlbnQgVVJMIGZvciBld3ctZG93bmxvYWQKCiog bGlzcC9uZXQvZXd3LmVsIChld3ctZG93bmxvYWQpOiBQcmV2aW91c2x5IHRoZSBiZWhhdmlvciB3 YXMgdGhlIHVzZQp0aGUgbGluayB1bmRlciBwb2ludCBvciBlcnJvciBpZiB0aGVyZSB3YXNuJ3Qg b25lLgoqIGRvYy9taXNjL2V3dy50ZXhpIChCYXNpY3MpOiBVcGRhdGUgZG9jdW1lbnRhdGlvbi4K LS0tCiBkb2MvbWlzYy9ld3cudGV4aSB8IDcgKysrKy0tLQogbGlzcC9uZXQvZXd3LmVsICAgfCA2 ICsrKystLQogMiBmaWxlcyBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvZG9jL21pc2MvZXd3LnRleGkgYi9kb2MvbWlzYy9ld3cudGV4aQppbmRl eCAwODhkYTZmNWZlLi5kN2RjMzI4NDZlIDEwMDY0NAotLS0gYS9kb2MvbWlzYy9ld3cudGV4aQor KysgYi9kb2MvbWlzYy9ld3cudGV4aQpAQCAtMTI1LDkgKzEyNSwxMCBAQCBCYXNpY3MKIEB2aW5k ZXggZXd3LWRvd25sb2FkLWRpcmVjdG9yeQogQGtpbmRleCBkCiBAY2luZGV4IERvd25sb2FkCi0g IEEgVVJMIHVuZGVyIHRoZSBwb2ludCBjYW4gYmUgZG93bmxvYWRlZCB3aXRoIEBrYmR7ZH0KLShA Y29kZXtld3ctZG93bmxvYWR9KS4gIFRoZSBmaWxlIHdpbGwgYmUgd3JpdHRlbiB0byB0aGUgZGly ZWN0b3J5Ci1zcGVjaWZpZWQgaW4gQGNvZGV7ZXd3LWRvd25sb2FkLWRpcmVjdG9yeX0gKERlZmF1 bHQ6IEBmaWxle34vRG93bmxvYWRzL30pLgorICBBIFVSTCBjYW4gYmUgZG93bmxvYWRlZCB3aXRo IEBrYmR7ZH0gKEBjb2Rle2V3dy1kb3dubG9hZH0pLiAgVGhpcword2lsbCBkb3dubG9hZCB0aGUg bGluayB1bmRlciBwb2ludCBpZiB0aGVyZSBpcyBvbmUsIG9yIGVsc2UgdGhlIFVSTCBvZgordGhl IGN1cnJlbnQgcGFnZS4gIFRoZSBmaWxlIHdpbGwgYmUgd3JpdHRlbiB0byB0aGUgZGlyZWN0b3J5 IHNwZWNpZmllZAoraW4gQGNvZGV7ZXd3LWRvd25sb2FkLWRpcmVjdG9yeX0gKGRlZmF1bHQ6IEBm aWxle34vRG93bmxvYWRzL30pLgogCiBAZmluZGV4IGV3dy1iYWNrLXVybAogQGZpbmRleCBld3ct Zm9yd2FyZC11cmwKZGlmZiAtLWdpdCBhL2xpc3AvbmV0L2V3dy5lbCBiL2xpc3AvbmV0L2V3dy5l bAppbmRleCAzYjdkOWQ1YzJmLi4wYzhiZmZhNTc5IDEwMDY0NAotLS0gYS9saXNwL25ldC9ld3cu ZWwKKysrIGIvbGlzcC9uZXQvZXd3LmVsCkBAIC0xNTMxLDEwICsxNTMxLDEyIEBAIGV3dy1jb3B5 LXBhZ2UtdXJsCiAgIChraWxsLW5ldyAocGxpc3QtZ2V0IGV3dy1kYXRhIDp1cmwpKSkKIAogKGRl ZnVuIGV3dy1kb3dubG9hZCAoKQotICAiRG93bmxvYWQgVVJMIHVuZGVyIHBvaW50IHRvIGBld3ct ZG93bmxvYWQtZGlyZWN0b3J5Jy4iCisgICJEb3dubG9hZCBVUkwgdG8gYGV3dy1kb3dubG9hZC1k aXJlY3RvcnknLgorVXNlIGxpbmsgdW5kZXIgcG9pbnQgaWYgdGhlcmUgaXMgb25lLCBlbHNlIHRo ZSBjdXJyZW50IHBhZ2UgVVJMLiIKICAgKGludGVyYWN0aXZlKQogICAoYWNjZXNzLWZpbGUgZXd3 LWRvd25sb2FkLWRpcmVjdG9yeSAiRG93bmxvYWQgZmFpbGVkIikKLSAgKGxldCAoKHVybCAoZ2V0 LXRleHQtcHJvcGVydHkgKHBvaW50KSAnc2hyLXVybCkpKQorICAobGV0ICgodXJsIChvciAoZ2V0 LXRleHQtcHJvcGVydHkgKHBvaW50KSAnc2hyLXVybCkKKyAgICAgICAgICAgICAgICAgKGV3dy1j dXJyZW50LXVybCkpKSkKICAgICAoaWYgKG5vdCB1cmwpCiAgICAgICAgIChtZXNzYWdlICJObyBV UkwgdW5kZXIgcG9pbnQiKQogICAgICAgKHVybC1yZXRyaWV2ZSB1cmwgJ2V3dy1kb3dubG9hZC1j YWxsYmFjayAobGlzdCB1cmwpKSkpKQotLSAKMi4xNy4xCgo= --000000000000003c5a05811aab87 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-doc-misc-eww.texi-Basics-Fix-eww-manual-keybinding.patch" Content-Disposition: attachment; filename="0001-doc-misc-eww.texi-Basics-Fix-eww-manual-keybinding.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jrr0slj80 RnJvbSBmYjk1Y2RkNTU2NDFhOGVhOWI0ODE3NjYwNGExNDIwZmYyY2JiN2JmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWNrIERyb3pkIDxuaWNob2xhc2Ryb3pkQGdtYWlsLmNvbT4K RGF0ZTogU2F0LCAyIEZlYiAyMDE5IDEyOjMxOjQ0IC0wNjAwClN1YmplY3Q6IFtQQVRDSCAxLzNd ICogZG9jL21pc2MvZXd3LnRleGkgKEJhc2ljcyk6IEZpeCBld3cgbWFudWFsIGtleWJpbmRpbmcK CkMgaXMgYm91bmQgdG8gdXJsLWNvb2tpZS1saXN0LgotLS0KIGRvYy9taXNjL2V3dy50ZXhpIHwg MiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZm IC0tZ2l0IGEvZG9jL21pc2MvZXd3LnRleGkgYi9kb2MvbWlzYy9ld3cudGV4aQppbmRleCBiMjk5 ZWExZmI3Li4wODhkYTZmNWZlIDEwMDY0NAotLS0gYS9kb2MvbWlzYy9ld3cudGV4aQorKysgYi9k b2MvbWlzYy9ld3cudGV4aQpAQCAtMTE4LDcgKzExOCw3IEBAIEJhc2ljcwogQGZpbmRleCBld3ct dG9nZ2xlLWNvbG9ycwogQGZpbmRleCBzaHItdXNlLWNvbG9ycwogQGtpbmRleCBGCi0gIFRoZSBA a2Jke0N9IGNvbW1hbmQgKEBjb2Rle2V3dy10b2dnbGUtY29sb3JzfSkgdG9nZ2xlcyB3aGV0aGVy IHRvIHVzZQorICBUaGUgQGtiZHtNLUN9IGNvbW1hbmQgKEBjb2Rle2V3dy10b2dnbGUtY29sb3Jz fSkgdG9nZ2xlcyB3aGV0aGVyIHRvIHVzZQogSFRNTC1zcGVjaWZpZWQgY29sb3JzIG9yIG5vdC4g IFRoaXMgc2V0cyB0aGUgQGNvZGV7c2hyLXVzZS1jb2xvcnN9IHZhcmlhYmxlLgogCiBAZmluZGV4 IGV3dy1kb3dubG9hZAotLSAKMi4xNy4xCgo= --000000000000003c5a05811aab87 Content-Type: text/x-patch; charset="US-ASCII"; name="0003-lisp-net-eww.el-eww-download-callback-Fix-download-U.patch" Content-Disposition: attachment; filename="0003-lisp-net-eww.el-eww-download-callback-Fix-download-U.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jrr0sllj2 RnJvbSA2NGQ1OTgzYTE2ZmVlYzA1Nzg4OGZmODVjZDBiMDgxNzk4YmVjNGY3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWNrIERyb3pkIDxuaWNob2xhc2Ryb3pkQGdtYWlsLmNvbT4K RGF0ZTogU2F0LCAyIEZlYiAyMDE5IDEyOjUwOjAzIC0wNjAwClN1YmplY3Q6IFtQQVRDSCAzLzNd ICogbGlzcC9uZXQvZXd3LmVsIChld3ctZG93bmxvYWQtY2FsbGJhY2spOiBGaXggZG93bmxvYWQK IFVSTCBwYXRoCgpQcmV2aW91c2x5IHRoaXMgd2Fzbid0IGhhbmRsaW5nIGRvd25sb2FkIFVSTHMg Y29ycmVjdGx5LCByZXN1bHRpbmcgaW4KYWxsIGRvd25sb2FkZWQgcGFnZXMgYmVpbmcgbmFtZWQg IiEiLCAiISgxKSIsIGV0Yy4KLS0tCiBsaXNwL25ldC9ld3cuZWwgfCAyICstCiAxIGZpbGUgY2hh bmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9saXNwL25l dC9ld3cuZWwgYi9saXNwL25ldC9ld3cuZWwKaW5kZXggMGM4YmZmYTU3OS4uYmVjOTdiMTJkNiAx MDA2NDQKLS0tIGEvbGlzcC9uZXQvZXd3LmVsCisrKyBiL2xpc3AvbmV0L2V3dy5lbApAQCAtMTU0 NCw3ICsxNTQ0LDcgQEAgZXd3LWRvd25sb2FkCiAoZGVmdW4gZXd3LWRvd25sb2FkLWNhbGxiYWNr IChzdGF0dXMgdXJsKQogICAodW5sZXNzIChwbGlzdC1nZXQgc3RhdHVzIDplcnJvcikKICAgICAo bGV0KiAoKG9iaiAodXJsLWdlbmVyaWMtcGFyc2UtdXJsIHVybCkpCi0gICAgICAgICAgIChwYXRo IChjYXIgKHVybC1wYXRoLWFuZC1xdWVyeSBvYmopKSkKKyAgICAgICAgICAgKHBhdGggKGRpcmVj dG9yeS1maWxlLW5hbWUgKGNhciAodXJsLXBhdGgtYW5kLXF1ZXJ5IG9iaikpKSkKICAgICAgICAg ICAgKGZpbGUgKGV3dy1tYWtlLXVuaXF1ZS1maWxlLW5hbWUKICAgICAgICAgICAgICAgICAgIChl d3ctZGVjb2RlLXVybC1maWxlLW5hbWUgKGZpbGUtbmFtZS1ub25kaXJlY3RvcnkgcGF0aCkpCiAg ICAgICAgICAgICAgICAgICBld3ctZG93bmxvYWQtZGlyZWN0b3J5KSkpCi0tIAoyLjE3LjEKCg== --000000000000003c5a05811aab87--