unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Branislav Zahradník" <happy.barney@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 74509@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#74509: Feature request - smerge-mode
Date: Mon, 2 Dec 2024 08:59:32 +0100	[thread overview]
Message-ID: <CAB=rbOkJqFZ3iRCyc2n-sBff1iPoRAMPWhPEGCT2OwxJpDzKbw@mail.gmail.com> (raw)
In-Reply-To: <jwvbjxvvulc.fsf-monnier+emacs@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 2043 bytes --]

On Mon, 2 Dec 2024 at 00:51, Stefan Monnier <monnier@iro.umontreal.ca>
wrote:

> >> # keybinding
> >> would be nice to provide default keybinding for smerge-swap: C-c ^ s
>
> Interesting.  I've never found a use for that command, personally.
> Could you give some hint for the situations where you found it handy?
>

Example:
I keep my functions alphabetically ordered.
When I merge two changes which added function in same alphabetical place,
I often need to change their order.

same goes for if/else if sequence


> >> # smerge-extend
> >> Helpful when user intent to keep both.
>
> Sorry: to keep both what?
>

Both = lower + upper.

Using above example:
when I intent to keep both functions, end of block (eg: C, Java, Perl, ...)
will currently not appear twice,
should be manually added. Same for empty line separating functions.

On my current WIP such functions often shares more than one tailing line


>
> >> (defun smerge-extend ()
> >>   "Copy the line directly following the conflict into both upper and
> lower sections.
>
> Hmm... Why just one line and why only from the end?
>

One line - one can use it multiple times to add more.

And yes, you are right, it should accept numeric argument (negative for
preceding line).
Though I still believe common use case will be to extend with following.



> [ IOW, here as well, I'm curious what is the kind of scenario where you
>   use that command.  ]
>

Scenario described above.



>
> >> This is useful when both versions need to share some common code that
> follows the conflict."
>
> Hmm... my conflicts have usually 3 sections, so "both" isn't right.
>
> [ Unless you specifically chose 2-way conflicts, I recommend you
>   investigate how to get 3-way conflicts, because they give a lot more
>   information and allow for example `smerge-resolve` to "just work" in
>   more cases.  YMMV, but personally whenever I'm faced with a 2-way
>   conflict, I'm frustrated.  ]
>

Different experiences - I for example run mostly into 2-way conflicts


>
>
>         Stefan
>
>
Brano

[-- Attachment #2: Type: text/html, Size: 3653 bytes --]

  reply	other threads:[~2024-12-02  7:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-24  8:17 bug#74509: Feature request - smerge-mode Branislav Zahradník
2024-11-30 10:28 ` Eli Zaretskii
2024-12-01 23:51   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-02  7:59     ` Branislav Zahradník [this message]
2024-12-03  3:26       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-03  6:39         ` Branislav Zahradník

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAB=rbOkJqFZ3iRCyc2n-sBff1iPoRAMPWhPEGCT2OwxJpDzKbw@mail.gmail.com' \
    --to=happy.barney@gmail.com \
    --cc=74509@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).