From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "tenspd137 ." Newsgroups: gmane.emacs.bugs Subject: bug#35969: 26.2, Excorporate Date: Thu, 20 Jun 2019 14:34:48 -0600 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="61558"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Andreas Schwab , 35969@debbugs.gnu.org To: Thomas Fitzsimmons Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 20 22:48:19 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1he3yl-000Fsy-48 for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Jun 2019 22:48:19 +0200 Original-Received: from localhost ([::1]:52958 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1he3yk-00013z-4s for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Jun 2019 16:48:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46374) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1he3xn-00011d-WB for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2019 16:47:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1he3mx-0004gu-KK for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2019 16:36:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35793) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1he3mr-0004ey-Tx for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2019 16:36:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1he3mr-0007TQ-Pr for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2019 16:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "tenspd137 ." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jun 2019 20:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35969 X-GNU-PR-Package: emacs Original-Received: via spool by 35969-submit@debbugs.gnu.org id=B35969.156106290828662 (code B ref 35969); Thu, 20 Jun 2019 20:36:01 +0000 Original-Received: (at 35969) by debbugs.gnu.org; 20 Jun 2019 20:35:08 +0000 Original-Received: from localhost ([127.0.0.1]:49337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1he3m0-0007SE-1X for submit@debbugs.gnu.org; Thu, 20 Jun 2019 16:35:08 -0400 Original-Received: from mail-wm1-f66.google.com ([209.85.128.66]:38526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1he3ly-0007Rl-Jr for 35969@debbugs.gnu.org; Thu, 20 Jun 2019 16:35:07 -0400 Original-Received: by mail-wm1-f66.google.com with SMTP id s15so4411707wmj.3 for <35969@debbugs.gnu.org>; Thu, 20 Jun 2019 13:35:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vFcAfTQGp72kEe4hbXguCgjn2VveR42HhlOWEh7ebVQ=; b=HWl6KoM23ZPsAhWCEEwQXEAlAoNXq3x+dOUoa+AMWgbLVzy+LnvccmJyrH5rNlRgJy DgkWc4uQ+DmociWiDfd4uNkXhTzMWd6cZuPpKrVYlcP+LPEMArivmiM3nrDCTWhgaLUg LZWyxr0wsbTypjbL2ubBqkKYCU4f1NXXMkIrmuhzPNNYVvTGlbB9EgA891pj+IvwkNq3 Pjgz+D5JulR8JEIBTf0fNZN50dxvYSG1Fk85HYiUJi0BgIeTWLmwiPDjW7mDq0vBXdWi NhjJI47NncE+7dtKwkvsjDaJ7fh8U6FzpQRSct8LLQ2F1MK3S2hzEKE/qZ3EuQZmECx2 11dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vFcAfTQGp72kEe4hbXguCgjn2VveR42HhlOWEh7ebVQ=; b=CRXa2C7IfyYMQnEtigC6VDtIlhLPYOC1UgbVte+9tO+3lxreZxDKVDIy5oST9nD2T0 Orog0250NvBQ4J8MHKZhluQqhKDYfDGbTZTiTzOk2dyoJnfKscbgldZG6CJyM1J+US9d n6eAWLWcy29qJy6Twu7Q6BSHVFaK+Hej4Zg73YirmQxJlpfDIYkMeJ+lwdoz3ede5P6T b7PURJEP3VKm/khtd9vWP+GMkNvn6pVtheZm+Q02+XpfDzD6gHDRRBBT4xCd4bKB8PYW 2yNi23c7XQ2yl3qPkbRic2AqdtnrBMC4aG13zKz8dPmAnAoaHfNqRvLbjNjfAYvmu09s vp7w== X-Gm-Message-State: APjAAAX1gNZMucTQjaJn/PgqD4U2xtD2D9BTJiJ9a7LS6BbX2PrNQgyg 1YE1fmW05VdDXLynPSsdeI1me+phTw653Hqxvi8= X-Google-Smtp-Source: APXvYqxw/w4oUWnyNn7VbYUmigv1mOO6PXtUUXExDifyzCLmtAT5NLs9e3Uhbhulrn+N0Xr0Z1R5voRNjkC0gUquYH0= X-Received: by 2002:a7b:c450:: with SMTP id l16mr951487wmi.0.1561062900523; Thu, 20 Jun 2019 13:35:00 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160915 Archived-At: I haven't tried the first item on the list yet - ie reloading Andreas' function. i have tried to build emacs from https://github.com/emacs-mirror/emacs.git because I can't reach the official repo from my firewall for whatever reason. I am sure it is something here. Anyway, I was having problems because my built version (27.0.x) was getting seemingly mixed up with my current installation. I can try again later, but right now things are pretty busy at work. Thanks. On Tue, Jun 18, 2019 at 10:26 PM Thomas Fitzsimmons wrote: > > Hi, > > "tenspd137 ." writes: > > > So - I am not sure if I did it correctly, but I copied this function > > with Andreas' changes into a file: > > > > (defun url-https-proxy-after-change-function (_st _nd _length) > > (let* ((process-buffer (current-buffer)) > > (proc (get-buffer-process process-buffer))) > > (goto-char (point-min)) > > (when (re-search-forward "^\r?\n" nil t) > > (backward-char 1) > > ;; Saw the end of the headers > > (setq url-http-end-of-headers (set-marker (make-marker) (point))) > > (url-http-parse-response) > > (cond > > ((null url-http-response-status) > > ;; We got back a headerless malformed response from the > > ;; server. > > (url-http-activate-callback) > > (error "Malformed response from proxy, fail!")) > > ((= url-http-response-status 200) > > (if (gnutls-available-p) > > (condition-case e > > (let ((tls-connection (gnutls-negotiate > > :process proc > > :hostname (url-host url-current-object) > > :verify-error nil))) > > ;; check certificate validity > > (setq tls-connection > > (nsm-verify-connection tls-connection > > (url-host url-current-object) > > (url-port url-current-object))) > > (with-current-buffer process-buffer (erase-buffer)) > > (set-process-buffer tls-connection process-buffer) > > (setq url-http-after-change-function > > 'url-http-wait-for-headers-change-function) > > (set-process-filter tls-connection 'url-http-generic-filter) > > (process-send-string tls-connection > > ;; Use the non-proxy form of the request > > (let (url-http-proxy) > > (url-http-create-request)))) > > (gnutls-error > > (url-http-activate-callback) > > (error "gnutls-error: %s" e)) > > (error > > (url-http-activate-callback) > > (error "error: %s" e))) > > (error "error: gnutls support needed!"))) > > (t > > (url-http-debug "error response: %d" url-http-response-status) > > (url-http-activate-callback)))))) > > > > and then loaded it before running excorporate. After that, I did M-x > > excorporate, and the minibuffer returns: error in process filter: > > Server response is not an XML document > > In this scenario, if you immediately (without restarting Emacs/reloading > anything) re-run M-x excorporate does it still fail? I just want to > make sure that's not a transient failure. If it does fail the second > time, can you post the HTTP response from the server? > > > When I do the similar test by loading the url-http-create-request with > > Thomas's changes, I can get a connection and grab my schedule > > through the proxy. > > OK. > > > Let me know if I need to try something different. > > Are you in a position to build Emacs master tip and retry the experiment > without patching anything? > > Thanks, > Thomas > > > On Mon, Jun 17, 2019 at 4:08 PM Thomas Fitzsimmons wrote: > >> > >> Hi, > >> > >> Good to hear that the patch I posted worked! > >> > >> Yes, that's the patch that Andreas's commit > >> 84613dae5c34ea742dd9a3e56f5acb55f604b483 applied. From what I can tell, > >> you will not have that in Emacs 26.2. > >> > >> Can you try reverting my patch and applying Andreas's patch, and see if > >> Excorporate still works through the proxy? > >> > >> Thanks, > >> Thomas > >> > >> "tenspd137 ." writes: > >> > >> > The patch Thomas seems to work from behind the proxy. My current > >> > emacs version is 26.2, so I would think it would include the commit > >> > Andreas is talking about.... I went and looked it up - is this the > >> > correct commit? > >> > > >> > diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el > >> > index 53798f7..817c5ce 100644 > >> > --- a/lisp/url/url-http.el > >> > +++ b/lisp/url/url-http.el > >> > @@ -1412,7 +1412,9 @@ The return value of this function is the > >> > retrieval buffer." > >> > 'url-http-wait-for-headers-change-function) > >> > (set-process-filter tls-connection 'url-http-generic-filter) > >> > (process-send-string tls-connection > >> > - (url-http-create-request))) > >> > + ;; Use the non-proxy form of the request > >> > + (let (url-http-proxy) > >> > + (url-http-create-request)))) > >> > (gnutls-error > >> > (url-http-activate-callback) > >> > (error "gnutls-error: %s" e)) > >> > > >> > Thanks! > >> > > >> > -C > >> > > >> > > >> > On Sat, Jun 15, 2019 at 1:41 AM Andreas Schwab wrote: > >> >> > >> >> On Jun 14 2019, Thomas Fitzsimmons wrote: > >> >> > >> >> > diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el > >> >> > index 00803a103a..723d111d58 100644 > >> >> > --- a/lisp/url/url-http.el > >> >> > +++ b/lisp/url/url-http.el > >> >> > @@ -329,7 +329,10 @@ url-http-create-request > >> >> > ;; The request > >> >> > (or url-http-method "GET") " " > >> >> > (url-http--encode-string > >> >> > - (if using-proxy (url-recreate-url url-http-target-url) real-fname)) > >> >> > + (if (and using-proxy > >> >> > + (not (equal "https" (url-type url-http-target-url)))) > >> >> > + (url-recreate-url url-http-target-url) > >> >> > + real-fname)) > >> >> > >> >> That should already be handled by commit 84613dae5c. > >> >> > >> >> Andreas. > >> >> > >> >> -- > >> >> Andreas Schwab, schwab@linux-m68k.org > >> >> GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 > >> >> "And now for something completely different."