From: Jean-Philippe Gravel <jpgravel@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 13845@debbugs.gnu.org
Subject: bug#13845: 24.3.50; gud commands stop responding when using gdb-mi
Date: Sun, 5 May 2013 22:05:46 -0400 [thread overview]
Message-ID: <CAB3yAoh2QPNkTu4rspVG9CTA_m5fdpGLfE_44SAp5B3-sG7C8w@mail.gmail.com> (raw)
In-Reply-To: <jwvk3nengr4.fsf-monnier+emacs@gnu.org>
Hi Glenn and Stefan,
Thank's for the review. I will make the correction you propose and go
ahead with the commit.
Jean-Philippe
On Sun, May 5, 2013 at 1:28 AM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>> Thanks. I'm not familiar with gdb, so these are style comments only.
>
> Other than Glenn's comments, it looks fine, thank you.
> Just one more detail:
>
> The text in the ChangeLog files should ideally be redundant (i.e. we
> should be able to regenerate it from the commit log), so please make
> sure you use the same text for the commit messages (tho with the leading
> TABs removed) as the text you wrote in the ChangeLog.
>
> If you commit from vc-dir you should be able to use C-c C-a from the
> *VC-Log* buffer to grab the commit message from the ChangeLog files
> (tho it seems it currently only works if you tell VC exactly which files
> you want to commit, rather than just telling it to commit the top
> directory).
>
>
> Stefan
next prev parent reply other threads:[~2013-05-06 2:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 2:02 bug#13845: 24.3.50; gud commands stop responding when using gdb-mi Jean-Philippe Gravel
2013-04-30 3:32 ` Jean-Philippe Gravel
2013-04-30 18:54 ` Glenn Morris
2013-05-01 2:46 ` Jean-Philippe Gravel
2013-05-02 2:20 ` Glenn Morris
2013-05-05 5:28 ` Stefan Monnier
2013-05-06 2:05 ` Jean-Philippe Gravel [this message]
2013-05-14 18:52 ` Jean-Philippe Gravel
2013-05-14 19:23 ` Glenn Morris
2013-05-15 1:47 ` Jean-Philippe Gravel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAB3yAoh2QPNkTu4rspVG9CTA_m5fdpGLfE_44SAp5B3-sG7C8w@mail.gmail.com \
--to=jpgravel@gmail.com \
--cc=13845@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).