unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Oleksandr Manzyuk <manzyuk@gmail.com>
To: 10748@debbugs.gnu.org
Subject: bug#10748:
Date: Mon, 27 Feb 2012 22:10:33 +0000	[thread overview]
Message-ID: <CAAwZTsRiiRBbe+JyLDzzo1Akch5BnGqcTEBK9RQ-sncd5A47gQ@mail.gmail.com> (raw)
In-Reply-To: <20120207044845.GH2922@arendt.tychoish.net>

I'd like to confirm this problem.  I've chased it down to the function
`face-spec-reset-face' from lisp/faces.el.  The version from Emacs
23.2:

(defun face-spec-reset-face (face &optional frame)
  "Reset all attributes of FACE on FRAME to unspecified."
  (let ((attrs face-attribute-name-alist))
    (while attrs
      (let ((attr-and-name (car attrs)))
	(set-face-attribute face frame (car attr-and-name) 'unspecified))
      (setq attrs (cdr attrs)))))

The same function from trunk:

(defun face-spec-reset-face (face &optional frame)
  "Reset all attributes of FACE on FRAME to unspecified."
  (unless (eq face 'default)
    (let (reset-args)
      (dolist (attr-and-name face-attribute-name-alist)
	(push 'unspecified reset-args)
	(push (car attr-and-name) reset-args))
      (apply 'set-face-attribute face frame reset-args))))

Why does the latter not reset the default face?  If I start Emacs with
"emacs -Q", start the server with M-x server-start, and evaluate the
former definition in the *scratch* buffer, then doing "emacsclient -t"
from the terminal gives me a frame that respects my terminal
background color.

Best,
Sasha
-- 
Oleksandr Manzyuk
http://oleksandrmanzyuk.wordpress.com





  reply	other threads:[~2012-02-27 22:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20120206232927.GA23487@arendt.tychoish.net>
     [not found] ` <CAHZoxq-8CMT7tNADZE1+s5yU2-FM3Y+YgCVzMBNRF_uq6zWDhg@mail.gmail.com>
2012-02-07  4:48   ` bug#10748: colours in client on xterm (if an X frame is open at same time) sam
2012-02-27 22:10     ` Oleksandr Manzyuk [this message]
2012-02-28 14:30     ` bug#10748: Ping Oleksandr Manzyuk
2012-03-04 15:06     ` bug#10748: colours in client on xterm (if an X frame is open at same time) Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAwZTsRiiRBbe+JyLDzzo1Akch5BnGqcTEBK9RQ-sncd5A47gQ@mail.gmail.com \
    --to=manzyuk@gmail.com \
    --cc=10748@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).