From: Vladimir Kazanov <vekazanov@gmail.com>
To: brownts@troybrown.dev
Cc: 69714@debbugs.gnu.org
Subject: bug#69714: 30.0.50; ert-font-lock doesn't handle list of faces
Date: Mon, 11 Mar 2024 08:36:22 +0000 [thread overview]
Message-ID: <CAAs=0-3EZaUr1K1pq+oVM1NnFwUQPMmAwtMMrsJv3-Zw+hYUMQ@mail.gmail.com> (raw)
In-Reply-To: <CABvCZ41gWPvjCSTrVGs0iXQLQJwgU+h1VQ9yO7_mYSxWYKcU7Q@mail.gmail.com>
Hi,
Thanks for reporting this! I have a bunch of ert-font-lock
improvements in my local repo getting ready for submission, and can
look into your suggestions as well.
Do you have your unit test code somewhere in a public repo? It'd be
great to think of further improvements to support your use case.
Thanks,
Vlad
On Sun, 10 Mar 2024 at 20:33, Troy Brown <brownts@troybrown.dev> wrote:
>
> I'm trying to use this package to test out my tree-sitter mode, but am
> running into an issue with lists of faces. It's possible that the
> face for a location in the buffer will contain a list of 1 or more
> faces. For example, when I use the ":override 'prepend" keyword in
> the call to treesit-font-lock-rules, even if only a single face is
> specified for the rule that matches that section of the buffer, this
> will result in a list of one entry (i.e., "(face-name)").
>
> When this happens, ert-font-lock fails to recognize that this matches
> the face "face-name" (e.g., "^ face-name" will fail to match in this
> case). I feel the tool should recognize a list containing a single
> face as matching the face. Even worse however, it appears
> ert-font-lock doesn't support a list of faces in the comment. I tried
> to work around the original issue by using "^ (face-name)", but the
> tool silently ignores this, as it doesn't match the internal regular
> expression (which ended up allowing my test to pass without actually
> checking anything).
>
> I can't figure out a way to use this tool in its current state due to
> its lack of support for a list of faces. Also, I find that since it
> silently ignores incorrect comment syntax (e.g., "^face-name", "^
> (face-name)"), it gives a false illusion that it's actually performing
> those checks (and the checks are passing), when it's really just
> ignoring them. Maybe any comment line starting with a "^" or "<-"
> should be considered an assertion check and to fail if the rest of the
> syntax is not as expected. Maybe it should also fail the test if no
> assertion checks are found in a source file or string.
>
> Even if the tool would allow a list of a single face to match the
> supplied face in the comment, I think it should also allow for
> multiple faces to be listed in the comment. I have other places where
> multiple faces are used (e.g., "(font-lock-constant-face
> font-lock-variable-name-face)" to highlight a constant variable),
> which would not be testable with the current state of the package.
>
>
>
--
Regards,
Vladimir Kazanov
next prev parent reply other threads:[~2024-03-11 8:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-10 20:31 bug#69714: 30.0.50; ert-font-lock doesn't handle list of faces Troy Brown
2024-03-11 8:36 ` Vladimir Kazanov [this message]
2024-03-12 20:46 ` Vladimir Kazanov
2024-03-13 16:14 ` Troy Brown
2024-03-13 17:04 ` Vladimir Kazanov
2024-03-13 17:48 ` Troy Brown
2024-03-13 18:20 ` Vladimir Kazanov
2024-03-15 11:47 ` bug#69714: [PATCH] Improve ert-font-lock assertion parser (Bug#69714) Vladimir Kazanov
2024-03-28 9:41 ` Eli Zaretskii
2024-03-30 12:52 ` bug#69714: [PATCH] Improve ert-font-lock assertion parser Mattias Engdegård
2024-03-31 17:56 ` Vladimir Kazanov
2024-04-01 8:04 ` Mattias Engdegård
2024-04-01 8:17 ` Mattias Engdegård
2024-04-01 8:34 ` Vladimir Kazanov
2024-04-01 9:08 ` Mattias Engdegård
2024-04-01 9:12 ` Vladimir Kazanov
2024-04-01 9:15 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAs=0-3EZaUr1K1pq+oVM1NnFwUQPMmAwtMMrsJv3-Zw+hYUMQ@mail.gmail.com' \
--to=vekazanov@gmail.com \
--cc=69714@debbugs.gnu.org \
--cc=brownts@troybrown.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).