From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#41988: 28.0.50; Edebug unconditionally instruments definitions with &define specs Date: Mon, 8 Mar 2021 17:37:45 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="326"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41988@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 08 17:44:08 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lJIzH-000AYU-Nv for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Mar 2021 17:44:07 +0100 Original-Received: from localhost ([::1]:33132 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJIzG-0002oM-M5 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Mar 2021 11:44:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41030) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJIuM-0006Rw-Pc for bug-gnu-emacs@gnu.org; Mon, 08 Mar 2021 11:39:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33079) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJIuM-0001BG-I1 for bug-gnu-emacs@gnu.org; Mon, 08 Mar 2021 11:39:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lJIuM-0000g1-DA for bug-gnu-emacs@gnu.org; Mon, 08 Mar 2021 11:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Mar 2021 16:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41988 X-GNU-PR-Package: emacs Original-Received: via spool by 41988-submit@debbugs.gnu.org id=B41988.16152214832533 (code B ref 41988); Mon, 08 Mar 2021 16:39:02 +0000 Original-Received: (at 41988) by debbugs.gnu.org; 8 Mar 2021 16:38:03 +0000 Original-Received: from localhost ([127.0.0.1]:44625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJItP-0000en-Ke for submit@debbugs.gnu.org; Mon, 08 Mar 2021 11:38:03 -0500 Original-Received: from mail-oo1-f51.google.com ([209.85.161.51]:44516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJItO-0000eH-FU for 41988@debbugs.gnu.org; Mon, 08 Mar 2021 11:38:02 -0500 Original-Received: by mail-oo1-f51.google.com with SMTP id n19so2320848ooj.11 for <41988@debbugs.gnu.org>; Mon, 08 Mar 2021 08:38:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=DEug/6VJ1TmtnwCttqwjdKjXyyFEilNazt5cmNQ8M+o=; b=EcVNIxcOSma44chMFFUXNVkmMi7dqAUfnIuQPBeD2o3tZFlBYsIgA9eTWscvC+a6C2 5AJ4npEAB/ZJjpVOq8JZJvqTFO7clwh5FFjHi2Q6NWQQClUiAC5yRPaJTq7M/4NfePtc GCLswlgAL/fYtFVVML4b9vp45tfXmOvHpmRA3idv9Izu9GtB9gOX9+sUX8lTFI+VE7j3 JeV5q/Fwdmk+UfJ1uBmRAfDrPzpNR4XwhoBMz8oUT5MUZO6wGdP7kglBpj5HFpAtV953 ij348uS1s6WZp8PxHhlj5wMmzDSt6xRQlRFshB1v5iHKe8fBBO3bNKt9OD5eER6Napjy iXXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=DEug/6VJ1TmtnwCttqwjdKjXyyFEilNazt5cmNQ8M+o=; b=Lxa6Y1Mr7jes3XlTlS34eiX3RWgnSU9eDQRM3cmP0Jhw5ZrzwNhYwJf0t6qOoALgQT KlbxMW6eXKBjPgdPt2t3dRvhpXhgu3kY2yGbKHc6ThYaWWWa6ZePGECh6jPzax4hkvYa epphh+n7/WeUUCuv0ai+1HtweFH7uqBZRiwULOdIVPVKnJPmTZb8Mblx6qfuNyv6PjDg 1DG8A4LZAnLdfnQ3Kb7BzuZ+UyOIDPMXJKLN9+pdGdrS9qEKn+v48bk4aJnq0gyMWPQv Aow2WWrkETq5+Pcw//M6+ytiXSMdp7O18u+ueElTvlcFL3zE8UwOCXTvtUQpLSyM8eoK mzBQ== X-Gm-Message-State: AOAM531sMkoRM8gRk83uKiVFQBBLwTrSKLvcG1SriwY1BjXSz8kDl38I otjO59nTouuonSJYUFrAZ8bkxh2FJniBGPUkUuw= X-Google-Smtp-Source: ABdhPJxWg1wXcZMG8nCqcRGY7cy3XTL4tYqdpZMr/DdjX7IakwCmLaA2TTgqhbXydIJZtpwJnop+XpMs0/KEvoJKmso= X-Received: by 2002:a4a:e615:: with SMTP id f21mr19151104oot.91.1615221476826; Mon, 08 Mar 2021 08:37:56 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201853 Archived-At: Am Mo., 8. M=C3=A4rz 2021 um 17:33 Uhr schrieb Philipp Stephani : > > Am Di., 2. M=C3=A4rz 2021 um 18:28 Uhr schrieb Philipp Stephani > : > > > > Am Di., 2. M=C3=A4rz 2021 um 16:59 Uhr schrieb Stefan Monnier > > : > > > > > > > As an example, edebug-instrument (C-u C-M-x) the following definiti= on: > > > > > > > > (defun bar () > > > > (cl-flet ((foo () 1)) > > > > (foo))) > > > > > > > > The *Messages* buffer now says > > > > > > > > Edebug: foo [2 times] > > > > Edebug: bar > > > > > > I believe this is now fixed in `master`. > > > At least we only get a total of 2 messages rather than "3 collapsed t= o 2". > > > But I don't know enough about the code coverage to be sure that the > > > underlying problem you saw is also fixed. Can you confirm? > > > > Thanks! I'll check (hopefully in the next few days). > > Confirmed that the original issue is indeed fixed. Hmm, maybe I spoke too soon. The original issue with cl-flet is indeed fixed, but I think one likely explanation for that is that it now only has a single &define form. What about other macros that still have multiple &define forms in an &or form? Are they fixed as well?