From: Philipp Stephani <p.stephani2@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 25612@debbugs.gnu.org
Subject: bug#25612: 26.0.50; Slightly suboptimal message for disabled commands
Date: Fri, 03 Feb 2017 15:54:06 +0000 [thread overview]
Message-ID: <CAArVCkTppyxosR0fByMKq=W+fUxKzKs+YJxZ1DKdqEwv4vPJgw@mail.gmail.com> (raw)
In-Reply-To: <83wpd7tin9.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1239 bytes --]
Eli Zaretskii <eliz@gnu.org> schrieb am Fr., 3. Feb. 2017 um 16:10 Uhr:
>
> > This is a regression: it still works as expected in Emacs 23.4, but no
> longer in Emacs 24.3. Probably
> > something about this-command-keys or command-execute changed in the
> meantime so that the code in
> > novice.el no longer works as expected.
>
> Yes, this-command-keys returns just "^M" instead of the expected
> "\370erase-buffer^M" it returned in Emacs 24.2 and older.
>
git bisect says
b593d6a999b21dfee6939b24866a5ec6fbe7d11b is the first bad commit
commit b593d6a999b21dfee6939b24866a5ec6fbe7d11b
Author: Aaron S. Hawley <aaron.s.hawley@gmail.com>
Date: Tue May 1 12:10:02 2012 -0400
Reimplement execute-extended-command in Elisp.
* src/keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
Move to simple.el.
* lisp/simple.el (suggest-key-bindings, execute-extended-command):
Move from keyboard.c.
:040000 040000 980a3efdb92bf89c1042883830e7fbd1da063f3e
997099bae8bf4663aed645559b102345912f19fa M lisp
:040000 040000 832414759411034e7cea2c694fdb77273c422b05
ccf76976dd740fc43ccf84c35ddaf9efe19d5ec2 M src
That looks reasonable given that it touches code closely related to the
disabled command functionality.
[-- Attachment #2: Type: text/html, Size: 2049 bytes --]
next prev parent reply other threads:[~2017-02-03 15:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 12:34 bug#25612: 26.0.50; Slightly suboptimal message for disabled commands Philipp Stephani
2017-02-03 13:19 ` Eli Zaretskii
2017-02-03 14:15 ` Philipp Stephani
2017-02-03 15:10 ` Eli Zaretskii
2017-02-03 15:54 ` Philipp Stephani [this message]
2017-02-03 21:16 ` Eli Zaretskii
2017-02-10 9:00 ` Eli Zaretskii
2017-02-12 15:12 ` Philipp Stephani
2017-02-18 10:31 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAArVCkTppyxosR0fByMKq=W+fUxKzKs+YJxZ1DKdqEwv4vPJgw@mail.gmail.com' \
--to=p.stephani2@gmail.com \
--cc=25612@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).