From: Philipp Stephani <p.stephani2@gmail.com>
To: "Vincent Belaïche" <vincent.belaiche@gmail.com>,
"Eli Zaretskii" <eliz@gnu.org>,
27391-done@debbugs.gnu.org
Subject: bug#27391: 25.2.50; utf-8 coding cookie is not applied on some specific markdown file
Date: Sat, 17 Jun 2017 14:15:27 +0000 [thread overview]
Message-ID: <CAArVCkTnqMEWqbhjn9BXeRmsZTszJdTfuNvCs8LpzM3TiJL-gg@mail.gmail.com> (raw)
In-Reply-To: <a5593d96-fb61-0406-f1a5-d0dc43aa05d9@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2130 bytes --]
Vincent Belaïche <vincent.belaiche@gmail.com> schrieb am Sa., 17. Juni 2017
um 00:23 Uhr:
>
>
> Le 17/06/2017 à 00:09, Vincent Belaïche a écrit :
> >
> > Le 16/06/2017 à 21:37, Vincent Belaïche a écrit :
> >>
> >> Le 16/06/2017 à 21:15, Vincent Belaïche a écrit :
> > [...]
> >
> >>>
> >> After some more investigation, I think that the bug is in function
> >> insert-file-contents of fileio.c which is the one that decide and sets
> >> the coding system well before the other local variables are looked into.
> > I have located the bug.
> >
> > After some more investigation, in the end the find-auto-coding of
> > mule.el is what is called to detect the coding.
> >
> > This function evaluates this expression to find the local variables:
> >
> > (re-search-forward
> > "[\r\n]\\([^[\r\n]*\\)[ \t]*Local Variables:[
> \t]*\\([^\r\n]*\\)[\r\n]"
> > tail-end t)
> >
> > This expression evaluates to nil over file CONTRIBUTING.md
> >
> > I can make a simple fix if you tell me on which branch to do it.
> >
> > However I think that the root of the problem is poor code factorization
> > of local variable parsing between mule.el and file.el. A better, more
> > futureproof fix would be some unique local variable parser with some
> > input constrain telling what sort of setting are sought. The output of
> > the parse could be used in file.el and mule.el.
> >
> > Vincent.
> >
> >
> Ooops... my lengthy email of T23:34 was unwantedly sent. A shorter
> version with only the conclusion and w/o all the details of my
> investigation is above.
>
> Anyway, Philipp's patch is what I had in mind as a quick fix.
OK, I've pushed this commit as c3813b2aa8d2f5a625195fdbbfe6a01a602d7735.
> Although I
> don't think that this is a good solution not to factorize code when
> possible. Factorizing makes it more maintainable.
>
Agreed. Note that there's a third place in Emacs that parses a subset of
file-local variables: lread.c, to detect the lexical-binding variable when
loading ELisp files. Ideally that would be merged as well.
[-- Attachment #2: Type: text/html, Size: 2809 bytes --]
prev parent reply other threads:[~2017-06-17 14:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 10:00 bug#27391: 25.2.50; utf-8 coding cookie is not applied on some specific markdown file Vincent Belaïche
2017-06-16 12:59 ` Eli Zaretskii
2017-06-16 14:08 ` Vincent Belaïche
2017-06-16 14:10 ` Vincent Belaïche
2017-06-16 18:38 ` Eli Zaretskii
2017-06-16 19:08 ` Vincent Belaïche
2017-06-16 19:15 ` Vincent Belaïche
2017-06-16 19:31 ` Andreas Schwab
2017-06-16 19:37 ` Vincent Belaïche
2017-06-16 21:27 ` Vincent Belaïche
2017-06-16 21:34 ` Philipp Stephani
2017-06-16 21:39 ` Philipp Stephani
2017-06-16 21:52 ` Philipp Stephani
2017-06-16 22:09 ` Vincent Belaïche
2017-06-16 22:23 ` Vincent Belaïche
2017-06-17 5:45 ` Vincent Belaïche
2017-06-17 14:30 ` Philipp Stephani
2017-06-19 10:51 ` Vincent Belaïche
2017-06-26 11:39 ` Philipp Stephani
2017-06-27 6:05 ` Vincent Belaïche
2017-06-17 14:15 ` Philipp Stephani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAArVCkTnqMEWqbhjn9BXeRmsZTszJdTfuNvCs8LpzM3TiJL-gg@mail.gmail.com \
--to=p.stephani2@gmail.com \
--cc=27391-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=vincent.belaiche@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).