From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#25612: 26.0.50; Slightly suboptimal message for disabled commands Date: Fri, 03 Feb 2017 14:15:30 +0000 Message-ID: References: <831svfv2d5.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113deb20ab3ac90547a0eaf3 X-Trace: blaine.gmane.org 1486131370 27057 195.159.176.226 (3 Feb 2017 14:16:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 3 Feb 2017 14:16:10 +0000 (UTC) Cc: 25612@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 03 15:16:06 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZeek-0006tn-7a for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Feb 2017 15:16:06 +0100 Original-Received: from localhost ([::1]:34999 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZeep-0005Xz-Nt for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Feb 2017 09:16:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35992) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZeek-0005Wz-5M for bug-gnu-emacs@gnu.org; Fri, 03 Feb 2017 09:16:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZeeg-0000dY-5A for bug-gnu-emacs@gnu.org; Fri, 03 Feb 2017 09:16:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56425) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cZeeg-0000dQ-1F for bug-gnu-emacs@gnu.org; Fri, 03 Feb 2017 09:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cZeef-0004sR-MF for bug-gnu-emacs@gnu.org; Fri, 03 Feb 2017 09:16:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Feb 2017 14:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25612 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25612-submit@debbugs.gnu.org id=B25612.148613134918729 (code B ref 25612); Fri, 03 Feb 2017 14:16:01 +0000 Original-Received: (at 25612) by debbugs.gnu.org; 3 Feb 2017 14:15:49 +0000 Original-Received: from localhost ([127.0.0.1]:54624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZeeT-0004s1-6e for submit@debbugs.gnu.org; Fri, 03 Feb 2017 09:15:49 -0500 Original-Received: from mail-ot0-f179.google.com ([74.125.82.179]:34229) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZeeQ-0004rn-Mp for 25612@debbugs.gnu.org; Fri, 03 Feb 2017 09:15:47 -0500 Original-Received: by mail-ot0-f179.google.com with SMTP id f9so15070973otd.1 for <25612@debbugs.gnu.org>; Fri, 03 Feb 2017 06:15:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sToZwVirtNNibPFEYrRVxTuwQFTBkeKj+CL4nTyKLBU=; b=ZcDzUoIMdFxMUwVBaGDBRpcsREcWYl1p+xKsSHJP88ikRnVdxSUuieA3lPeZOXJWvi RaBlGqcWDCsi+ZRCwjgeK92Zq/0HPFql2Ef+0n/R4UwNC87Kibwxq5gHRvsRoD4g/8dU +ao5FlyLPAxNS0T1NqOcYUEyfXjYPftiVpn7J7GSwgTAahXsL+F947RM3fA6EmST7+Pj HPL6n31FsPa3ZgtYttmhl8Nkv2NXszisI6EdoX8x6JzO0DxxhIWdG3cVLytgKBl6bgHs /HMEQWLlsdAdU2klQCWUGt2VEwzpLrgiEHfQUekr22zvOoo7nR6BWlMkgJj+F9mreU+t CA8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sToZwVirtNNibPFEYrRVxTuwQFTBkeKj+CL4nTyKLBU=; b=sD+epSDcjXyr363kmj6HkMxoa6S50zjXTHccK4ttIu5XEBJn82yvjUt2iFj+HKGa2g AKQOBFHAj+e8QcYRdqABDj3THUbdIUL6OumuRfa5Z0wKhxJyOpddeF+2b8/rGHpCPrJ4 bkiA0NsV4ldBaCrWhMje/QRYf4OBr55QkrZB15hi/78L2BmgxAT8f/u2lGiYmAulyafE 1QYuzg5jK8jutrflFhdAstpk9ZiXOo5aAddqhDEc7j7MoAHDwq9+AT5A8FiUQBH9B5fU Q9pL3Qz0/oFVWZvprSdauS4SXAxL0XynlkWz2YD08SAEcERgPzmAp3zBf2UlIw50aJf3 3+zA== X-Gm-Message-State: AIkVDXJdKbQbFyT6jqMXH3oKvE74wDAaSbm/dXEohgF0Ljnp289W/2dVdUmBZsjsVGsRTyEoS5EmGflrHjYwpg== X-Received: by 10.157.15.186 with SMTP id d55mr7553221otd.146.1486131340981; Fri, 03 Feb 2017 06:15:40 -0800 (PST) In-Reply-To: <831svfv2d5.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128916 Archived-At: --001a113deb20ab3ac90547a0eaf3 Content-Type: text/plain; charset=UTF-8 Eli Zaretskii schrieb am Fr., 3. Feb. 2017 um 14:19 Uhr: > > From: Philipp Stephani > > Date: Fri, 03 Feb 2017 13:34:09 +0100 > > > > Run M-x erase-buffer. The *Disabled Command* buffer that shows up > > contains > > > > You have typed RET, invoking disabled command erase-buffer. > > > > This should rather be > > > > You have typed M-x erase-buffer RET, invoking disabled command > > erase-buffer. > > > > The RET alone of course didn't invoke the command, it just happens to be > > the last keystroke, so this message might be somewhat confusing. > > Depending on your POV, it could be argued that RET is the one that > actually invoked the command. > > Perhaps the message should avoid showing the key sequence at all? > It seems that this is the intention of lines 54 through 62 in novice.el, but it doesn't seem to work any more. This is a regression: it still works as expected in Emacs 23.4, but no longer in Emacs 24.3. Probably something about this-command-keys or command-execute changed in the meantime so that the code in novice.el no longer works as expected. --001a113deb20ab3ac90547a0eaf3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= Fr., 3. Feb. 2017 um 14:19=C2=A0Uhr:
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Fri, 03 Feb 2017 13:34:09 +0100
>
> Run M-x erase-buffer.=C2=A0 The *Disabled Command* buffer that shows u= p
> contains
>
>=C2=A0 =C2=A0You have typed RET, invoking disabled command erase-buffer= .
>
> This should rather be
>
>=C2=A0 =C2=A0You have typed M-x erase-buffer RET, invoking disabled com= mand
>=C2=A0 =C2=A0erase-buffer.
>
> The RET alone of course didn't invoke the command, it just happens= to be
> the last keystroke, so this message might be somewhat confusing.

Depending on your POV, it could be argued that RET is the one that
actually invoked the command.

Perhaps the message should avoid showing the key sequence at all?

It seems that this is the i= ntention of lines 54 through 62 in novice.el, but it doesn't seem to wo= rk any more.
This is a regression: it still works as expected in = Emacs 23.4, but no longer in Emacs 24.3. Probably something about this-comm= and-keys or command-execute changed in the meantime so that the code in nov= ice.el no longer works as expected.
--001a113deb20ab3ac90547a0eaf3--