From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#25352: 26.0.50; ffap-other-window should not change window configuration when not displaying a buffer Date: Sun, 26 Mar 2017 19:45:01 +0000 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=f403043892d40d6fa9054ba77725 X-Trace: blaine.gmane.org 1490557679 10574 195.159.176.226 (26 Mar 2017 19:47:59 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 26 Mar 2017 19:47:59 +0000 (UTC) To: 25352@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 26 21:47:55 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csE8g-0001Qr-My for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 Mar 2017 21:47:46 +0200 Original-Received: from localhost ([::1]:42092 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csE8m-0000xn-EY for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 Mar 2017 15:47:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51614) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csE73-0000OX-Td for bug-gnu-emacs@gnu.org; Sun, 26 Mar 2017 15:46:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1csE70-00029D-Kh for bug-gnu-emacs@gnu.org; Sun, 26 Mar 2017 15:46:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48007) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1csE70-00028k-Br for bug-gnu-emacs@gnu.org; Sun, 26 Mar 2017 15:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1csE70-0006X1-4J for bug-gnu-emacs@gnu.org; Sun, 26 Mar 2017 15:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Mar 2017 19:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25352 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25352-submit@debbugs.gnu.org id=B25352.149055752025060 (code B ref 25352); Sun, 26 Mar 2017 19:46:02 +0000 Original-Received: (at 25352) by debbugs.gnu.org; 26 Mar 2017 19:45:20 +0000 Original-Received: from localhost ([127.0.0.1]:46206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csE6K-0006W8-Ct for submit@debbugs.gnu.org; Sun, 26 Mar 2017 15:45:20 -0400 Original-Received: from mail-wr0-f174.google.com ([209.85.128.174]:36326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csE6I-0006Vv-Bm for 25352@debbugs.gnu.org; Sun, 26 Mar 2017 15:45:18 -0400 Original-Received: by mail-wr0-f174.google.com with SMTP id w11so16631745wrc.3 for <25352@debbugs.gnu.org>; Sun, 26 Mar 2017 12:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=91UIoTWf8psLkplYzTo0Xdqpwj+9Nf3HJkWxUl2jdXU=; b=lmSy0opsBlRLpQNR70qaDQQkbMduYj7zVjdxJFfbSvunu8zBqXcfaj4t/IU2i6A1hr 7hXsxhLlN/6OSXzErMr0J2NAUvzMOjuFi1pQqCifPFQiIsHLusNmI1YxQx66mB80bNHE G5k5vAZGTSSaspxzrUCEat0ZwMF7yIfokIcypZFvAQ6y40ssfMGOvycqUA+2y+FZcj5S lgiuoV7H7Ynnl2JWdEGGyhE9RXRIOsjYT44xcdt3yFoT11sv75haijN+GcieEKAezw+c swzeR0J8mLf7hBwjO8W8kYgaqNgK3M2UJj4ovMetVKtC84wKMaisYmf2JFe4QZrhruMR WJKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=91UIoTWf8psLkplYzTo0Xdqpwj+9Nf3HJkWxUl2jdXU=; b=CCci4mVcw0sqm/MuxiHle0ggnSQFW2W/uTtrVJ6z+5VNUFL5UI/k1JPGQVMlKCbjs2 vD3raueQwRx6AqDuQr4K5q9ldfAJpdwuzqIniqrSr/5dz/YHxDgMbrZWBHyFPajSMYB6 f5UhBCdZHTI7XABIvuky08bT6eVV1dGBFa6M4dS9GAlKDAA/5lZNbcckpmOV4tI7wjxw AyMmXbPJJ0FaKLeICh8fvESrnEI5wQpgJka83ueSk1tRRys70IW0cUSQnIwvU2oHBHE2 9xkqKL21Ymh73E4vzTlP4GvblA/OfGNCFA3z6TEQNKQXTF/EBeY3cc5MlsObU37id8OI GsuA== X-Gm-Message-State: AFeK/H1sMXMCA1hIxG5wr79ZqQVuh4q2rpr63tu0CWVZk/vVYSar1nkNjKrRek/HG0DdqN3BR9lT3lPTvPhlTA== X-Received: by 10.223.182.133 with SMTP id j5mr18996899wre.19.1490557512443; Sun, 26 Mar 2017 12:45:12 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:130990 Archived-At: --f403043892d40d6fa9054ba77725 Content-Type: multipart/alternative; boundary=f403043892d40d6fa4054ba77723 --f403043892d40d6fa4054ba77723 Content-Type: text/plain; charset=UTF-8 Philipp schrieb am Mi., 4. Jan. 2017 um 11:58 Uhr: > > Insert some URL, e.g. "http://www.gnu.org". > Move point inside the URL. > M-x load-library RET ffap RET > M-x ffap-other-window RET RET > The URL is now opened in the default browser, as expected. However, the > window is also split, even if the default browser is external (not > EWW). ffap-other-window should not change the window configuration > unless it has to display a buffer. > > Attached a patch. --f403043892d40d6fa4054ba77723 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Philip= p <p.stephani2@gmail.com>= ; schrieb am Mi., 4. Jan. 2017 um 11:58=C2=A0Uhr:

Insert some URL, e.g. "http://www.gnu.org".
Move point inside the URL.
M-x load-library RET ffap RET
M-x ffap-other-window RET RET
The URL is now opened in the default browser, as expected.=C2=A0 However, t= he
window is also split, even if the default browser is external (not
EWW).=C2=A0 ffap-other-window should not change the window configuration unless it has to display a buffer.


Attached a patch.=C2=A0
--f403043892d40d6fa4054ba77723-- --f403043892d40d6fa9054ba77725 Content-Type: text/plain; charset=US-ASCII; name="0001-ffap-Don-t-switch-window-unless-needed.txt" Content-Disposition: attachment; filename="0001-ffap-Don-t-switch-window-unless-needed.txt" Content-Transfer-Encoding: base64 Content-ID: <15b0c266e9628d874f91> X-Attachment-Id: 15b0c266e9628d874f91 RnJvbSBkMDk4MmFkNjViZGNlMjgzODc3N2M4ZGNkNjJiZmUyOTg2YjRlODcyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwIFN0ZXBoYW5pIDxwaHN0QGdvb2dsZS5jb20+CkRh dGU6IFN1biwgOCBKYW4gMjAxNyAxOTo0NDoyMiArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIGZmYXA6 IERvbid0IHN3aXRjaCB3aW5kb3cgdW5sZXNzIG5lZWRlZAoKV2hlbiB1c2luZyBmZmFwLW90aGVy LXdpbmRvdywgZG9uJ3QgY2hhbmdlIHRoZSB3aW5kb3cgY29uZmlndXJhdGlvbgp1bmxlc3MgYSBu ZXcgYnVmZmVyIGhhcyBhY3R1YWxseSBiZWVuIGNyZWF0ZWQgKEJ1ZyMyNTM1MikuCgoqIGxpc3Av ZmZhcC5lbCAoZmZhcC1vdGhlci1mcmFtZSk6IERvbid0IGNoYW5nZSB0aGUgd2luZG93CmNvbmZp Z3VyYXRpb24gaWYgbm8gbmV3IGJ1ZmZlciBoYXMgYmVlbiBjcmVhdGVkLgoqIHRlc3QvbGlzcC9m ZmFwLXRlc3RzLmVsIChmZmFwLW90aGVyLXdpbmRvdy0tYnVnLTI1MzUyKTogQWRkIHVuaXQKdGVz dC4KLS0tCiBsaXNwL2ZmYXAuZWwgICAgICAgICAgICB8IDExICsrKy0tLS0tLS0tCiB0ZXN0L2xp c3AvZmZhcC10ZXN0cy5lbCB8IDEzICsrKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMTYg aW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2ZmYXAuZWwg Yi9saXNwL2ZmYXAuZWwKaW5kZXggMWVhMzJiNzVmMS4uODc1MzExMTBiOCAxMDA2NDQKLS0tIGEv bGlzcC9mZmFwLmVsCisrKyBiL2xpc3AvZmZhcC5lbApAQCAtMTc2OCwxNCArMTc2OCw5IEBAIGZm YXAtb3RoZXItd2luZG93CiAgICJMaWtlIGBmZmFwJywgYnV0IHB1dCBidWZmZXIgaW4gYW5vdGhl ciB3aW5kb3cuCiBPbmx5IGludGVuZGVkIGZvciBpbnRlcmFjdGl2ZSB1c2UuIgogICAoaW50ZXJh Y3RpdmUpCi0gIChsZXQgKHZhbHVlKQotICAgIChzd2l0Y2gtdG8tYnVmZmVyLW90aGVyLXdpbmRv dwotICAgICAoc2F2ZS13aW5kb3ctZXhjdXJzaW9uCi0gICAgICAgKHNldHEgdmFsdWUgKGNhbGwt aW50ZXJhY3RpdmVseSAnZmZhcCkpCi0gICAgICAgKHVubGVzcyAob3IgKGJ1ZmZlcnAgdmFsdWUp IChidWZmZXJwIChjYXItc2FmZSB2YWx1ZSkpKQotCSAoc2V0cSB2YWx1ZSAoY3VycmVudC1idWZm ZXIpKSkKLSAgICAgICAoY3VycmVudC1idWZmZXIpKSkKLSAgICB2YWx1ZSkpCisgIChwY2FzZSAo c2F2ZS13aW5kb3ctZXhjdXJzaW9uIChjYWxsLWludGVyYWN0aXZlbHkgJ2ZmYXApKQorICAgICgo b3IgKGFuZCAocHJlZCBidWZmZXJwKSBiKSBgKCwoYW5kIChwcmVkIGJ1ZmZlcnApIGIpIC4gLF8p KQorICAgICAoc3dpdGNoLXRvLWJ1ZmZlci1vdGhlci13aW5kb3cgYikpKSkKIAogKGRlZnVuIGZm YXAtb3RoZXItZnJhbWUgKCkKICAgIkxpa2UgYGZmYXAnLCBidXQgcHV0IGJ1ZmZlciBpbiBhbm90 aGVyIGZyYW1lLgpkaWZmIC0tZ2l0IGEvdGVzdC9saXNwL2ZmYXAtdGVzdHMuZWwgYi90ZXN0L2xp c3AvZmZhcC10ZXN0cy5lbAppbmRleCA4MjdkNzUxYmU2Li4xODYyYzZjMzI3IDEwMDY0NAotLS0g YS90ZXN0L2xpc3AvZmZhcC10ZXN0cy5lbAorKysgYi90ZXN0L2xpc3AvZmZhcC10ZXN0cy5lbApA QCAtMjMsNiArMjMsNyBAQAogCiA7OzsgQ29kZToKIAorKHJlcXVpcmUgJ2NsLWxpYikKIChyZXF1 aXJlICdlcnQpCiAocmVxdWlyZSAnZmZhcCkKIApAQCAtNjYsNiArNjcsMTggQEAKICAgICAobGV0 ICgoZmZhcC1nb3BoZXItcmVnZXhwIG5pbCkpCiAgICAgICAoc2hvdWxkLW5vdCAoZmZhcC1nb3Bo ZXItYXQtcG9pbnQpKSkpKQogCisoZXJ0LWRlZnRlc3QgZmZhcC1vdGhlci13aW5kb3ctLWJ1Zy0y NTM1MiAoKQorICAiVGVzdCBmb3IgQnVnIzI1MzUyLiAgQ2hlY2tzIHRoYXQgdGhlIHdpbmRvdyBj b25maWd1cmF0aW9uIGlzCitsZWZ0IGFsb25lIHdoZW4gb3BlbmluZyBhIFVSTCBpbiBhbiBleHRl cm5hbCBicm93c2VyLiIKKyAgKGNsLWxldGYqICgob2xkIChjdXJyZW50LXdpbmRvdy1jb25maWd1 cmF0aW9uKSkKKyAgICAgICAgICAgICAoKHN5bWJvbC1mdW5jdGlvbiAnZmZhcC1wcm9tcHRlcikK KyAgICAgICAgICAgICAgKGxhbWJkYSAoKSAiaHR0cDovL3d3dy5nbnUub3JnIikpCisgICAgICAg ICAgICAgKHVybHMgbmlsKQorICAgICAgICAgICAgIChmZmFwLXVybC1mZXRjaGVyIChsYW1iZGEg KHVybCkgKHB1c2ggdXJsIHVybHMpIG5pbCkpKQorICAgIChzaG91bGQtbm90IChmZmFwLW90aGVy LXdpbmRvdykpCisgICAgKHNob3VsZCAoZXF1YWwgKGN1cnJlbnQtd2luZG93LWNvbmZpZ3VyYXRp b24pIG9sZCkpCisgICAgKHNob3VsZCAoZXF1YWwgdXJscyAnKCJodHRwOi8vd3d3LmdudS5vcmci KSkpKSkKKwogKHByb3ZpZGUgJ2ZmYXAtdGVzdHMpCiAKIDs7OyBmZmFwLXRlc3RzLmVsIGVuZHMg aGVyZQotLSAKMi4xMi4yCgo= --f403043892d40d6fa9054ba77725--