From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#39960: 28.0.50; Incompatible change to sql-add-product in Emacs 27 Date: Tue, 28 Jul 2020 22:06:00 +0200 Message-ID: References: <837dzwboes.fsf@gnu.org> <83k13o8tsb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15605"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "39960@debbugs.gnu.org" <39960@debbugs.gnu.org>, "michael@mauger.com" To: Michael Mauger Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 28 22:07:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k0VsV-0003x0-1A for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Jul 2020 22:07:11 +0200 Original-Received: from localhost ([::1]:34412 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k0VsU-0005um-3g for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Jul 2020 16:07:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43664) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k0VsM-0005ua-MW for bug-gnu-emacs@gnu.org; Tue, 28 Jul 2020 16:07:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47602) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k0VsM-0001lU-De for bug-gnu-emacs@gnu.org; Tue, 28 Jul 2020 16:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k0VsM-0001rY-7m for bug-gnu-emacs@gnu.org; Tue, 28 Jul 2020 16:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Jul 2020 20:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39960 X-GNU-PR-Package: emacs Original-Received: via spool by 39960-submit@debbugs.gnu.org id=B39960.15959667827106 (code B ref 39960); Tue, 28 Jul 2020 20:07:02 +0000 Original-Received: (at 39960) by debbugs.gnu.org; 28 Jul 2020 20:06:22 +0000 Original-Received: from localhost ([127.0.0.1]:59148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k0Vri-0001qX-0s for submit@debbugs.gnu.org; Tue, 28 Jul 2020 16:06:22 -0400 Original-Received: from mail-oo1-f49.google.com ([209.85.161.49]:44152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k0Vre-0001qF-6P for 39960@debbugs.gnu.org; Tue, 28 Jul 2020 16:06:21 -0400 Original-Received: by mail-oo1-f49.google.com with SMTP id o36so4048407ooi.11 for <39960@debbugs.gnu.org>; Tue, 28 Jul 2020 13:06:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=8zxcJ1jZGtbtdIejjz9k5nQ+rfKP7Oe1nRSGmBdltBQ=; b=VRvel9VC/98Jzk7LmbxGbezbo+WHl62OltHfizoZOFJCybaBQwltPg0x6LHoL1hhBk EgVMOy2TOsclxrFSAUCkRXOdFTrvhCH/GflVT74k+7aFHLopG/KO8Eq52/NSiLwY08o/ RLQuQC8XLqLhuVv9OoV3BJsjByMnd/Zn3EpTayaTrWPMh8WhTkDZf73SjNrWesqcvwqs 0z9s8Wlb1mPpV2HAttopqGx5e38nvEx9DyFtdb8qUiGclwtIFrAA0jpRgYSUquT86JWd oGXlxzhlbJ3GUtsxXqN2qSq/1VVXr1ReoJVNbOC6+ViTPqoBmxddIqzVZ7byfyx7WWZq P9QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=8zxcJ1jZGtbtdIejjz9k5nQ+rfKP7Oe1nRSGmBdltBQ=; b=s/2SeodwPuIUD7QgPqmibieS3TpXFYL2EOHfv0R5HeKqgno1G7o7Ca6lG2Weza8lhz Nf1tXKwrfiE/FWC2RVQDIYqvyT/ASRzr6zCwrOI3MBOnzOyoSENMjZgV2gD+iIObAlJI tTFX91jPBYE0KUh7K8t3W1CCWw4yf+KOTJcqgnSpqYJ+qkPXAo2tT9xXhtZEN5/o91R3 lpNTd7aHw2iAS9yTIdBemPry1FU3oLWoLnD0L+IzD0Ry7xhNkhaIpJM1WuH17Qk+EQUr pBGW0OwsJws/5DE44Yo3b7HhTn2IVSqjcstWBEIhzGPn3HzJd0JMti5pTdfIAT5ybBSJ vu2Q== X-Gm-Message-State: AOAM533T0cOrNFMYvfp2oFyYQ0HX5ZwqIjt8mxl03rZdkpaQAw0mnpvd Wg60pDd+3wmzzuJ2APd3DqEqggwtTDKuJJ+Wdg8= X-Google-Smtp-Source: ABdhPJwPjjnXhCmmYay/+BjNHoDMWCA20konvIIM99FDGUrl0D2v5lVLAQPH4T4BEbKrxF3s7xwIFApUwuPdZzx4kRI= X-Received: by 2002:a4a:3b0f:: with SMTP id s15mr23350355oos.71.1595966772509; Tue, 28 Jul 2020 13:06:12 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:183629 Archived-At: Am Mo., 23. M=C3=A4rz 2020 um 02:20 Uhr schrieb Michael Mauger : > > =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original = Message =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 > On Friday, March 13, 2020 5:53 AM, Eli Zaretskii wrote: > > > Ping! > > > > > Date: Sat, 07 Mar 2020 09:43:39 +0200 > > > From: Eli Zaretskii eliz@gnu.org > > > Cc: 39960@debbugs.gnu.org > > > > > > > From: Philipp p.stephani2@gmail.com > > > > Date: Fri, 06 Mar 2020 23:39:16 +0100 > > > > In Emacs 26, sql-add-product has the signature > > > > (sql-add-product PRODUCT DISPLAY &rest PLIST) > > > > However, in the Emacs 27 pretest the signature is now > > > > (sql-add-product PRODUCT DISPLAY &optional PLIST) > > > > Note the change from &rest to &optional. This is a breaking change = that > > > > breaks all users of sql-add-product. I've found quite a few uses of= the > > > > old signature in the wild, > > > > > > Thanks for reporting this. > > > Michael, could you please look into this ASAP? TIA. > > > Btw, this change of a public API is not in NEWS, AFAICT; if we decide > > > eventually on keeping the change, we should announce it in NEWS. > > Sorry for the delay. The massive switch to WFH and illness concerns at ho= me > interfered. All are fine, and I actually do get work done occasionally. No worries, and good to hear that! > > I've got the following patch to make. I assume it needs to be made to the > emacs-27 branch and corresponding patches made to master as well. If I > should only commit to master (same change is needed there) for cherry-pic= king > for emacs-27, let me know. Thanks for the patch! I noticed that it made it to master as commit 82a632edc8b80bf16d9b9f205474bf9724b084c0, but not to emacs-27, are you still planning to backport it?