From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#26712: other-window/frame versions of find-library Date: Sun, 07 May 2017 13:45:00 +0000 Message-ID: References: <8897133a-0836-23a6-6bbe-aecc6ec8b7c8@aurox.ch> <9b566259-457c-faf2-10e1-42c084afccea@aurox.ch> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=94eb2c1cc5c8cef8a0054eef547b X-Trace: blaine.gmane.org 1494164776 20368 195.159.176.226 (7 May 2017 13:46:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 7 May 2017 13:46:16 +0000 (UTC) To: "Charles A. Roelli" , 26712@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 07 15:46:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7MVo-0005Aa-1G for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 May 2017 15:46:12 +0200 Original-Received: from localhost ([::1]:55516 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7MVq-0002Fn-Cv for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 May 2017 09:46:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46265) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7MVh-0002Fe-Rs for bug-gnu-emacs@gnu.org; Sun, 07 May 2017 09:46:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d7MVe-00048q-Pf for bug-gnu-emacs@gnu.org; Sun, 07 May 2017 09:46:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:32841) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d7MVe-00048l-K0 for bug-gnu-emacs@gnu.org; Sun, 07 May 2017 09:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d7MVe-00040v-BO for bug-gnu-emacs@gnu.org; Sun, 07 May 2017 09:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 May 2017 13:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26712 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 26712-submit@debbugs.gnu.org id=B26712.149416471915378 (code B ref 26712); Sun, 07 May 2017 13:46:02 +0000 Original-Received: (at 26712) by debbugs.gnu.org; 7 May 2017 13:45:19 +0000 Original-Received: from localhost ([127.0.0.1]:59273 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7MUx-0003zy-5A for submit@debbugs.gnu.org; Sun, 07 May 2017 09:45:19 -0400 Original-Received: from mail-wr0-f177.google.com ([209.85.128.177]:34912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7MUu-0003zk-Cl for 26712@debbugs.gnu.org; Sun, 07 May 2017 09:45:16 -0400 Original-Received: by mail-wr0-f177.google.com with SMTP id z52so25617239wrc.2 for <26712@debbugs.gnu.org>; Sun, 07 May 2017 06:45:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=7SEQNKn8o9g21GhtrYQa6Sa8L/qqg4b0PKma5ub6AHw=; b=dIugvhDh1lyqk50sbU5/hcAZWy7vSkIvIkyXJJfg7q8NCuUvwXGYd+L83Y1QslSOYD cI2ioYVhCErXtdvEhC20QaqH7nqIOKNfDRoRrDS2/BusIxrMe83Q/zDm+dX0055K97NW CvfEClc86hVGsoDbBmYsD3gjKkIxNDFEErP47xkU+valTpVAEO1aCuiu6wxFszA2LgWL 1wJAPgBdHgnkHIPvFO53fhe42c4SO+6Ss+LWnT9aSzq7YhQAy1onMFo1D6EK3mrOWgyy GL3tJGmqjmbw7U8Gmwqi3Eka9L6jxqz4fn6YIqKRKizkFUER8E2k386mo9+3qmqE/X8q lwbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=7SEQNKn8o9g21GhtrYQa6Sa8L/qqg4b0PKma5ub6AHw=; b=EWZRghSP2uklzKHPaVtE4N63nAcYSfHCLz2PqIb1iFAeA1mAEH6JYDor46N1+p9e41 i6ddsyCkR2YDy3M07eXGhQEf+tESvMaoCT1HNAHeIymrzZzza4ArYljxFQuO2dJx1/DA /hrEBKNVXLqEmtJabWkhVHMjkh93lcXN+6GUsRCHW7gzH+psfyZi03QkBTGEqb+628pp mK4mQ0KAuvgET+VAN0mwcyUjlU+11HeDuOW9bBq2BUZikyjN/NqqKc8blTpFtsHhSmSP oWubv47Es+utvb29WKKO6686wFSjrUY2e/PWVS+HiFDMnbcEeg5SlrLrN54xP8RWjUeP 7YjQ== X-Gm-Message-State: AN3rC/5jVb5tvqP+8iSNYwXxJ1vKMUvPPGF+5TQjASiMx0PgdGB6/nIF hvdLufKFyoqFmbRc8n+8m91EFanPZg== X-Received: by 10.223.170.67 with SMTP id q3mr12941109wrd.19.1494164710551; Sun, 07 May 2017 06:45:10 -0700 (PDT) In-Reply-To: <9b566259-457c-faf2-10e1-42c084afccea@aurox.ch> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132340 Archived-At: --94eb2c1cc5c8cef8a0054eef547b Content-Type: text/plain; charset=UTF-8 Charles A. Roelli schrieb am So., 7. Mai 2017 um 15:36 Uhr: > I would install it, but I don't have commit access. Ah, OK. Then a couple of minor comments: - Consider renaming `find-library-read' to `find-func--read-library' to make it internal. It's probably not intended as a public API. - (funcall 'foo ...) should be written as (foo ...) - Please revert unrelated whitespace changes (changing tabs to spaces in find-function-do-it) --94eb2c1cc5c8cef8a0054eef547b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Charle= s A. Roelli <charles@aurox.ch>= ; schrieb am So., 7. Mai 2017 um 15:36=C2=A0Uhr:
I would install it, but I don't have commit access.=C2=A0=

Ah, OK. Then a couple of minor comments:

- Consider renaming `find-library-read' to `fin= d-func--read-library' to make it internal. It's probably not intend= ed as a public API.

- (funcall 'foo ...) shoul= d be written as (foo ...)

- Please revert unrelate= d whitespace changes (changing tabs to spaces in find-function-do-it)=C2=A0=
--94eb2c1cc5c8cef8a0054eef547b--