From: Philipp Stephani <p.stephani2@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 41988@debbugs.gnu.org
Subject: bug#41988: 28.0.50; Edebug unconditionally instruments definitions with &define specs
Date: Mon, 5 Apr 2021 16:32:16 +0200 [thread overview]
Message-ID: <CAArVCkTOX6kDAF6KHFy7BJzJAeO4w15mFdUkZVwTgE-SJqf9rg@mail.gmail.com> (raw)
In-Reply-To: <jwv4kglvmq2.fsf-monnier+emacs@gnu.org>
Am So., 4. Apr. 2021 um 22:16 Uhr schrieb Stefan Monnier
<monnier@iro.umontreal.ca>:
>
> >> [ Disclaimer: I don't understand the precise semantics of `gate`, tho
> >> I do remember using it once via trial-and-error. So maybe it wouldn't
> >> prevent it, but if doesn't prevent it, then it doesn't likely "fix"
> >> our problem ;-) ]
> > AIUI the semantics of "gate" aren't that complex, it just means "don't
> > backtrack beyond this point."
>
> [ Yes, that's the part I understand. But it's not clear where
> backtracking is possible and where it's not. At least, the code that
> I saw in edebug.el didn't match my expectations back when I looked at
> it, hence my not feeling quite sure what the semantics are (and/or
> should be).
> IIRC the issue was that the scope of that effect wasn't clear: if you
> think of Prolog's cut, its effect is local to a particular definition,
> whereas I think the scope of `gate` is not nearly as clear because
> there isn't such a notion of "definition". ]
I agree that the code isn't terribly clear and probably has some bugs.
However, the "prevent backtracking through gates" seems to work at
least somewhat (experimentally, in this case I can turn the double
definition into an error).
> >> > so I think it would be reasonable to prevent. We already
> >> > disable backtracking for literal symbols, and I think forms that require
> >> > multiple &define forms with backtracking should be exceedingly rare and can
> >> > be rewritten as you did with cl-flet.
> >> Emitting a warning would be much more helpful than just silently
> >> "cut"ting the backtracking.
> > A gate isn't silent, it would cause a hard error in this case.
>
> What I meant is that a gate would just make the old cl-flet spec fail in
> most cases, with no explanation why that spec now fails even though it
> worked in the past.
Yes, we'd need to at least announce the change in NEWS as an
incompatible Lisp change. However, I think overall that's still better
than the current situation: with your fix to cl-flet the problematic
constructs shouldn't occur any more in the Emacs codebase, and I
wouldn't expect such constructs to be very frequent "in the wild", so
the overall breakage would be very small, and if it can avoid
similarly subtle bugs then I think it's warranted.
next prev parent reply other threads:[~2021-04-05 14:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-21 16:58 bug#41988: 28.0.50; Edebug unconditionally instruments definitions with &define specs Philipp
[not found] ` <mailman.222.1592758804.2574.bug-gnu-emacs@gnu.org>
2020-06-21 23:48 ` Alan Mackenzie
2020-08-08 11:01 ` Philipp Stephani
2020-08-08 14:59 ` Alan Mackenzie
2020-08-09 11:33 ` Philipp Stephani
2020-08-09 16:35 ` Alan Mackenzie
2020-08-10 13:32 ` Philipp Stephani
2021-03-02 15:59 ` Stefan Monnier
2021-03-02 17:28 ` Philipp Stephani
2021-03-08 16:33 ` Philipp Stephani
2021-03-08 16:37 ` Philipp Stephani
2021-03-08 17:41 ` Stefan Monnier
2021-03-14 16:32 ` Philipp
2021-03-14 17:38 ` Stefan Monnier
2021-03-18 11:19 ` Philipp
2021-03-18 14:01 ` Stefan Monnier
2021-03-21 13:34 ` Philipp
2021-03-21 14:37 ` Stefan Monnier
2021-04-04 18:40 ` Philipp Stephani
2021-04-04 20:16 ` Stefan Monnier
2021-04-05 14:32 ` Philipp Stephani [this message]
2021-04-10 15:07 ` Philipp
2021-04-10 15:51 ` Stefan Monnier
2021-04-10 16:23 ` Philipp
2021-04-10 17:29 ` Eli Zaretskii
2021-04-10 18:12 ` Stefan Monnier
2021-04-10 19:54 ` Philipp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAArVCkTOX6kDAF6KHFy7BJzJAeO4w15mFdUkZVwTgE-SJqf9rg@mail.gmail.com \
--to=p.stephani2@gmail.com \
--cc=41988@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).