From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#19977: 24.4; Incorrect translation of Super modifier with Ctrl or Meta on OS X Date: Sun, 04 Feb 2018 19:07:14 +0000 Message-ID: References: <83d1qdw7bt.fsf@gnu.org> <834mbowuxw.fsf@gnu.org> <20171226211603.GA82103@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="089e082fb8e0e928a5056467a75c" X-Trace: blaine.gmane.org 1517771229 3852 195.159.176.226 (4 Feb 2018 19:07:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 4 Feb 2018 19:07:09 +0000 (UTC) Cc: adrian.b.robert@gmail.com, 19977@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 04 20:07:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiPd1-0000cn-3P for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Feb 2018 20:07:03 +0100 Original-Received: from localhost ([::1]:56100 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eiPf2-0005jz-5V for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Feb 2018 14:09:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41417) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eiPe1-0004ve-N4 for bug-gnu-emacs@gnu.org; Sun, 04 Feb 2018 14:08:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eiPdy-0008GG-Ed for bug-gnu-emacs@gnu.org; Sun, 04 Feb 2018 14:08:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49442) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eiPdy-0008G2-A7 for bug-gnu-emacs@gnu.org; Sun, 04 Feb 2018 14:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eiPdx-0007Wl-VM for bug-gnu-emacs@gnu.org; Sun, 04 Feb 2018 14:08:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Feb 2018 19:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19977 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 19977-submit@debbugs.gnu.org id=B19977.151777125228898 (code B ref 19977); Sun, 04 Feb 2018 19:08:01 +0000 Original-Received: (at 19977) by debbugs.gnu.org; 4 Feb 2018 19:07:32 +0000 Original-Received: from localhost ([127.0.0.1]:57339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiPdU-0007W1-Cw for submit@debbugs.gnu.org; Sun, 04 Feb 2018 14:07:32 -0500 Original-Received: from mail-lf0-f51.google.com ([209.85.215.51]:40794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiPdS-0007Vp-R2 for 19977@debbugs.gnu.org; Sun, 04 Feb 2018 14:07:31 -0500 Original-Received: by mail-lf0-f51.google.com with SMTP id h92so38754263lfi.7 for <19977@debbugs.gnu.org>; Sun, 04 Feb 2018 11:07:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RNSvTw0CX2akuPrew7UCa2dO87y1GqM+F5KZdZoKFN4=; b=TB8RTfjAfQ3/do86LMxvd99EZ4+41pO/W6E76x0mF4xkwQr3JjrcUtZhr3hD3ZwafS uHhxaTfPE7rIJclZxFtZovnGOwmV7855eYchItW12vAxjCGpR0TvApWKISsLV8ktY12G D0QZpIlehcHAX3+y/ATAXysemT3xos3Iq+NU3RnvDv1cFW3r2giqgZOcXXvt/D5bKv7f vlrL29bZTsMfzcOX0P406pTzU8n1hS+iA0ES+pSOh8N+AxNrZT+SpWFzUXxkKOBxVGAJ 56GLGqZxGEN0chOOOteLmsY65YmQOyiyqjLTDsS9i1D5TdrkYuBSictZ7thqlFqyxF0+ PEjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RNSvTw0CX2akuPrew7UCa2dO87y1GqM+F5KZdZoKFN4=; b=O/WXH6nO7UIcG0LZwU2A1uhZznQf01BE28SPq0aMFzTu10ceEs4UEbopucniELPsgo PyaGkLukWaUG1cZPSe1HKFRobA/VN8BTn+4CflijMrI62AwbkSWcfkQTo89/ciXonued 4PhKgwswvtaoPOTY7a25CFbQ/3kK+nYbItrPKiWqBJpbKJnicUQ6+J2GngfxT8kSu2se OuwgEuQyU7ub5JZb9reoizrWjHszAq22WiQfSyQTaC7PzhOGA5nTsJg154Ui617DvJqk 9U4vPnSiUKzKwXpJEXnTHYxPUaDVU/7dg9ffvfFwNOx7/a0aE4WY0M3FCsRollbqKzA0 G0YA== X-Gm-Message-State: AKwxytfsmhnjDI/eHuvjbv9JRys9klvb5FJ+fNuTbNssF2LiWAddd+yO yNbGhY9EeYnY4LHIENnVqIA+8kiru0hJsJFaA2A= X-Google-Smtp-Source: AH8x226ae5ZPcOYlz4jFVQFzaiyk7sPUb9wu9EuqJeUhoJbH7rjOxek4uitA5lK7OWkH+zKuyzokORwkjP/8rcEQK4k= X-Received: by 10.46.51.7 with SMTP id d7mr21189340ljc.78.1517771245035; Sun, 04 Feb 2018 11:07:25 -0800 (PST) In-Reply-To: <20171226211603.GA82103@breton.holly.idiocy.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142900 Archived-At: --089e082fb8e0e928a5056467a75c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Alan Third schrieb am Di., 26. Dez. 2017 um 22:16 Uhr: > On Tue, Dec 26, 2017 at 08:14:59PM +0000, Philipp Stephani wrote: > > Alan Third schrieb am Di., 26. Dez. 2017 um 18:42 Uhr= : > > > > > Do you think this patch is still good? > > > > > > > I think so, modulo the caveats mentioned in the comments. Do you want m= e > to > > rebase and commit it? > > As far as I can tell from the comments with the patch installed we > should be no worse off than we are at the moment? > I think it introduces some minor other issues (when a shift-like and a control-like key are used at the same time), but the overall benefit should be positive. > > I can=E2=80=99t quite work this out from a quick look at the code, but is= it > the case that when option or command is bound to meta or super then it > acts as a control=E2=80=90like modifier, but when it=E2=80=99s unbound th= en it acts as > a shift=E2=80=90like modifier? > The macOS code doesn't check whether certain keystrokes are bound. Rather, it uses the ns-FOO-modifier customization options. > > So this should give us the same behaviour for both keys that we have > with option just now? > Yes, command and option should have the same behavior (controlled by customization options). > > > If the latter, I'm not sure whether the macOS event model allows us to = do > > this. As mentioned in the comments in the patch, some information just > > appears to be lost entirely. > > I recently found myself using this lovely binding: > > (define-key global-map [C-s-268632064] > 'ns-do-show-character-palette) > > and it seems crazy to me that the default behaviour of Emacs requires > us to use 268632064 instead of SPC when we could tell people using > unusual keyboard layouts to set a variable or something instead. > > As for losing data, as long as it=E2=80=99s no worse than what we have at= the > moment, which I believe you said is the case in a previous email, then > I don=E2=80=99t see a problem with that. > > But perhaps I=E2=80=99ve misunderstood and there=E2=80=99s some worse beh= aviour? > > I think it should be a significant improvement in practice. I'd suggest to apply it and see whether we get any complaints. --089e082fb8e0e928a5056467a75c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Alan T= hird <alan@idiocy.org> schrieb= am Di., 26. Dez. 2017 um 22:16=C2=A0Uhr:
On Tue, Dec 26, 2017 at 08:14:59PM +0000, Philipp Stephani wrote: > Alan Third <al= an@idiocy.org> schrieb am Di., 26. Dez. 2017 um 18:42 Uhr:
>
> > Do you think this patch is still good?
> >
>
> I think so, modulo the caveats mentioned in the comments. Do you want = me to
> rebase and commit it?

As far as I can tell from the comments with the patch installed we
should be no worse off than we are at the moment?

=
I think it introduces some minor other issues (when a shift-like= and a control-like key are used at the same time), but the overall benefit= should be positive.
=C2=A0

I can=E2=80=99t quite work this out from a quick look at the code, but is i= t
the case that when option or command is bound to meta or super then it
acts as a control=E2=80=90like modifier, but when it=E2=80=99s unbound then= it acts as
a shift=E2=80=90like modifier?

The macO= S code doesn't check whether certain keystrokes are bound. Rather, it u= ses the ns-FOO-modifier customization options.
=C2=A0

So this should give us the same behaviour for both keys that we have
with option just now?

Yes, command and = option should have the same behavior (controlled by customization options).=
=C2=A0

> If the latter, I'm not sure whether the macOS event model allows u= s to do
> this. As mentioned in the comments in the patch, some information just=
> appears to be lost entirely.

I recently found myself using this lovely binding:

=C2=A0 =C2=A0 (define-key global-map [C-s-268632064]
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 'ns-do-show-cha= racter-palette)

and it seems crazy to me that the default behaviour of Emacs requires
us to use 268632064 instead of SPC when we could tell people using
unusual keyboard layouts to set a variable or something instead.

As for losing data, as long as it=E2=80=99s no worse than what we have at t= he
moment, which I believe you said is the case in a previous email, then
I don=E2=80=99t see a problem with that.

But perhaps I=E2=80=99ve misunderstood and there=E2=80=99s some worse behav= iour?


I think it should be a significant imp= rovement in practice. I'd suggest to apply it and see whether we get an= y complaints.=C2=A0
--089e082fb8e0e928a5056467a75c--