From: Philipp Stephani <p.stephani2@gmail.com>
To: Dmitry Gutov <dgutov@yandex.ru>,
Helmut Eller <eller.helmut@gmail.com>,
24784-done@debbugs.gnu.org
Subject: bug#24784: 26.0.50; JSON strings with utf-16 escape codes
Date: Sun, 01 Jan 2017 12:26:07 +0000 [thread overview]
Message-ID: <CAArVCkT40s--PjbNwopQeCQCoM+KA8HtiyZkYuM33ncpVxyXuA@mail.gmail.com> (raw)
In-Reply-To: <b22abe18-a315-6a25-a534-ecdefed107ca@yandex.ru>
[-- Attachment #1: Type: text/plain, Size: 771 bytes --]
Dmitry Gutov <dgutov@yandex.ru> schrieb am So., 1. Jan. 2017 um 01:45 Uhr:
> On 31.12.2016 19:53, Philipp Stephani wrote:
>
> > Agreed; converted to defun. I've only used defsubst because some other
> > helper functions also used defsubst.
>
> Thanks. Those others can probably be changed as well.
>
Yes, but rather not in this commit.
>
> > No, the below case is more general and therefore has to come last.
>
> Makes sense.
>
> > It's not 100% related to the patch, but I think it can be included for
> > symmetry reasons (testing encoding as well as decoding).
>
> Of course. These are testing utf-8 encoding, though, right? It would be
> better if you split them to a separate commit, I think.
>
OK, I've removed it from this patch and pushed it as 93be35e038.
[-- Attachment #2: Type: text/html, Size: 1677 bytes --]
prev parent reply other threads:[~2017-01-01 12:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 18:06 bug#24784: 26.0.50; JSON strings with utf-16 escape codes Helmut Eller
2016-10-24 19:57 ` Philipp Stephani
2016-10-24 23:19 ` Dmitry Gutov
2016-10-26 16:39 ` Helmut Eller
2016-10-26 17:37 ` Drew Adams
2016-12-31 16:53 ` Philipp Stephani
2017-01-01 0:45 ` Dmitry Gutov
2017-01-01 12:26 ` Philipp Stephani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAArVCkT40s--PjbNwopQeCQCoM+KA8HtiyZkYuM33ncpVxyXuA@mail.gmail.com \
--to=p.stephani2@gmail.com \
--cc=24784-done@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=eller.helmut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).