From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#34655: 26.1.92; Segfault in module with --module-assertions Date: Thu, 21 Mar 2019 19:28:07 +0100 Message-ID: References: <874l8r1t3a.fsf@tcd.ie> <8336oamu3y.fsf@gnu.org> <87h8c1cv6l.fsf@tcd.ie> <83lg1dwhse.fsf@gnu.org> <87va0h12js.fsf@tcd.ie> <835zsgw3ui.fsf@gnu.org> <87ef7486h0.fsf@tcd.ie> <83r2b4ul1c.fsf@gnu.org> <831s30upqd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="38370"; mail-complaints-to="usenet@blaine.gmane.org" Cc: "Basil L. Contovounesios" , 34655@debbugs.gnu.org, Stefan Monnier To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 21 19:29:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h72RD-0009rC-Gi for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Mar 2019 19:29:11 +0100 Original-Received: from localhost ([127.0.0.1]:44609 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h72RC-00010t-IJ for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Mar 2019 14:29:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45195) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h72R5-00010L-WE for bug-gnu-emacs@gnu.org; Thu, 21 Mar 2019 14:29:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h72R5-0000SD-2s for bug-gnu-emacs@gnu.org; Thu, 21 Mar 2019 14:29:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40004) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h72R4-0000RW-OO for bug-gnu-emacs@gnu.org; Thu, 21 Mar 2019 14:29:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h72R4-0003Zd-D1 for bug-gnu-emacs@gnu.org; Thu, 21 Mar 2019 14:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Mar 2019 18:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34655 X-GNU-PR-Package: emacs Original-Received: via spool by 34655-submit@debbugs.gnu.org id=B34655.155319290613694 (code B ref 34655); Thu, 21 Mar 2019 18:29:02 +0000 Original-Received: (at 34655) by debbugs.gnu.org; 21 Mar 2019 18:28:26 +0000 Original-Received: from localhost ([127.0.0.1]:53548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h72QU-0003Yn-3Q for submit@debbugs.gnu.org; Thu, 21 Mar 2019 14:28:26 -0400 Original-Received: from mail-ot1-f45.google.com ([209.85.210.45]:45932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h72QS-0003YZ-KY for 34655@debbugs.gnu.org; Thu, 21 Mar 2019 14:28:25 -0400 Original-Received: by mail-ot1-f45.google.com with SMTP id e5so5314611otk.12 for <34655@debbugs.gnu.org>; Thu, 21 Mar 2019 11:28:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=qqEc+6xb93fa3eMSS1Ub0YcJxEBu+LoMzI5n+6rUbDM=; b=kUFtUIqQ+abqRIHNuSe7SOzjdQWNgWlx6wvNT8MCxDvnZNtIvNbmyLb3gx+CT+b3Um PGZDGmTw1uKc9F99JrSnITaL8tSPTnA5W1MpKx+nmBuAg8FKlGg3Zp5wlYduyPTT1c2u OJuaA41fGiIE6KNZJ6oCFXJLK2xfH2JZmBTEVaJIaURoakc1vU9CXiX0QY3AS3QY9ul0 gKaVrUNMVNOAzLCgY8vzr43u5jhMfaBpxYHj7cPvbCaxMLxseA0A53gUkN/kmCs4k9/b hAtYVjtbnuplzvqOfrH87JXrduUJ07tQfVjxvJrTwIvQbu2yYhqUN2dY4HYhYWrY0hKu B79A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=qqEc+6xb93fa3eMSS1Ub0YcJxEBu+LoMzI5n+6rUbDM=; b=IdetEn9J6Ol80fn366Dd21No+U/sLWzZJVzHfxrpImQK/hGj7pguhLDsNE+aTXUUfs 9CMBFRIoFa+iwQmUPyEmJEGp2xYKJ/6L14rzmAPzTdze6DmU+6ozowq1xq+oTmxWoJus 3t2/OqKLpSRbzntX3oeuOISYVi+Ak0LAlMS0/Fzqob1xFscrO5ZTqyuX/FGJumrP2YHf P60POKf//DR7auPfmu/p2v9/YH3yhhYbGZsZ3EtPCQZPwFoO3ozrpzp5EeA77h/7Euvq 0YuGHRT/Hiiq7ptPp0BpqwhoAxWvhDADh/TudowB7LyNw8WNvO4d2TvG8FVWFgjR3/yB Vsjg== X-Gm-Message-State: APjAAAWIocMw8TKAphZeezYXCsU5mVTzErt0yB3YGwznaM/qZXLA3TYw ht1RwCjiPGMgdgQ8shbyp6eY+r4w1UqX684xn2E= X-Google-Smtp-Source: APXvYqySdygcqUQ+TwPZ2+HiVC3V06hP4lC9+Z4QOqqPDxz6uAk+0/kuP5wZtkRtlMkFeJC200CW27EQtzcqHOQ1roI= X-Received: by 2002:a05:6830:15d2:: with SMTP id j18mr3337864otr.37.1553192898554; Thu, 21 Mar 2019 11:28:18 -0700 (PDT) In-Reply-To: <831s30upqd.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156575 Archived-At: Am Do., 21. M=C3=A4rz 2019 um 18:00 Uhr schrieb Eli Zaretskii : > > > From: Philipp Stephani > > Date: Thu, 21 Mar 2019 17:11:41 +0100 > > Cc: "Basil L. Contovounesios" , 34655@debbugs.gnu.org > > > > I haven't checked everything in detail, but my impression is that this > > is rather another instance of bug#31238. Fixing this only when module > > assertions are enabled will probably not fix anything, but rather mask > > issues. Reverting commit 3eb93c07f7a60ac9ce8a16f10c3afd5a3a31243a is > > still the right approach here. Can you please hold off a bit? I've > > almost completed the revert, but haven't pushed it yet. Once that's in > > we can check whether it also fixes this issue. > > I will CC Stefan, who committed 3eb93c07f7a60ac9ce8a16f10c3afd5a3a31243a. > > I'm not sure we should revert that; we could instead add GC protection > for those parts that need it. Yes, that's what reverting that commit does :-) We need to mark the objects in all cases, not just when module assertions are enabled. Note that both the designer of the module API (Daniel) and I as one of its main implementers disagree with commit 3eb93c07f7a60ac9ce8a16f10c3afd5a3a31243a. I'm happy to discuss alternatives, but for now we should revert it and discuss the alternatives *before* implementing them. I've already confirmed that reverting commit 3eb93c07f7a60ac9ce8a16f10c3afd5a3a31243a fixes bug#31238, and I can try it with this bug as well.