From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#47879: [PATCH] Ignore mode hooks when analysing diffs Date: Sun, 18 Apr 2021 22:18:29 +0200 Message-ID: References: <878s5fpg1a.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28935"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47879@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 18 22:19:34 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lYDtG-0007Nf-OV for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Apr 2021 22:19:34 +0200 Original-Received: from localhost ([::1]:55290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYDtF-0001se-J9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Apr 2021 16:19:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49980) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYDsl-0001rs-F9 for bug-gnu-emacs@gnu.org; Sun, 18 Apr 2021 16:19:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36402) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lYDsl-00004z-2P for bug-gnu-emacs@gnu.org; Sun, 18 Apr 2021 16:19:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lYDsk-0002ee-UR for bug-gnu-emacs@gnu.org; Sun, 18 Apr 2021 16:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Apr 2021 20:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47879 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47879-submit@debbugs.gnu.org id=B47879.161877712810175 (code B ref 47879); Sun, 18 Apr 2021 20:19:02 +0000 Original-Received: (at 47879) by debbugs.gnu.org; 18 Apr 2021 20:18:48 +0000 Original-Received: from localhost ([127.0.0.1]:47947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYDsW-0002e3-6d for submit@debbugs.gnu.org; Sun, 18 Apr 2021 16:18:48 -0400 Original-Received: from mail-oo1-f52.google.com ([209.85.161.52]:38410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYDsU-0002dp-Bo for 47879@debbugs.gnu.org; Sun, 18 Apr 2021 16:18:47 -0400 Original-Received: by mail-oo1-f52.google.com with SMTP id p12-20020a4a2f0c0000b02901ecdbb16887so392231oop.5 for <47879@debbugs.gnu.org>; Sun, 18 Apr 2021 13:18:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MUi/uq3ikgF2nW3H0ps/+EIuuWoy6bbMSv65C6ANlqE=; b=USFQW2MC/botnG1xLqB7chy1qeClZPjMotWQUrVtvAd7VuJ/PY3+Z9yK67pfbhnpZW /mA1khpHzICjTWhKzd9HABKnD833AHx073XqnCbd7XBPAFssQKfqNfG+ly5Fb/N5hDgm Nn4v6NAPlogkUrreRRZrvaRBji/Nr1qr42KuZPfqUEmDxE2bmcPGSITpO4ZhcC0hyAhx 6uIAIx6IqcPC0UWE47i+8ys4WVaGQTuQ6H7wrW26Z08KhWTgr3+XDgPvBJ7Qgq2viY0d 6nNWx6seA1vE/1Nai3ISETWmQ1UZz4mDJE8Q2JNK6xWdhk5uRzATbOq1liQU2AoYI401 MY8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MUi/uq3ikgF2nW3H0ps/+EIuuWoy6bbMSv65C6ANlqE=; b=rfpH+IEFEA04xDjsZVF9aLsm2TVBS6EpjHIJKj4w3ArDN7DDEbBM46a0NuHEcSMGpr hsOw4Wg8uifFjpVnVKBICpXiwavnVpkOi1vKr1GsRVaD/rwA8uNU4VzBkNQFKU052/Uz R4Rb/qx8LNbTn5CcTg382QcQytDin5HqvjlOeHCbReiv1zmmliDCpvGGDkhfU5KpgLBW cx/+tag6cQCk3t28hAswy62jK/tjkcfzo03jPcHGvvpMlln+9zUMDDXr2OloaUExPwCY SBAwYc4skQMXC6ppAkpiPwTNe9J6Oo8Y2REZ73JNfxn8MVWTqOfcBo6PUSZ/pWtXNHuC Z3QQ== X-Gm-Message-State: AOAM530Oqtk41jAMIR+jYhmdM49z50JmwlRBe8Wea2j07XBmT3l4l8B7 PeFP1YfZd24rYc5Q0R3mbH4wAPJrFZMRNeP8JnA= X-Google-Smtp-Source: ABdhPJyr4CovN4JPh7KBo/2UQ+MYHy1bwm2HLTUJ8IQGiOO97Uwh+NDFtVQWLfUirupa2LSU/SBBwlmbhXTnzfaXWyc= X-Received: by 2002:a4a:8c4f:: with SMTP id v15mr11117678ooj.25.1618777120605; Sun, 18 Apr 2021 13:18:40 -0700 (PDT) In-Reply-To: <878s5fpg1a.fsf@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204409 Archived-At: Am So., 18. Apr. 2021 um 21:09 Uhr schrieb Philip Kaludercic : > > > This fixes a bug related to log-edit-generate-changelog-from-diff. > > When I tried to invoke this command in a commit buffer, the error > > signal: Unmatched bracket or quote > > was raised. The reason was that I added paredit-mode to > emacs-lisp-mode-hook, that when invoked calls check-parens. This raises > an error when the diff contains a partial s-expression, which is almost > always the case. I have the following in my emacs-lisp-mode-hook: (with-demoted-errors "Error enabling Paredit: %s" (paredit-mode)) Enabling Paredit unconditionally is too invasive; it will also break file visiting if the file has a syntax error. Alternatively, bind paredit-override-check-parens-function to e.g. (lambda (_) t).