From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#31138: Native json slower than json.el Date: Sun, 21 Apr 2019 15:33:33 +0200 Message-ID: References: <87sh806xwa.fsf@chapu.is> <83r2awnw0w.fsf@gnu.org> <83d0mgnn31.fsf@gnu.org> <835zs7och6.fsf@gnu.org> <83tvfqnbxc.fsf@gnu.org> <83lg12n75s.fsf@gnu.org> <83h8bqn2ik.fsf@gnu.org> <83zhphliil.fsf@gnu.org> <181b93a3-3861-0481-1b95-8344410d1049@yandex.ru> <83r2a2hdxn.fsf@gnu.org> <21f68973-a684-2a65-82eb-c8f3df90127f@yandex.ru> <83d0lmgez2.fsf@gnu.org> <7d503be9-4d85-3d0b-6829-631ad376ba3d@yandex.ru> <831s22gcci.fsf@gnu.org> <83y349gasn.fsf@gnu.org> <83d0lfag4x.fsf@gnu.org> <5cf45a21-65c3-67ee-f123-be83a6ee7c99@yandex.ru> <83a7gjaen6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="225238"; mail-complaints-to="usenet@blaine.gmane.org" Cc: =?UTF-8?Q?S=C3=A9bastien?= Chapuis , Dmitry Gutov , 31138@debbugs.gnu.org To: yyoncho Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 21 15:34:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hICbj-000wTO-39 for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Apr 2019 15:34:11 +0200 Original-Received: from localhost ([127.0.0.1]:53295 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hICbh-0005mR-Tk for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Apr 2019 09:34:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58495) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hICbb-0005mM-Qz for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2019 09:34:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hICba-0003zo-TN for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2019 09:34:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34406) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hICba-0003za-Pt for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2019 09:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hICba-00026p-Ca for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2019 09:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Apr 2019 13:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31138 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 31138-submit@debbugs.gnu.org id=B31138.15558536348094 (code B ref 31138); Sun, 21 Apr 2019 13:34:02 +0000 Original-Received: (at 31138) by debbugs.gnu.org; 21 Apr 2019 13:33:54 +0000 Original-Received: from localhost ([127.0.0.1]:47950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hICbS-00026T-Ec for submit@debbugs.gnu.org; Sun, 21 Apr 2019 09:33:54 -0400 Original-Received: from mail-oi1-f170.google.com ([209.85.167.170]:46965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hICbP-00026G-N7 for 31138@debbugs.gnu.org; Sun, 21 Apr 2019 09:33:52 -0400 Original-Received: by mail-oi1-f170.google.com with SMTP id x188so6836592oia.13 for <31138@debbugs.gnu.org>; Sun, 21 Apr 2019 06:33:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CjzFvFLBTaPI1PuwYzTxhLLzCgYPiHyNe3qvveI+C8o=; b=p1aNyXiO+mNX+A4sbrVqNUqgDLrdqj+E6Wi28/LyjEuzIsxYzApu/L1tPTuiCELUHS SwA8VdBaKKV1Pb2KlAtMeOVqWm49oCY/m2e3N9DMSORHgOApo9e8kFRK/7pjKSeFaQpy 3X3vjBs9cSxxKuKESy7EvCpGefDEkBIaOpppitI+ctIBq0Z3F4VUuJRMer1Ll5qdHG05 UHtqOI9FR3lFRPSVjPJ3Nm1lSFhhUa47w0rg5ZM4KB1fcoOqLXgLY0MUsxBiXfkEsCLg fqKLZ+j6xM5A0po4W/iWIKAXrXVjoOTF+cGirW+eoTOwjnaQy9oNwL0QPOZ75OubT3k+ xzbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CjzFvFLBTaPI1PuwYzTxhLLzCgYPiHyNe3qvveI+C8o=; b=qVpSzXJWSjluq4+ix/I4/zbE+KyPn/59D7WfcAk6yCjxyZO585hcZORPjgZcyEHCL3 ljaavnqSuk+VklTHT2smUnfek7y0Bw2v5e23SH45rDlfYjv/p86sKq3EFhri5b/uYYUA ui8Pe0oqD6UwgXok3LUfPrMyRjnEeMUzjHczgTZAiWdHZErLU9RQHqX9NgZqTo5NKsP/ 7V0UckfqqyvclBFi24jVUtGPPmynNt1dY/x75l6z3Kmx9idy3pjCDRxDHgMapbALjdrb cnIgAZAD7AHQGN+TneLrbcFFRNUcOKrpdJDxKXrhIpKniVGCjuIvFadKKjbhsy/7AxQA LcoA== X-Gm-Message-State: APjAAAUjo6YQjlBiBaUtpfmPs+JviqVsBJPFj2UlzqnpRy//cdag1nBO laB+9MBI18ERo1xjmdMCP2BZwYsmtUjem1E6YeY= X-Google-Smtp-Source: APXvYqzVaoe5IjFgIBRP3YetJ66p3/WsJJvpSqCgjumRk3LLk8yB8sVvFEbRq2tVcWaZdo/SII2ZwqQA92cgabtwlH8= X-Received: by 2002:aca:310a:: with SMTP id x10mr7685435oix.161.1555853625581; Sun, 21 Apr 2019 06:33:45 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157945 Archived-At: Am So., 21. Apr. 2019 um 15:10 Uhr schrieb yyoncho : > > Hi Philipp, > > As Eli commented in this thread, the decoding is must have for all external libraries no matter what is their contract. I disagree. > > Thanks, > Ivan > > On Sun, Apr 21, 2019 at 3:59 PM Philipp Stephani wrote: >> >> Am So., 21. Apr. 2019 um 12:24 Uhr schrieb yyoncho : >> > >> > Hi Eli, >> > >> >> >> >> In any case, even if decoding takes 50% of the time we spend in Emacs >> >> code, it is still not significant enough to justify the un-safety of >> >> using a string that we didn't decode, because if that string ever >> >> includes raw bytes, Emacs will surely crash. >> > >> > >> > IMO if validation of the data that comes from external libraries is taking a lot of time then it does not make sense to use external libraries at all when we are aiming for performance gains. >> >> >> There's no need to validate Jansson's output because it already >> validates that the input is valid UTF-8, and never generates invalid >> strings.