From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106) Date: Thu, 18 Jan 2018 14:23:03 +0000 Message-ID: References: <20180117222846.93077-1-phst@google.com> <20180117222846.93077-2-phst@google.com> <83y3kvuuui.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="94eb2c1942de4ec53905630db48c" X-Trace: blaine.gmane.org 1516285343 5506 195.159.176.226 (18 Jan 2018 14:22:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 18 Jan 2018 14:22:23 +0000 (UTC) Cc: phst@google.com, 30106@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 18 15:22:19 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecB54-0000yp-N9 for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Jan 2018 15:22:14 +0100 Original-Received: from localhost ([::1]:33838 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecB74-0002MC-Pz for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Jan 2018 09:24:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43877) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecB6s-0002Jj-Kf for bug-gnu-emacs@gnu.org; Thu, 18 Jan 2018 09:24:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecB6o-0000Zi-Gj for bug-gnu-emacs@gnu.org; Thu, 18 Jan 2018 09:24:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53220) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ecB6o-0000ZQ-DL for bug-gnu-emacs@gnu.org; Thu, 18 Jan 2018 09:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ecB6o-0004a7-7c for bug-gnu-emacs@gnu.org; Thu, 18 Jan 2018 09:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Jan 2018 14:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30106 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30106-submit@debbugs.gnu.org id=B30106.151628540217563 (code B ref 30106); Thu, 18 Jan 2018 14:24:02 +0000 Original-Received: (at 30106) by debbugs.gnu.org; 18 Jan 2018 14:23:22 +0000 Original-Received: from localhost ([127.0.0.1]:32883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecB6A-0004ZD-8l for submit@debbugs.gnu.org; Thu, 18 Jan 2018 09:23:22 -0500 Original-Received: from mail-lf0-f44.google.com ([209.85.215.44]:34696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecB68-0004Z0-Dz for 30106@debbugs.gnu.org; Thu, 18 Jan 2018 09:23:20 -0500 Original-Received: by mail-lf0-f44.google.com with SMTP id k19so6640070lfj.1 for <30106@debbugs.gnu.org>; Thu, 18 Jan 2018 06:23:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=F2ylcu2/HlNy0DA4IDMADGiFiSIXfYtKKtadGNCg86E=; b=qxeE1GmHa9thIbkZ9K/BI2Ezo69m1zSkMTU4IAYd+EzQq+dpMgUqONRo8Cd3n60k2q kwUEYe+8xJ6xXvlSXnPjXLVEplZ/Wn5iadUvWenccNK3GstsrB6CL3hABNp61BO7+BGY Z4ENCDpkrFs8HEy089pXzT9nbRHkb0bcdU076iWoW9Gg6G+b4OCfgy0lxYC7jLdf+jnD gI1bXsFHZ30d6Yltn/F7fmirxZno+GNtFeTyENf0Mex3aTKqgbWSMo5ioJ6LLmN0+mXK vq6QiyMKUHVRzg2vFjC8QQAA+dlUcpWDl4X9RxOi65IM+5aftFBZHF0ExXyMeRw5AIhz ROVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F2ylcu2/HlNy0DA4IDMADGiFiSIXfYtKKtadGNCg86E=; b=Bs3jxoRKJHghHNFFq9czAravyFIuYw6M8Jy7WFMn/Pcly5elUex2bA5qcM+yAx6n1P CpURSVSO0Oz802CgvbRqSob6/iT/p0H9cX+iIxa93G68hq915lRkEx8ARqQU0cGt108e DG4PL+/f2LgSTovj3x8kAn2YjiJERpGprc4qqjlntARs/MxBUq2juKOTZ/fJO0y4/ebv SI6ebD2g/XjE13nEHra8hZo1oZMahigO9/bc47TJT1A8aPunLG2KBGw1AukZfq4sF08k egsLh006ePA4fx04d2mc411MpfiF0QjZb1xN0yb7Ir/GPp7gRohCouGaafVdtylPEmOa LgnA== X-Gm-Message-State: AKwxyte+07pkro0cy+XjOYEN8QlhDmOD218nrHQDdQi1GMLVgFEu5ZNU TQNc6zpGnaC/pi1LvOiO9kJ+mplT095E2XgIo+M= X-Google-Smtp-Source: ACJfBou1ayhsyUsCLKzc9XHuIsadw4zL3XKVMaq/aXUuc8ksHnC+4/9GduW270qyyhwODpKuo7ERfce4PsBMS8HH+F8= X-Received: by 10.46.68.11 with SMTP id r11mr12243034lja.13.1516285394337; Thu, 18 Jan 2018 06:23:14 -0800 (PST) In-Reply-To: <83y3kvuuui.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142251 Archived-At: --94eb2c1942de4ec53905630db48c Content-Type: text/plain; charset="UTF-8" Eli Zaretskii schrieb am Do., 18. Jan. 2018 um 15:05 Uhr: > > From: Philipp Stephani > > Cc: Philipp Stephani > > Date: Wed, 17 Jan 2018 23:28:46 +0100 > > > > * src/systhread.c (sys_thread_equal): New function. > > * src/emacs-module.c (in_current_thread): Use it. > > I'd prefer that the only file that calls systhread.c functions is > thread.c; systhread.c is supposed to be low-level code concealed from > application levels. So this would call for another level of > indirection: add a new function to thread.c, and call that from > emacs-module.c. > Makes sense, I've moved in_current_thread to thread.c because it's unrelated to modules. > > Otherwise, LGTM for master; thanks. > > Can we push this to emacs-26? Right now emacs-26 can't even be compiled with --without-threads --with-modules (on some systems at least). --94eb2c1942de4ec53905630db48c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= Do., 18. Jan. 2018 um 15:05=C2=A0Uhr:
> From: Philipp Stephani <p.stephani2@gmail.com>
> Cc: Philipp Stephani <phst@google.com>
> Date: Wed, 17 Jan 2018 23:28:46 +0100
>
> * src/systhread.c (sys_thread_equal): New function.
> * src/emacs-module.c (in_current_thread): Use it.

I'd prefer that the only file that calls systhread.c functions is
thread.c; systhread.c is supposed to be low-level code concealed from
application levels.=C2=A0 So this would call for another level of
indirection: add a new function to thread.c, and call that from
emacs-module.c.

Makes sense, I've m= oved in_current_thread to thread.c because it's unrelated to modules.
=C2=A0

Otherwise, LGTM for master; thanks.


Can we push this to emacs-26? Right now em= acs-26 can't even be compiled with --without-threads --with-modules (on= some systems at least).=C2=A0
--94eb2c1942de4ec53905630db48c--