bug#24679: 26.0.50; Flymake should clear the query-on-exit flag

[Philipp Stephani <p.stephani2@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 559 bytes --]

Leo Liu <sdl.web@gmail.com> schrieb am Do., 13. Okt. 2016 um 06:12 Uhr:

> On 2016-10-12 22:08 +0200, Philipp Stephani wrote:
>
> > This was already proposed in
>
> > https://lists.gnu.org/archive/html/emacs-devel/2010-03/msg01217.html,
>
> > but there was no follow-up. Flymake processes are expected to be
>
> > unimportant and stateless, so I think it would be better to clear
>
> > their query-on-exit flag.
>
>
>
>  👍
>
>
>
> That looks like a good change.
>
>
>
Thanks. I've attached a patch that also contains a NEWS entry.

[-- Attachment #1.2: Type: text/html, Size: 1173 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Don-t-prompt-user-when-killing-Flymake-processes.txt --]
[-- Type: text/plain; charset=US-ASCII;  name="0001-Don-t-prompt-user-when-killing-Flymake-processes.txt", Size: 2220 bytes --]

From 000baf0d1ea4625af61c6623b53457b38f2afaf4 Mon Sep 17 00:00:00 2001
From: Karl Chen <Karl.Chen@quarl.org>
Date: Sat, 15 Oct 2016 22:16:26 +0200
Subject: [PATCH] Don't prompt user when killing Flymake processes
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* lisp/progmodes/flymake.el (flymake-start-syntax-check-process):
Don’t prompt the user when killing Flymake processes.

* doc/misc/flymake.texi (Starting the syntax check process):
Document new behavior.
---
 doc/misc/flymake.texi     | 3 ++-
 etc/NEWS                  | 6 ++++++
 lisp/progmodes/flymake.el | 1 +
 3 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/doc/misc/flymake.texi b/doc/misc/flymake.texi
index 1c4644b..998f1b3 100644
--- a/doc/misc/flymake.texi
+++ b/doc/misc/flymake.texi
@@ -697,7 +697,8 @@ Starting the syntax check process
 initialization function.  Flymake then just calls @code{start-process}
 to start an asynchronous process and configures a process filter and
 sentinel, which are used for processing the output of the syntax check
-tool.
+tool.  When exiting Emacs, running Flymake processes will be killed
+without prompting the user.
 
 @node Parsing the output
 @section Parsing the output
diff --git a/etc/NEWS b/etc/NEWS
index 14450a6..fcfe550 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -466,6 +466,12 @@ This is done with the help of 'c-or-c++-mode' function which analyses
 contents of the buffer to determine whether it's a C or C++ source
 file.
 
+** Flymake
+
++++
+*** Emacs does no longer prompt the user before killing Flymake
+processes on exit.
+
 \f
 * New Modes and Packages in Emacs 26.1
 
diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index 30c9fed..1b78823 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -1072,6 +1072,7 @@ flymake-start-syntax-check-process
                        "flymake-proc" (current-buffer) cmd args))))
         (set-process-sentinel process 'flymake-process-sentinel)
         (set-process-filter process 'flymake-process-filter)
+        (set-process-query-on-exit-flag process nil)
         (push process flymake-processes)
 
         (setq flymake-is-running t)
-- 
2.10.1