From: Philipp Stephani <p.stephani2@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 54410-done@debbugs.gnu.org
Subject: bug#54410: One cl-defgeneric in xref.el should be cl-defmethod
Date: Thu, 17 Mar 2022 13:07:52 +0100 [thread overview]
Message-ID: <CAArVCkSgmZMCaZP3jZp4pdGveJni6Qn5_E0OajkFSqZPDS=u8Q@mail.gmail.com> (raw)
In-Reply-To: <838rtainhy.fsf@gnu.org>
Am Mi., 16. März 2022 um 04:29 Uhr schrieb Eli Zaretskii <eliz@gnu.org>:
>
> > From: Philipp Stephani <p.stephani2@gmail.com>
> > Date: Wed, 16 Mar 2022 00:09:23 +0100
> >
> > Is the following patch good for the release branch?
>
> What problems are caused by the current code?
I'm using Edebug for coverage instrumentation, and that only works
right in an automated way if there are no duplicate instrumented
symbols, because Edebug attaches coverage information to individual
symbols. cl-defmethod takes care of this by generating additional
symbols, but cl-defgeneric doesn't.
>
> In general, I'd prefer to leave the release branch alone at this time,
> so we could release Emacs 28.1 soon. It seems quite ready.
Fine with me, I've pushed it to master as commit
6ed3f04e5a3c8aee40a26805bb00cdd070eba319.
prev parent reply other threads:[~2022-03-17 12:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 23:09 bug#54410: One cl-defgeneric in xref.el should be cl-defmethod Philipp Stephani
2022-03-16 3:29 ` Eli Zaretskii
2022-03-16 12:14 ` Dmitry Gutov
2022-03-16 12:31 ` Eli Zaretskii
2022-03-17 11:01 ` Lars Ingebrigtsen
2022-03-17 11:23 ` Dmitry Gutov
2022-03-17 12:07 ` Philipp Stephani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAArVCkSgmZMCaZP3jZp4pdGveJni6Qn5_E0OajkFSqZPDS=u8Q@mail.gmail.com' \
--to=p.stephani2@gmail.com \
--cc=54410-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).