From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#51941: Detect duplication of ERT tests Date: Thu, 18 Nov 2021 18:53:10 +0100 Message-ID: References: <21CD2DED-354E-4C46-9794-07172E3BD5F1@acm.org> <87fsrtkayn.fsf@gnus.org> <87mtm1z7dc.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2902"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 51941@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 18 18:54:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mnlbt-0000Si-O5 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Nov 2021 18:54:09 +0100 Original-Received: from localhost ([::1]:36854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mnlbs-0008Ex-N7 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Nov 2021 12:54:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnlbm-0008Ek-Jd for bug-gnu-emacs@gnu.org; Thu, 18 Nov 2021 12:54:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53816) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mnlbm-00033O-Bf for bug-gnu-emacs@gnu.org; Thu, 18 Nov 2021 12:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mnlbm-0000zA-8v for bug-gnu-emacs@gnu.org; Thu, 18 Nov 2021 12:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Nov 2021 17:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51941 X-GNU-PR-Package: emacs Original-Received: via spool by 51941-submit@debbugs.gnu.org id=B51941.16372580093739 (code B ref 51941); Thu, 18 Nov 2021 17:54:02 +0000 Original-Received: (at 51941) by debbugs.gnu.org; 18 Nov 2021 17:53:29 +0000 Original-Received: from localhost ([127.0.0.1]:37129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnlbF-0000yF-Ij for submit@debbugs.gnu.org; Thu, 18 Nov 2021 12:53:29 -0500 Original-Received: from mail-oi1-f180.google.com ([209.85.167.180]:43803) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnlbD-0000xy-8b for 51941@debbugs.gnu.org; Thu, 18 Nov 2021 12:53:27 -0500 Original-Received: by mail-oi1-f180.google.com with SMTP id o4so15907138oia.10 for <51941@debbugs.gnu.org>; Thu, 18 Nov 2021 09:53:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uS/EkLLtsXAPLN0k7XKxpHAUQslc1kg9HeEA20TWg30=; b=fn7qWfWGoUOR+0pzAl/nCKLSthH7Q5vJ9c3V9LHYCU5i/fvYzC6g1MYP3x1TZ30C0m 3XgM348HWhAET1vp1dNM6vLNtEJx9nnE2KMvtxxs4lvC/6DjeJDVAvldo5aVBHg+cRNy qlj1lJ2iwfTGa1ZsOnTT0m5rpKDi3PYhYlDoAdgeWedUlMMOwkbDuyDOFcLGE7l+jHL7 yX5VZQO8v0YVCAkb+WbO7xM8GYnBiAO9UMCWa8Zd73xYLbfWABnIaV5I4HJhVUi8f/6n VI0N5KujDv4tMxLeONHRSO/6u3taZF8n4wQeBHXE5Y7KiOsWbTdeii8k6IRg0plDyBt3 /R6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uS/EkLLtsXAPLN0k7XKxpHAUQslc1kg9HeEA20TWg30=; b=2wQVtzwNtX0gdB9FQRfsgtuBWb7UlLF2xU5MxKepfVmg8w8vXxq0qkKG/BeuSmz459 MdGOTv84qrENEu+0DzTzmqfKW/yXOMbjxUL5n6GRe5/U4TSAme1HdcpE2HCq15yYDkh8 M5ef5b2heYBJKQV1K/K0etKBoIaJ4fdnaFzWA0h7cHRhO/vYClGBk7A1wZbalvAtWIRy Q8HPz6OhY7NgDJZaxWuAylC9DNxO7kjvr4CYpeIIkbrz30BaBZhH7i3nB8w39MLYQ6Cc TXVnUldM2pKav1KpgaG3sNOtZ0J3IXmDigODOmh7XxBCplpvZUI7KAaKzz3HR+uVOvFn PX2g== X-Gm-Message-State: AOAM5331NKct+0W1ckOIQ8BfCYr0ycpfiHOCEOTLCvHzvAWPf7QmoMm1 CLSE2HTONue2YM2et6Bo8QIoOJg9qHx1rn5lI3g= X-Google-Smtp-Source: ABdhPJznUOMkY1VFlZAg4x04nWcw7IJ9FKs91nvsOTQsxO4sGAMXF4LOdzCZv4avfCStpJ3vYDQfSachwC7m3Rj0nJk= X-Received: by 2002:a05:6808:11c6:: with SMTP id p6mr9500988oiv.158.1637258001345; Thu, 18 Nov 2021 09:53:21 -0800 (PST) In-Reply-To: <87mtm1z7dc.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220339 Archived-At: Am Do., 18. Nov. 2021 um 18:45 Uhr schrieb Lars Ingebrigtsen : > > By the way, this reminds me of a different error I often make in ert > files -- I type "defun" instead of "ert-deftest". Would it be > productive to check whether a -tests.el file contains a defun that's > never called? In which case it's probably supposed to be en > ert-deftest. > > But perhaps it's such a marginal problem that it's not worth checking > for. This also happens to me rather frequently, so I'd welcome such an addition. The byte compiler can already generate call graphs (see byte-compile-generate-call-tree), so maybe that functionality could be reused.