From: Philipp Stephani <p.stephani2@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: "Mattias Engdegård" <mattiase@acm.org>, 51941@debbugs.gnu.org
Subject: bug#51941: Detect duplication of ERT tests
Date: Thu, 18 Nov 2021 18:53:10 +0100 [thread overview]
Message-ID: <CAArVCkSfp4EEgT7dQNpE8XPxP+JopEmGWhp5F7KCqdLwSNdcBQ@mail.gmail.com> (raw)
In-Reply-To: <87mtm1z7dc.fsf@gnus.org>
Am Do., 18. Nov. 2021 um 18:45 Uhr schrieb Lars Ingebrigtsen <larsi@gnus.org>:
>
> By the way, this reminds me of a different error I often make in ert
> files -- I type "defun" instead of "ert-deftest". Would it be
> productive to check whether a -tests.el file contains a defun that's
> never called? In which case it's probably supposed to be en
> ert-deftest.
>
> But perhaps it's such a marginal problem that it's not worth checking
> for.
This also happens to me rather frequently, so I'd welcome such an
addition. The byte compiler can already generate call graphs (see
byte-compile-generate-call-tree), so maybe that functionality could be
reused.
next prev parent reply other threads:[~2021-11-18 17:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 10:16 bug#51941: Detect duplication of ERT tests Mattias Engdegård
2021-11-18 10:35 ` Lars Ingebrigtsen
2021-11-18 11:54 ` Mattias Engdegård
2021-11-18 11:58 ` Lars Ingebrigtsen
2021-11-18 17:44 ` Lars Ingebrigtsen
2021-11-18 17:53 ` Philipp Stephani [this message]
2021-11-18 19:13 ` Mattias Engdegård
2021-11-18 19:34 ` Lars Ingebrigtsen
2021-11-18 19:43 ` Mattias Engdegård
2021-11-18 22:51 ` Glenn Morris
2021-11-19 5:28 ` Lars Ingebrigtsen
2021-11-19 9:33 ` Mattias Engdegård
2021-11-20 8:38 ` Lars Ingebrigtsen
2021-11-20 8:49 ` Mattias Engdegård
2021-11-24 7:30 ` Ihor Radchenko
2021-11-24 8:52 ` Mattias Engdegård
2021-11-24 9:29 ` Ihor Radchenko
2021-11-24 10:00 ` Mattias Engdegård
2021-11-24 12:16 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAArVCkSfp4EEgT7dQNpE8XPxP+JopEmGWhp5F7KCqdLwSNdcBQ@mail.gmail.com \
--to=p.stephani2@gmail.com \
--cc=51941@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).