From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#36225: 26.2.90; Can't build master Date: Sat, 15 Jun 2019 18:57:34 +0200 Message-ID: References: <83tvcqvmw7.fsf@gnu.org> <83sgsavll2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="215419"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36225@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 15 18:58:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hcC0I-000ttJ-Ug for geb-bug-gnu-emacs@m.gmane.org; Sat, 15 Jun 2019 18:58:11 +0200 Original-Received: from localhost ([::1]:33586 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcC0H-0008JS-BB for geb-bug-gnu-emacs@m.gmane.org; Sat, 15 Jun 2019 12:58:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50858) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcC0B-0008JA-Gf for bug-gnu-emacs@gnu.org; Sat, 15 Jun 2019 12:58:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hcC0A-0002xc-Iw for bug-gnu-emacs@gnu.org; Sat, 15 Jun 2019 12:58:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53830) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hcC0A-0002xV-Ff for bug-gnu-emacs@gnu.org; Sat, 15 Jun 2019 12:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hcC0A-0005Hr-Co for bug-gnu-emacs@gnu.org; Sat, 15 Jun 2019 12:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jun 2019 16:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36225 X-GNU-PR-Package: emacs Original-Received: via spool by 36225-submit@debbugs.gnu.org id=B36225.156061787420306 (code B ref 36225); Sat, 15 Jun 2019 16:58:02 +0000 Original-Received: (at 36225) by debbugs.gnu.org; 15 Jun 2019 16:57:54 +0000 Original-Received: from localhost ([127.0.0.1]:39141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcC01-0005HS-UI for submit@debbugs.gnu.org; Sat, 15 Jun 2019 12:57:54 -0400 Original-Received: from mail-oi1-f177.google.com ([209.85.167.177]:44286) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcBzz-0005HE-W0 for 36225@debbugs.gnu.org; Sat, 15 Jun 2019 12:57:52 -0400 Original-Received: by mail-oi1-f177.google.com with SMTP id e189so4194114oib.11 for <36225@debbugs.gnu.org>; Sat, 15 Jun 2019 09:57:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EQRSrrBqidwu6YDsR7X5cWPVTfYUVCa0TdM07/kFIKg=; b=ulmI35niTWbWrpbH1Mw5i9MQsaZrYqpwsQXE7YuoojVlUqRdtNm4n/LJwqZa/rDTDA y9HzlNSW4bPDtxCqoP/Eff1uTTMA8MVUbfLpQ0h67eS7LPF6xYn3C6wvIN757clqelY+ +GlUPC5KnYkcuZfMkZOUirlv7R1610sqZ+PGyeumvWm40nCTzhDOsrsnlQ3jVETCqVBz uzvZ61vmBetn1ba8Cw3MEm0lg0e1SrJoaqQzsI0/B0E1NkvRBZycuKFWRoUL5jQS4NNB XPMIjVxQB+cu11AH3gyY0y4zbN3V7wI+Fuugl8CVbTXYqmP+R5amJBP+OFdgsdIyvVjw fm1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EQRSrrBqidwu6YDsR7X5cWPVTfYUVCa0TdM07/kFIKg=; b=VclWFV2+axSp4riAe+pivQ/GhZfiV81Pk8m0dlXOcC1Kmmz4zHfiOLQwQTAA10Hc3+ OPsbcVBgO0ScSxA8PhR+FEZf28GEYnDiB+U8rfM1/RagrAD9bka5EZmThJ9m2TsZ/rHA ueYUfWBzwISzF8WpVCTf7BAnAetyBtUTzzBB4eFft38yVUiYTv9wpNR3EEVKeuoZrBBs UEritReUUQrKU/l1WiWNKpF+oxoYSVmnjseEFG74Kkc+t0//URC3Ggn9LsjpLXe7qXpL b4jwvwn+NVI+BdSkFmUB9R5GA9Z0bH072x2VDUiJLq4lBbNmWfsDhlPf47UzrYSiIash /f3A== X-Gm-Message-State: APjAAAVRYMcce1ze9A04zI4YfWBn21H08Q59o46vpjDh6zzED+FQ/8/l VRv11EduHplf2bjb9p2Ub/LB+2zJmXPALvnjdmXjVLRx X-Google-Smtp-Source: APXvYqxjq2biPgT+E4K+0OFByRRnFHALWBmk6iS7kcKgKoU343trYCqDLzjBXfhBK2z8CQzVTOtmDWztFboK+jMw/J0= X-Received: by 2002:aca:d905:: with SMTP id q5mr5780905oig.9.1560617865860; Sat, 15 Jun 2019 09:57:45 -0700 (PDT) In-Reply-To: <83sgsavll2.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160624 Archived-At: Am Sa., 15. Juni 2019 um 18:51 Uhr schrieb Eli Zaretskii : > > > From: Philipp Stephani > > Date: Sat, 15 Jun 2019 18:34:32 +0200 > > Cc: 36225@debbugs.gnu.org > > > > > The comment to CHECK_STRUCTS in src/config.h tells you what to do in > > > this case. > > > > Yes, it says "If you change one of these structures, check that the > > pdumper.c code is still valid", but since I didn't change the > > structure, I can't decide whether the pdumper code is still valid. > > Whoever changed the definition of Lisp_Buffer_Objfwd should make that > > call. > > It says to update the pertinent hash in pdumper.c by manually copying > the hash from dmpstruct.h. The hash to be updated is called out by > the error message. So I think the information you need is there to > fix your build. That is not what I mean. Of course that fixes the build, that's not the problem. But it would be incorrect and unsafe to blindly copy the hash without investigating whether there were any changes to Lisp_Buffer_Objfwd that would need to be reflected in pdumper.c. That's the whole point of the hash check: force people to adapt pdumper.c upon any struct change. That is what "If you change one of these structures, check that the pdumper.c code is still valid" means: whoever changed Lisp_Buffer_Objfwd (i.e., *not* me) needs to update pdumper.c.