From: Philipp Stephani <p.stephani2@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 21730@debbugs.gnu.org, mwd@md5i.com
Subject: bug#21730: 25.0.50; Random errors in redisplay--pre-redisplay-functions
Date: Wed, 14 Sep 2016 19:48:23 +0000 [thread overview]
Message-ID: <CAArVCkS6gyKhewafoPKH3RUhwVmQ8xVHo=36nHOh-L4=aFBBxw@mail.gmail.com> (raw)
In-Reply-To: <83oa3q70aw.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1497 bytes --]
Eli Zaretskii <eliz@gnu.org> schrieb am Mi., 14. Sep. 2016 um 21:24 Uhr:
> > From: Philipp Stephani <p.stephani2@gmail.com>
> > Date: Wed, 14 Sep 2016 18:43:13 +0000
> > Cc: 21730@debbugs.gnu.org, mwd@md5i.com
> >
> > Since the problem that caused the patch to be reverted was with
> > narrowing, why not simply use
> >
> > (= point (with-current-buffer (window-buffer window) (point-min)))
> >
> > instead of
> >
> > (= point 1)
> >
> > ?
> >
> > This has the same issues as described above. There's more code in
> cursor-sensor--detect that assumes (eq
> > (current-buffer) (window-buffer window)), e.g. the form
> (get-char-property point 'cursor-sensor-functions).
> > Therefore (= point (with-current-buffer (window-buffer window)
> (point-min))) must be the same as (bobp).
> > Another mystery is the stack trace entry
> "run-hook-with-args(cursor-sensor--detect #<window 224 on
> > *Group*>)". How can cursor-sensor--detect be the first argument to
> run-hook-with-args? Shouldn't it always
> > be pre-redisplay-functions?
>
> If we want to dig deeper, I think we should first understand why bop
> doesn't work. Is it indeed because the window's buffer is not the
> current buffer when the hook is called?
>
Unfortunately the error doesn't trigger consistently. Maybe we are lucky
and somebody manages to detect such an issue.
I'd also suggest to add
(cl-assert (eq (current-buffer) (window-buffer window)))
to cursor-sensor--detect, because the function relies on this equality.
[-- Attachment #2: Type: text/html, Size: 2664 bytes --]
next prev parent reply other threads:[~2016-09-14 19:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 4:04 bug#21730: 25.0.50; Random errors in redisplay--pre-redisplay-functions Michael Welsh Duggan
2015-10-22 14:40 ` Eli Zaretskii
2015-10-27 4:19 ` Michael Welsh Duggan
2015-10-31 13:07 ` Michael Welsh Duggan
2015-10-31 13:32 ` Eli Zaretskii
2016-09-14 17:01 ` Philipp Stephani
[not found] ` <CAArVCkTA5_hxvxszdYX1QWSoG382zg+mW=4U3uhiXmTBcPCSgw@mail.gmail.com>
2016-09-14 17:09 ` Eli Zaretskii
2016-09-14 18:43 ` Philipp Stephani
2016-09-14 19:23 ` Eli Zaretskii
2016-09-14 19:48 ` Philipp Stephani [this message]
2016-09-15 14:22 ` Eli Zaretskii
2016-09-14 19:11 ` Philipp Stephani
2016-09-14 19:25 ` Eli Zaretskii
2017-07-25 2:06 ` Sergio Durigan Junior
2017-07-25 14:21 ` Eli Zaretskii
2017-07-25 23:15 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAArVCkS6gyKhewafoPKH3RUhwVmQ8xVHo=36nHOh-L4=aFBBxw@mail.gmail.com' \
--to=p.stephani2@gmail.com \
--cc=21730@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=mwd@md5i.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).