From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#42482: 27.0.91; emacs modules memory leak Date: Sat, 25 Jul 2020 23:43:13 +0200 Message-ID: References: <83365if7lz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22965"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 42482@debbugs.gnu.org, Milan =?UTF-8?Q?Stanojevi=C4=87?= To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 25 23:44:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jzRxh-0005rw-Uc for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Jul 2020 23:44:09 +0200 Original-Received: from localhost ([::1]:54068 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jzRxh-00084S-1d for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Jul 2020 17:44:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34894) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jzRxa-00084M-Db for bug-gnu-emacs@gnu.org; Sat, 25 Jul 2020 17:44:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39739) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jzRxa-0001g5-41 for bug-gnu-emacs@gnu.org; Sat, 25 Jul 2020 17:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jzRxa-0004ZU-1O for bug-gnu-emacs@gnu.org; Sat, 25 Jul 2020 17:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Jul 2020 21:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42482 X-GNU-PR-Package: emacs Original-Received: via spool by 42482-submit@debbugs.gnu.org id=B42482.159571341217528 (code B ref 42482); Sat, 25 Jul 2020 21:44:01 +0000 Original-Received: (at 42482) by debbugs.gnu.org; 25 Jul 2020 21:43:32 +0000 Original-Received: from localhost ([127.0.0.1]:51285 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jzRx5-0004Yd-MI for submit@debbugs.gnu.org; Sat, 25 Jul 2020 17:43:31 -0400 Original-Received: from mail-ot1-f52.google.com ([209.85.210.52]:35353) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jzRx4-0004YP-0W for 42482@debbugs.gnu.org; Sat, 25 Jul 2020 17:43:30 -0400 Original-Received: by mail-ot1-f52.google.com with SMTP id d4so9687186otk.2 for <42482@debbugs.gnu.org>; Sat, 25 Jul 2020 14:43:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=aocz8Z6IHqDVCp2Reaglh9Vhf0ozN6i92QPsr85LD0I=; b=NCI/OJFkUqvFtpMIeGw6ZswIeu3/FnbkgK0OH4uz/DB5IVEZalbF9lHDCeL1Y4yIh0 AqiALC7whZCCq8EcJn8gcAy8e5JnPq9+aDat7/kHoNQjx5r8EUHZtL1oGSm7IKStK9ZY LTQWcf3AbrsousyNdpmlM/uBcjVzevkegEwJWMH7kwoQGeeao/poa/sPPMTlv+EB0ROA 4E8qCSrKUY3i9OCU2UMdEf9//+f2N473Nn+ZZra/+QuEX7bFJ3s1xIThQxDdgGdg0Co5 c1hHsXW5C10KQitmKcoB59EqxJS/rA+nKzxJIyJGNkKEnJPaGx5KhL8tR7XmmaWpIw4q mnDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=aocz8Z6IHqDVCp2Reaglh9Vhf0ozN6i92QPsr85LD0I=; b=tBD+DzMGpbUGpyWdQaV9G9KrwK+LNpdf2r6xUndYYIIRj8MwPuxsSBB2gGJiELWGkg qkMfEPPfawCI5TawBEPgmyqL+j76M6gfyYWQklShiRYgCDslEFYFFPDejVmC8PN3glKk 4yyijiw+NEEhSRR8TpDraTMpNoOR+UOnHeQQNW07ENST64MJ+4pQiZqZxRTaVkMAT6vY OxhXetN2sf8cLHgm6tTpPp/Dw5VXwF0RzK4Xf3xQhfItTcy0hNLmSaUOsgHrcMKY4nyn RLiqaMeZzr/z/JQ/qXThv8LixsodBStKwqkrhOSHZ2EN7dJYe/CkRz3FI1YBbHoIoc07 anPA== X-Gm-Message-State: AOAM533PqvIymKnHZ99HJVurBYGmo+MuhnzqPwzLPmIpx2m/DuS8FlR0 c33ngrDIlmNPOaHLMMtscb9L0x+FOZx3wWQeiI9gig== X-Google-Smtp-Source: ABdhPJwViPj40g1xRJXPE1pSCc4ovTdT6gccMK1li010bXaAljVZp3qEaAhAWXUnc0kpUJ2b66TVmnUXqFEnXXO2QOk= X-Received: by 2002:a05:6830:1daa:: with SMTP id z10mr14489238oti.36.1595713404424; Sat, 25 Jul 2020 14:43:24 -0700 (PDT) In-Reply-To: <83365if7lz.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:183556 Archived-At: Am Do., 23. Juli 2020 um 19:45 Uhr schrieb Eli Zaretskii : > > > From: Philipp Stephani > > Date: Thu, 23 Jul 2020 16:33:12 +0200 > > Cc: 42482-done@debbugs.gnu.org > > > > Am Do., 23. Juli 2020 um 16:29 Uhr schrieb Milan Stanojevi=C4=87 > > : > > > > > > Thank you for the quick fix. > > > Is there a chance this also goes to emacs-27 branch so it can be in > > > the emacs 27.1 when it gets released? > > > > I think backporting the fix should be fine, as the fix is rather > > localized and fixes a regression. Eli? > > How well was it tested? The change is not exactly trivial. But if > you are satisfied with the testing enough to have this in emacs-27, > I'm okay with that. I'd like to have a few more test cases around global references in emacs-27, as the current test cases only test some simple/success cases, and we'd probably want to test at least a few more edge cases (e.g. freeing global references in a different order than allocating them). I've added two more test cases on master and will see that I can add a few more in the coming days.