From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#19977: 24.4; Incorrect translation of Super modifier with Ctrl or Meta on OS X Date: Tue, 29 Mar 2016 16:38:52 +0000 Message-ID: References: <83r3etwc9j.fsf@gnu.org> <83lh51w9z8.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a11401494b75d0e052f32aadf X-Trace: ger.gmane.org 1459269636 22667 80.91.229.3 (29 Mar 2016 16:40:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 29 Mar 2016 16:40:36 +0000 (UTC) Cc: 19977@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 29 18:40:23 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1akwgi-00053x-QP for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Mar 2016 18:40:17 +0200 Original-Received: from localhost ([::1]:48700 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akwgi-0007s2-2W for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Mar 2016 12:40:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43486) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akwga-0007gy-6L for bug-gnu-emacs@gnu.org; Tue, 29 Mar 2016 12:40:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akwgU-0002Am-GN for bug-gnu-emacs@gnu.org; Tue, 29 Mar 2016 12:40:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46856) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akwgU-0002Ai-D7 for bug-gnu-emacs@gnu.org; Tue, 29 Mar 2016 12:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1akwgU-0003F0-6L for bug-gnu-emacs@gnu.org; Tue, 29 Mar 2016 12:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Mar 2016 16:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19977 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 19977-submit@debbugs.gnu.org id=B19977.145926955012379 (code B ref 19977); Tue, 29 Mar 2016 16:40:02 +0000 Original-Received: (at 19977) by debbugs.gnu.org; 29 Mar 2016 16:39:10 +0000 Original-Received: from localhost ([127.0.0.1]:43982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akwfd-0003Db-Su for submit@debbugs.gnu.org; Tue, 29 Mar 2016 12:39:10 -0400 Original-Received: from mail-lf0-f54.google.com ([209.85.215.54]:35052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akwfc-0003DN-9j for 19977@debbugs.gnu.org; Tue, 29 Mar 2016 12:39:08 -0400 Original-Received: by mail-lf0-f54.google.com with SMTP id k79so16340684lfb.2 for <19977@debbugs.gnu.org>; Tue, 29 Mar 2016 09:39:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4JSUNPl9hKS5Nf09xQSdCkXi4LAq3CK9XCS8Cuhkxc4=; b=iigt7Tw1qiMhJ3ZbDHiRvCFZOs13bps27l4OyuW9mYEP0OlfnZsCGTLEWOhTMvmf8U gsgmQ/q08AwTDlqzi+kkGUTTDDXuA87f5a5exTycaiNqb6g0IdMis0tMJI+GnqcavtlV 8PITT+kEONCWlhsTZ4wJpUGRjKt3fDUWqTyrDOxWi6G5LscKpXskDJ7TKKz+E/kaGctc 30QTKXtuLn35CtSn5lW0SU+9a2XxwSDdlYKTiYAtXOWHKlPFhLII3qbGsCpTtwjKVc4C xp2J9G8XxgV3kvBOOAnJDY/01xdZ4m5ZeF1RHu1buYRCr93/QVn9tHKDqg0SYIss4Bdc kcOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4JSUNPl9hKS5Nf09xQSdCkXi4LAq3CK9XCS8Cuhkxc4=; b=l4NGoumQ++N9+Qc0bggR38MAMvdZy6Mr0ALeIwsA9mRti4Q9CLua9gCGLzqMJsVVHB oyuc7MV67zh6aMFQb+ExPuqSlgrO1vg4liUTfhWhXaLSdskdpOyWatRUAGFu8AFSmyUd IWV5Gazesrzkq/C214aR1Gn2tYk6FlNGucmPvGESUClg7R8Vum+ulEYsRECSsDblZ3xV kni8yg+B3L5lDlYbHrGouyarkahD3hGilfhVVgVuZi4wIzqLeRe+ZFXDCHm1bxVIkTRZ 9uXPuAmssM/oUEQnu3iqflly8R2VsjgdrU/nTxDVxiMxWlEn4cxln43EI8wxCv9At5RT L2ZA== X-Gm-Message-State: AD7BkJKJfY9pW+9tC7ktu00bC0MMRkwzx8N/UDVUvMKk3jp/YuIer+ATdufOPv4nd7Wb7HkeCFT/P4Z8dh+W6Q== X-Received: by 10.25.148.71 with SMTP id w68mr1627320lfd.23.1459269542400; Tue, 29 Mar 2016 09:39:02 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115719 Archived-At: --001a11401494b75d0e052f32aadf Content-Type: multipart/alternative; boundary=001a11401494b75d09052f32aadd --001a11401494b75d09052f32aadd Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Philipp Stephani schrieb am Di., 29. M=C3=A4rz 2016= um 18:31 Uhr: > Eli Zaretskii schrieb am Di., 29. M=C3=A4rz 2016 um 18:00 = Uhr: > >> > From: Philipp Stephani >> > Date: Tue, 29 Mar 2016 15:45:13 +0000 >> > Cc: 19977@debbugs.gnu.org >> > >> > Some more debugging output, using NS_KEYLOG =3D 1. The input sequence = is >> a, C-a, M-a, s-a, C-S-a, M-S-a, >> > s-S-a, C-s-a, M-s-a. As you can see, 'code' is correct (A or a), excep= t >> for the last two cases. >> >> I guess someone who understand how keyboard input works on OS X will >> have to look into this. >> > > If I comment out the if block below the comment > /* if super (default), take input manager's word so things like > dvorak / qwerty layout work */ > in nsterm.m, everything works. Unless somebody can explain why that if > block exists at all (i.e. why [theEvent characters] instead of [theEvent > charactersIgnoringModifiers] is used), then I'd suggest to remove the blo= ck > completely. > Attached a patch to remove this code. --001a11401494b75d09052f32aadd Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Philip= p Stephani <p.stephani2@gmail.c= om> schrieb am Di., 29. M=C3=A4rz 2016 um 18:31=C2=A0Uhr:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">
<= div dir=3D"ltr">Eli Zaretskii <eliz@gnu.org> schrieb am Di., 29. M=C3=A4rz 2016 um 18:00= =C2=A0Uhr:
> From: Philipp Steph= ani <p.stepha= ni2@gmail.com>
> Date: Tue, 29 Mar 2016 15:45:13 +0000
> Cc: 19977@d= ebbugs.gnu.org
>
> Some more debugging output, using NS_KEYLOG =3D 1. The input sequence = is a, C-a, M-a, s-a, C-S-a, M-S-a,
> s-S-a, C-s-a, M-s-a. As you can see, 'code' is correct (A or a= ), except for the last two cases.

I guess someone who understand how keyboard input works on OS X will
have to look into this.

If I comment out the if block belo= w the comment
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /* if super (def= ault), take input manager's word so things like
=C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0dvorak / qwerty layout work */
in nsterm.m, everything works. Unless somebody can explain why that if blo= ck exists at all (i.e. why [theEvent characters] instead of [theEvent chara= ctersIgnoringModifiers] is used), then I'd suggest to remove the block = completely.=C2=A0

Attache= d a patch to remove this code.=C2=A0
--001a11401494b75d09052f32aadd-- --001a11401494b75d0e052f32aadf Content-Type: application/octet-stream; name="0001-Fix-bug-19977.patch" Content-Disposition: attachment; filename="0001-Fix-bug-19977.patch" Content-Transfer-Encoding: base64 Content-ID: <153c33dce3ab26dc64e1> X-Attachment-Id: 153c33dce3ab26dc64e1 RnJvbSBhNDNkYzUyMDVjNDdhYTlhNGRkNDM3ODI0MGVmMmVjZDQ5YTM5MDRhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwIFN0ZXBoYW5pIDxwaHN0QGdvb2dsZS5jb20+CkRh dGU6IFR1ZSwgMjkgTWFyIDIwMTYgMTg6Mzc6NDAgKzAyMDAKU3ViamVjdDogW1BBVENIXSBGaXgg YnVnIzE5OTc3CgoqIG5zdGVybS5tIChrZXlEb3duOik6IFJlbW92ZSBzcGVjaWFsLWNhc2luZyBv ZiBDb21tYW5kIGtleSB0byBmaXgKYnVnIzE5OTc3LgotLS0KIHNyYy9uc3Rlcm0ubSB8IDM3ICsr LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAyIGlu c2VydGlvbnMoKyksIDM1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9uc3Rlcm0ubSBi L3NyYy9uc3Rlcm0ubQppbmRleCA0MDQ4YWM0Li5kZDUxZTk5IDEwMDY0NAotLS0gYS9zcmMvbnN0 ZXJtLm0KKysrIGIvc3JjL25zdGVybS5tCkBAIC01ODczLDQxICs1ODczLDggQEAgbm90X2luX2Fy Z3YgKE5TU3RyaW5nICphcmcpCiAgICAgICAgICAgIDogbnNfcmlnaHRfY29tbWFuZF9tb2RpZmll cik7CiAKICAgICAgIGlmIChpc19sZWZ0X2tleSkKLSAgICAgICAgewotICAgICAgICAgIGVtYWNz X2V2ZW50LT5tb2RpZmllcnMgfD0gcGFyc2Vfc29saXRhcnlfbW9kaWZpZXIKLSAgICAgICAgICAg IChuc19jb21tYW5kX21vZGlmaWVyKTsKLQotICAgICAgICAgIC8qIGlmIHN1cGVyIChkZWZhdWx0 KSwgdGFrZSBpbnB1dCBtYW5hZ2VyJ3Mgd29yZCBzbyB0aGluZ3MgbGlrZQotICAgICAgICAgICAg IGR2b3JhayAvIHF3ZXJ0eSBsYXlvdXQgd29yayAqLwotICAgICAgICAgIGlmIChFUSAobnNfY29t bWFuZF9tb2RpZmllciwgUXN1cGVyKQotICAgICAgICAgICAgICAmJiAhZm5LZXlzeW0KLSAgICAg ICAgICAgICAgJiYgW1t0aGVFdmVudCBjaGFyYWN0ZXJzXSBsZW5ndGhdICE9IDApCi0gICAgICAg ICAgICB7Ci0gICAgICAgICAgICAgIC8qIFhYWDogdGhlIGNvZGUgd2UgZ2V0IHdpbGwgYmUgdW5z aGlmdGVkLCBzbyBpZiB3ZSBoYXZlCi0gICAgICAgICAgICAgICAgIGEgc2hpZnQgbW9kaWZpZXIs IG11c3QgY29udmVydCBvdXJzZWx2ZXMgKi8KLSAgICAgICAgICAgICAgaWYgKCEoZmxhZ3MgJiBO U1NoaWZ0S2V5TWFzaykpCi0gICAgICAgICAgICAgICAgY29kZSA9IFtbdGhlRXZlbnQgY2hhcmFj dGVyc10gY2hhcmFjdGVyQXRJbmRleDogMF07Ci0jaWYgMAotICAgICAgICAgICAgICAvKiB0aGlz IGlzIHVnbHkgYW5kIGFsc28gcmVxdWlyZXMgbGlua2luZyB3L0NhcmJvbiBmcmFtZXdvcmsKLSAg ICAgICAgICAgICAgICAgKGZvciBMTUdldEtiZFR5cGUpIHNvIGZvciBub3cgbGVhdmUgdGhpcyBy YXJlICg/KSBjYXNlCi0gICAgICAgICAgICAgICAgIHVuZGVhbHQgd2l0aC4uIGluIGZ1dHVyZSBs b29rIGludG8gQ0dFdmVudCBtZXRob2RzICovCi0gICAgICAgICAgICAgIGVsc2UKLSAgICAgICAg ICAgICAgICB7Ci0gICAgICAgICAgICAgICAgICBsb25nIHNtdiA9IEdldFNjcmlwdE1hbmFnZXJW YXJpYWJsZSAoc21LZXlTY3JpcHQpOwotICAgICAgICAgICAgICAgICAgSGFuZGxlIHVjaHJIYW5k bGUgPSBHZXRSZXNvdXJjZQotICAgICAgICAgICAgICAgICAgICAoJ3VjaHInLCBHZXRTY3JpcHRW YXJpYWJsZSAoc212LCBzbVNjcmlwdEtleXMpKTsKLSAgICAgICAgICAgICAgICAgIFVJbnQzMiBk dW1teSA9IDA7Ci0gICAgICAgICAgICAgICAgICBVQ0tleVRyYW5zbGF0ZSAoKFVDS2V5Ym9hcmRM YXlvdXQqKSp1Y2hySGFuZGxlLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgW1t0 aGVFdmVudCBjaGFyYWN0ZXJzXSBjaGFyYWN0ZXJBdEluZGV4OiAwXSwKLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGtVQ0tleUFjdGlvbkRpc3BsYXksCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAoZmxhZ3MgJiB+TlNDb21tYW5kS2V5TWFzaykgPj4gOCwKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIExNR2V0S2JkVHlwZSAoKSwga1VDS2V5VHJhbnNs YXRlTm9EZWFkS2V5c01hc2ssCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAmZHVt bXksIDEsICZkdW1teSwgJmNvZGUpOwotICAgICAgICAgICAgICAgICAgY29kZSAmPSAweEZGOwot ICAgICAgICAgICAgICAgIH0KLSNlbmRpZgotICAgICAgICAgICAgfQotICAgICAgICB9CisgICAg ICAgIGVtYWNzX2V2ZW50LT5tb2RpZmllcnMgfD0gcGFyc2Vfc29saXRhcnlfbW9kaWZpZXIKKyAg ICAgICAgICAobnNfY29tbWFuZF9tb2RpZmllcik7CiAKICAgICAgIGlzX3JpZ2h0X2tleSA9IChm bGFncyAmIE5TUmlnaHRDb250cm9sS2V5TWFzaykgPT0gTlNSaWdodENvbnRyb2xLZXlNYXNrOwog ICAgICAgaXNfbGVmdF9rZXkgPSAoZmxhZ3MgJiBOU0xlZnRDb250cm9sS2V5TWFzaykgPT0gTlNM ZWZ0Q29udHJvbEtleU1hc2sKLS0gCjIuNy40Cgo= --001a11401494b75d0e052f32aadf--