unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Philipp Stephani <p.stephani2@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "Mattias Engdegård" <mattiase@acm.org>, 44674@debbugs.gnu.org
Subject: bug#44674: 28.0.50; Adding current-cpu-time for performance tests
Date: Mon, 16 Nov 2020 19:39:35 +0100	[thread overview]
Message-ID: <CAArVCkRvjYrFiNtGXAd+XyaN0iDcAA4P7TCXj=aJG25cir2BNA@mail.gmail.com> (raw)
In-Reply-To: <jwvzh3hjpu3.fsf-monnier+emacs@gnu.org>

Am Mo., 16. Nov. 2020 um 16:27 Uhr schrieb Stefan Monnier
<monnier@iro.umontreal.ca>:
>
> Philipp wrote:
> > It might be beneficial to use the higher-resolution clock_gettime with
> > CLOCK_PROCESS_CPUTIME_ID if available and only fall back to clock()
> > otherwise.
> >
> > While there, consider also implementing a function to read the
> > CLOCK_MONOTONIC clock – that should be preferred over the realtime
> > clock for stopwatch-style measurements.
>
> Given that we've lived without any of it for so many years, I'm not sure
> it's worth the trouble.

It's definitely not a pressing concern, but the current approach does
give wrong results if a leap second happens or on other occasions. See
e.g. https://go.googlesource.com/proposal/+/master/design/12914-monotonic.md
for why Go introduced monotonic clock measurements. Other languages
had the distinction between wall clocks and monotonic clocks for a
long time as well (e.g. Java System.nanoTime).

>  Also since I'm not familiar with any of those
> interfaces, I'd welcome it if someone else could do that if
> they're interested.

I wouldn't mind doing it, if there's general agreement that it's worth having.
But it would really just be:
1. clock_gettime(CLOCK_MONOTONIC_ID)
2. check for errors
3. make_lisp_time





  parent reply	other threads:[~2020-11-16 18:39 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-16  1:07 bug#44674: 28.0.50; Adding current-cpu-time for performance tests Stefan Monnier
2020-11-16  7:13 ` Philipp Stephani
2020-11-16  7:58 ` Eli Zaretskii
2020-11-16  8:18   ` Eli Zaretskii
2020-11-16 11:46     ` Philipp Stephani
2020-11-16 17:17       ` Eli Zaretskii
2020-11-16 18:31         ` Philipp Stephani
2020-11-16 19:12           ` Eli Zaretskii
2020-11-16 22:09           ` Lars Ingebrigtsen
2020-11-16 10:11 ` Mattias Engdegård
2020-11-16 10:40   ` Eli Zaretskii
2020-11-16 10:48     ` Philipp Stephani
2020-11-16 10:53     ` Mattias Engdegård
2020-11-16 17:15       ` Eli Zaretskii
2020-11-16 15:27   ` Stefan Monnier
2020-11-16 16:14     ` Mattias Engdegård
2020-11-16 17:28     ` Eli Zaretskii
2020-11-16 17:38       ` Eli Zaretskii
2020-11-16 17:59         ` Andreas Schwab
2020-11-16 18:27           ` Eli Zaretskii
2020-11-16 18:41         ` Stefan Monnier
2020-11-16 19:22           ` Eli Zaretskii
2020-11-16 18:32       ` Philipp Stephani
2020-11-16 19:17         ` Eli Zaretskii
2020-11-16 20:10         ` Stefan Monnier
2020-11-16 18:41       ` Stefan Monnier
2020-11-16 18:39     ` Philipp Stephani [this message]
2020-11-16 19:07       ` Stefan Monnier
2020-11-16 17:13   ` Eli Zaretskii
2020-11-16 19:15     ` Mattias Engdegård
2022-04-26 13:55 ` Lars Ingebrigtsen
2022-04-26 15:13   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-27 13:09     ` Lars Ingebrigtsen
2022-04-27 17:14       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-27 17:20         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAArVCkRvjYrFiNtGXAd+XyaN0iDcAA4P7TCXj=aJG25cir2BNA@mail.gmail.com' \
    --to=p.stephani2@gmail.com \
    --cc=44674@debbugs.gnu.org \
    --cc=mattiase@acm.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).