unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Philipp Stephani <p.stephani2@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: mail@xuchunyang.me, 34104-done@debbugs.gnu.org
Subject: bug#34104: 26.1; Inaccurate error report of (sort "cba" #'<)
Date: Sun, 20 Jan 2019 00:05:04 +0100	[thread overview]
Message-ID: <CAArVCkRsGS2oeFXnoQ_tPAaPNqu=bUs1hgZ9nrCw-aftkK8htw@mail.gmail.com> (raw)
In-Reply-To: <838szicqpq.fsf@gnu.org>

Am Fr., 18. Jan. 2019 um 09:31 Uhr schrieb Eli Zaretskii <eliz@gnu.org>:
>
> > From: Philipp Stephani <p.stephani2@gmail.com>
> > Date: Thu, 17 Jan 2019 23:43:16 +0100
> > Cc: 34104@debbugs.gnu.org
> >
> > > Debugger entered--Lisp error: (wrong-type-argument sequencep "cba")
> > >   sort("cba" <)
> > >   eval((sort "cba" (function <)) nil)
> > >   elisp--eval-last-sexp(nil)
> > >   eval-last-sexp(nil)
> > >   funcall-interactively(eval-last-sexp nil)
> > >   call-interactively(eval-last-sexp nil nil)
> > >   command-execute(eval-last-sexp)
> > >
> > > the error is inaccurate since "cba" is indeed a sequence
> > >
> > > (sequencep "cba")
> > > ;; => t
> > >
> > > it should report "cba" is not a list or vector instead.
> > >
> >
> >
> > Here's a patch.
>
> LGTM, thanks.

Pushed as 551051596f.





      reply	other threads:[~2019-01-19 23:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-16 14:53 bug#34104: 26.1; Inaccurate error report of (sort "cba" #'<) mail
2019-01-17 22:43 ` Philipp Stephani
2019-01-18  8:30   ` Eli Zaretskii
2019-01-19 23:05     ` Philipp Stephani [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAArVCkRsGS2oeFXnoQ_tPAaPNqu=bUs1hgZ9nrCw-aftkK8htw@mail.gmail.com' \
    --to=p.stephani2@gmail.com \
    --cc=34104-done@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=mail@xuchunyang.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).