From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#26624: 26.0.50; Generalized variable `buffer-local-value' does't restore local flag Date: Fri, 29 Sep 2017 20:55:41 +0000 Message-ID: References: <87zid6udys.fsf@drachen> <87o9q0m77u.fsf@users.sourceforge.net> <87d16gm1qf.fsf@users.sourceforge.net> <837ewi9c4z.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="94eb2c1c10020acfba055a5a408c" X-Trace: blaine.gmane.org 1506718576 20398 195.159.176.226 (29 Sep 2017 20:56:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 29 Sep 2017 20:56:16 +0000 (UTC) Cc: michael_heerdegen@web.de, 26624@debbugs.gnu.org To: Eli Zaretskii , Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 29 22:56:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dy2KJ-0004Qp-Rs for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Sep 2017 22:56:04 +0200 Original-Received: from localhost ([::1]:37070 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dy2KR-0000SF-8j for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Sep 2017 16:56:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dy2KL-0000S6-Nd for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2017 16:56:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dy2KI-0005oT-LV for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2017 16:56:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59263) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dy2KI-0005nf-Hy for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2017 16:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dy2KI-0002f3-4i for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2017 16:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Sep 2017 20:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26624 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 26624-submit@debbugs.gnu.org id=B26624.150671855810217 (code B ref 26624); Fri, 29 Sep 2017 20:56:02 +0000 Original-Received: (at 26624) by debbugs.gnu.org; 29 Sep 2017 20:55:58 +0000 Original-Received: from localhost ([127.0.0.1]:39711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dy2KE-0002eh-BS for submit@debbugs.gnu.org; Fri, 29 Sep 2017 16:55:58 -0400 Original-Received: from mail-oi0-f52.google.com ([209.85.218.52]:54169) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dy2KD-0002eT-AH for 26624@debbugs.gnu.org; Fri, 29 Sep 2017 16:55:57 -0400 Original-Received: by mail-oi0-f52.google.com with SMTP id j126so1322277oia.10 for <26624@debbugs.gnu.org>; Fri, 29 Sep 2017 13:55:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eM5PM27nc1SO9mYySDTHF8tPaHDDqnTMS377nmO/YGY=; b=FASaE2IhK8RZoXUxR+76g/HavEb7AXi/BVloax0F24mnwVvxLEP4oCPVXLER8aL/QX 77Es0DQaVUWAWIYxAbSrN7FMKIZTUcwI494tIAbP9eOGdl25DUSE+hFZ5nfz70CkBiM9 uu1twO2Yhn9v5nqh3ZOXDuFYvsioDRQfIVDlYZxEdpYFKRVTViDoeg7fcJLBw8aRoiNZ mKDueaa3WVAWp/p+0BmIgnxexA8aWm/Q92qFaKhDr4QvjVUhUTnwj0RX6BOKM+6DYlYR wJ9MZuldjUwiSGJThdDbUT6myC7rJ5TD8gaQRq3rAdwLllKbbECLc/J6DL6u//ZWOWno /D+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eM5PM27nc1SO9mYySDTHF8tPaHDDqnTMS377nmO/YGY=; b=VDBjmn7DYkNtRlolgLuCJjxgGdVokbUIRz6bjvwAR1O+3G4Q2X0VNTeqO8rFvb+6Av HXQRlSAvqVXPlRWEYpjf7I6UdSUqis9e+xm5hBXJIqdLUgHnlF3ShzICyCj6jsEiSaKD 6B5hrjPGJJ++0b3uRFt+P9hA3SwsDdUGY50Bn1SJ9nRnjLQAKbw0zOlS2O2JXOoVP4I0 O3DqDncijc1VWwNXgKWLWu0jI4wb4MAqA644s+cr5krA69NayNl7VFCAThCHNBUjdnkA 7FxAkcyTgDEMfoNYCVVa6sdHZSAvDcBps1gCUAVXsOcNIeADtjeLb46hHgXgZmvJUqop I9Lw== X-Gm-Message-State: AMCzsaXp+L3DnXEb/7fcyNZ8dV1C2jXaFd18FfpWSuMbvRun7T23YEHz g2ma9zIfrqpZpIN7H2FSGdrHEB9cwSHhO/y9x00= X-Google-Smtp-Source: AOwi7QBSGccUvFr1BpDWBZa7+mXLVgGJMgYRFGEKXEiKI9DYcopFcpJ+wxTLdWMkSSYv2ZkCMjDnBLpt5u3Zb1vuZiM= X-Received: by 10.157.66.142 with SMTP id r14mr3231710ote.335.1506718551558; Fri, 29 Sep 2017 13:55:51 -0700 (PDT) In-Reply-To: <837ewi9c4z.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137650 Archived-At: --94eb2c1c10020acfba055a5a408c Content-Type: text/plain; charset="UTF-8" Eli Zaretskii schrieb am Fr., 29. Sep. 2017 um 09:51 Uhr: > > From: Noam Postavsky > > Date: Sun, 24 Sep 2017 13:43:20 -0400 > > Cc: Michael Heerdegen , 26624@debbugs.gnu.org > > > > Philipp Stephani writes: > > > > > Noam Postavsky schrieb am So., 24. > > > Sep. 2017 um 17:44 Uhr: > > > > > > Philipp Stephani writes: > > > > > > > * lisp/emacs-lisp/gv.el (buffer-local-value): Remove. > > > > > > Is it possible to just give an obsolete warning first? > > > > > > > > > I don't think it's possible in the sense of `make-obsolete' because > > > the expander is not a named function. > > > It would be possible to use `display-warning' within the body of the > > > setter, but that would only annoy users. > > > If necessary, we might add additional code to the `setf' macro to > > > warn about this form in particular during byte compilation. > > > > IMO, a compilation warning would be appropriate. > > I agree. Removing some feature without due warning is not something > we should do, except in very rare cases (which this one isn't). > I fully agree, but I don't know how to correctly deprecate a generalized variable. Should I add code to the byte compiler to deal with this case explicitly? --94eb2c1c10020acfba055a5a408c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= Fr., 29. Sep. 2017 um 09:51=C2=A0Uhr:
> From: Noam Postavsky <npostavs@users.sourceforge.net>
> Date: Sun, 24 Sep 2017 13:43:20 -0400
> Cc: Michael Heerdegen <michael_heerdegen@web.de>, 26624@debbugs.gnu.org
>
> Philipp Stephani <p.stephani2@gmail.com> writes:
>
> > Noam Postavsky <npostavs@users.sourceforge.net> schrieb am So.= , 24.
> > Sep. 2017 um 17:44=C2=A0Uhr:
> >
> >=C2=A0 =C2=A0 =C2=A0Philipp Stephani <p.stephani2@gmail.com> writes:
> >
> >=C2=A0 =C2=A0 =C2=A0> * lisp/emacs-lisp/gv.el (buffer-local-val= ue): Remove.
> >
> >=C2=A0 =C2=A0 =C2=A0Is it possible to just give an obsolete warnin= g first?
> >
> >
> > I don't think it's possible in the sense of `make-obsolet= e' because
> > the expander is not a named function.
> > It would be possible to use `display-warning' within the body= of the
> > setter, but that would only annoy users.
> > If necessary, we might add additional code to the `setf' macr= o to
> > warn about this form in particular during byte compilation.
>
> IMO, a compilation warning would be appropriate.

I agree.=C2=A0 Removing some feature without due warning is not something we should do, except in very rare cases (which this one isn't).

I fully agree, but I don't know how to cor= rectly deprecate a generalized variable. Should I add code to the byte comp= iler to deal with this case explicitly?=C2=A0=C2=A0
--94eb2c1c10020acfba055a5a408c--