From: Philipp Stephani <p.stephani2@gmail.com>
To: Glenn Morris <rgm@gnu.org>, 28258-done@debbugs.gnu.org
Cc: Mohammed Sadiq <sadiq@sadiqpk.org>
Subject: bug#28258: 26.0.50; [PATCH] Let file-name-base succeed when buffer-file-name is nil
Date: Sun, 24 Sep 2017 08:07:18 +0000 [thread overview]
Message-ID: <CAArVCkRmgdb5j5GvM31pTg6uYdfsMZhFRDNuUmtiY-Dhir31kQ@mail.gmail.com> (raw)
In-Reply-To: <CAArVCkR9p=YxN_OiiD_Dg7rNbLgUiKnQ0WbHnoXyv7Jr4gE8sQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 629 bytes --]
Philipp Stephani <p.stephani2@gmail.com> schrieb am Di., 19. Sep. 2017 um
10:46 Uhr:
> Philipp Stephani <p.stephani2@gmail.com> schrieb am Di., 19. Sep. 2017 um
> 10:31 Uhr:
>
>> Glenn Morris <rgm@gnu.org> schrieb am Di., 19. Sep. 2017 um 02:41 Uhr:
>>
>>>
>>> > I do agree that the calling convention of `file-name-base' is odd. How
>>> > about making the argument mandatory (initially only by changing the
>>> > advertised calling convention and the docstring)?
>>>
>>> Sounds good to me.
>>>
>>
>> OK, here's a patch.
>>
>
> New version of the patch, with all callers and the manual fixed.
>
Pushed to master as 1eb4e5c3c8.
[-- Attachment #2: Type: text/html, Size: 1571 bytes --]
prev parent reply other threads:[~2017-09-24 8:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 2:22 bug#28258: 26.0.50; [PATCH] Let file-name-base succeed when buffer-file-name is nil Mohammed Sadiq
2017-08-29 15:54 ` Glenn Morris
2017-08-29 16:10 ` Mohammed Sadiq
2017-08-29 17:02 ` Glenn Morris
2017-09-18 17:12 ` Philipp Stephani
2017-09-19 0:41 ` Glenn Morris
2017-09-19 8:31 ` Philipp Stephani
2017-09-19 8:46 ` Philipp Stephani
2017-09-24 8:07 ` Philipp Stephani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAArVCkRmgdb5j5GvM31pTg6uYdfsMZhFRDNuUmtiY-Dhir31kQ@mail.gmail.com \
--to=p.stephani2@gmail.com \
--cc=28258-done@debbugs.gnu.org \
--cc=rgm@gnu.org \
--cc=sadiq@sadiqpk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).