From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#30004: 27.0.50; call-interactively reads uninitialized memory Date: Sat, 06 Jan 2018 16:03:44 +0000 Message-ID: References: <837esv9e21.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a1140d2b83f9c9905621db60d" X-Trace: blaine.gmane.org 1515254609 3299 195.159.176.226 (6 Jan 2018 16:03:29 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 6 Jan 2018 16:03:29 +0000 (UTC) Cc: 30004@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 06 17:03:25 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXqwA-000892-Kz for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Jan 2018 17:03:10 +0100 Original-Received: from localhost ([::1]:40589 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eXqyA-0000Kv-3S for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Jan 2018 11:05:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53739) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eXqy2-0000Kp-1r for bug-gnu-emacs@gnu.org; Sat, 06 Jan 2018 11:05:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eXqxy-0003mD-2V for bug-gnu-emacs@gnu.org; Sat, 06 Jan 2018 11:05:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57873) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eXqxx-0003m2-VF for bug-gnu-emacs@gnu.org; Sat, 06 Jan 2018 11:05:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eXqxx-0006V8-I9 for bug-gnu-emacs@gnu.org; Sat, 06 Jan 2018 11:05:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Jan 2018 16:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30004 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30004-submit@debbugs.gnu.org id=B30004.151525464324920 (code B ref 30004); Sat, 06 Jan 2018 16:05:01 +0000 Original-Received: (at 30004) by debbugs.gnu.org; 6 Jan 2018 16:04:03 +0000 Original-Received: from localhost ([127.0.0.1]:38321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXqx1-0006Ts-Hv for submit@debbugs.gnu.org; Sat, 06 Jan 2018 11:04:03 -0500 Original-Received: from mail-qt0-f180.google.com ([209.85.216.180]:41070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXqwy-0006TO-Bs for 30004@debbugs.gnu.org; Sat, 06 Jan 2018 11:04:00 -0500 Original-Received: by mail-qt0-f180.google.com with SMTP id i40so9118091qti.8 for <30004@debbugs.gnu.org>; Sat, 06 Jan 2018 08:04:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6MpPLqlX+KZZtK4ZuXTiiL5Bna2zfMc1GNCPAPhc2Fg=; b=FXPVXMdt+NghhYEO8OTP57vWNX/lLCD04ugBm96XqkvpIpXpxEooj7g+AHo+BHywvV i35/OmsVDHYx7aQZWIQLKUqTAe6DHRCTz/0cP6A5VhAYZ7MrPe+udDMrs1lUs56lCM4u z+P1mthDjOnIEFrNNLSvbDfLjLjfmhfiNk7dEk5LU76d4AElh8wVyZtBYCb1NgzhxwVT ECJepyRtObSs8mDNiyfp/SMNK9mjuA8gwCDQyt0X1JVugX8hh8x7KBUxUuOrnojSkj0j iqW+em5BV1bwJpQ3nTyokihMJNHb4U29/Q/NeF7V948we175g7BeDieCUPeJ8QI4dM7r 9SPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6MpPLqlX+KZZtK4ZuXTiiL5Bna2zfMc1GNCPAPhc2Fg=; b=r52uLXw07O01tK43UneRCQ/wUkJ2xER5oDr8YRe9RpHLH8or3mUmLX35JONJWJwbtA 8oREPbqq8/+QtzPhquEaTgs7zGotN5IbjtSXuZ5ZRF6xod/LoF1gILPy0LfleDHs0Rmj urghlEcC6pw0NNt+uEf3poY9OWs5tvpjg2VeZc1ClRj6oeE8BoSgnMZFfKe2jGjxaYOz Brzwg+amwG+LfbTUX0Bwi1hgCCG+EN8GYwES94BoLRhcGan1exwsYf03Qa8szD1+LYTZ eLuLo7k82HdMu2rQTMqcjjNVbHWkpy/uYuI+C6mK2mRr3WKTpf34+jA/rP+0sN6buSqR c1Kw== X-Gm-Message-State: AKwxytek1vSq8x1Tzrk9Yira1CzVoHqjoATOa5PFSYsAMU4ZEe9by9nE UBWUp/u71aPlwgcWX9Tac1kvx1VdbaZeNTo7yYY= X-Google-Smtp-Source: ACJfBou4zFMr190M2a0MO7beIt3yhW1HtWstp7viIKpCN1dBkPUxV5v24SdtR4lTzk0jzz9rj/V/Yl2Bty4tH6OTqQY= X-Received: by 10.200.35.186 with SMTP id q55mr8718792qtq.73.1515254634746; Sat, 06 Jan 2018 08:03:54 -0800 (PST) In-Reply-To: <837esv9e21.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141839 Archived-At: --001a1140d2b83f9c9905621db60d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Eli Zaretskii schrieb am Sa., 6. Jan. 2018 um 16:56 Uhr: > > From: Philipp > > Date: Sat, 06 Jan 2018 12:31:51 +0100 > > > > When passing a byte that would start a multibyte sequence, > > `call-interactively` uses STRING_CHAR without checking whether the > > entire multibyte sequence is actually part of the string. For example: > > > > $ emacs -batch -nw -Q -eval '(call-interactively (lambda () (interactiv= e > "\xFF")))' > > Invalid control letter =E2=80=98=F0=BF=AF=BE=E2=80=99 (#o775776, #x3fbf= e) in interactive calling > string > > Thanks for catching this. Does the patch below fix this? > > Yes, with that patch Valgrind doesn't find any errors any more. --001a1140d2b83f9c9905621db60d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= Sa., 6. Jan. 2018 um 16:56=C2=A0Uhr:
> From: Philipp <p.stephani2@gmail.com>
> Date: Sat, 06 Jan 2018 12:31:51 +0100
>
> When passing a byte that would start a multibyte sequence,
> `call-interactively` uses STRING_CHAR without checking whether the
> entire multibyte sequence is actually part of the string.=C2=A0 For ex= ample:
>
> $ emacs -batch -nw -Q -eval '(call-interactively (lambda () (inter= active "\xFF")))'
> Invalid control letter =E2=80=98=F0=BF=AF=BE=E2=80=99 (#o775776, #x3fb= fe) in interactive calling string

Thanks for catching this.=C2=A0 Does the patch below fix this?


Yes, with that patch Valgrind doesn= 9;t find any errors any more.=C2=A0
--001a1140d2b83f9c9905621db60d--