From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#25046: 26.0.50; Arguments of `ediff-janitor' undocumented Date: Fri, 02 Dec 2016 13:47:33 +0000 Message-ID: References: <837f7ioez6.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7bb04050bcc6e70542ad2e29 X-Trace: blaine.gmane.org 1480686495 2203 195.159.176.226 (2 Dec 2016 13:48:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 2 Dec 2016 13:48:15 +0000 (UTC) Cc: 25046-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 02 14:48:11 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCoC9-00088P-DA for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Dec 2016 14:48:09 +0100 Original-Received: from localhost ([::1]:34601 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCoCD-0004OT-Ae for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Dec 2016 08:48:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42201) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCoC6-0004OO-JL for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 08:48:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cCoC2-0002co-J4 for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 08:48:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34210) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cCoC2-0002cf-Fy for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 08:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cCoC2-0005dj-AN for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 08:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Dec 2016 13:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25046-done@debbugs.gnu.org id=D25046.148068647221662 (code D ref 25046); Fri, 02 Dec 2016 13:48:02 +0000 Original-Received: (at 25046-done) by debbugs.gnu.org; 2 Dec 2016 13:47:52 +0000 Original-Received: from localhost ([127.0.0.1]:49609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCoBr-0005dJ-Ts for submit@debbugs.gnu.org; Fri, 02 Dec 2016 08:47:52 -0500 Original-Received: from mail-wj0-f169.google.com ([209.85.210.169]:36466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCoBq-0005d4-9P for 25046-done@debbugs.gnu.org; Fri, 02 Dec 2016 08:47:50 -0500 Original-Received: by mail-wj0-f169.google.com with SMTP id qp4so232612150wjc.3 for <25046-done@debbugs.gnu.org>; Fri, 02 Dec 2016 05:47:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=icAGlxWJBA9QhyY1bhbU+AUIKBnjgk/UZMBPb+jzXvU=; b=bWfvxhIkcYJklSjmex5N3vKeoyqqDqrF1UE9OHuRx2p7e+9KlQWcyGLXTUzwt2v4s4 WGb8Ald85S1Tocg/3pnb+UWbvavMWVT9/swn2ssw6UsBxbKL789mYKsPr69UMvjo55ej UvvLhNlrYxEP7y7yy3Vh9WuGp/EWIS6NkbgYjcbPUnIJH9qwEAU3gmqPBfG0g+yYQeCR cdB/adXGs9cxqu8mEvwEFrZhtWOyHsSEpdkGFKYoTqdn2ScAi6UXkIqTF8dK4rxx6W+z SbxZCs4mnQtYrG81VTOyNz9ccb0otU/SFXPZcGEU83saiCWg8MGXXUe4Ro4v8jcoffrQ osTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=icAGlxWJBA9QhyY1bhbU+AUIKBnjgk/UZMBPb+jzXvU=; b=adbldAXWFcUFqhaaDKxMpMcktEVdNOAHGl6VN7y481ya6fZkhlWeKU0kOfHcKDHLLP 2OwiSatcTS90kwevZ2R0+z9xP2WNe/ySP6SuXAxngwBpjY2+fOF8H6td7w8IGT2azQa+ QrZceLvG/YDRn1dCPBQ0Sl1bRM93Q5h7Rtst2NuYf0NHg/q4DzHZBvzkDWKB4QCTUHlJ fEhT7xjMkppjTp9lpie10a9qBYrKOaKkdSk2sT7qeqk9GsBkPQoCyhlpvuZtYHcVkriN XtmD1/6ViOyL6oUZTKShNQVTt/vcweZha4mgqaiAVJyypAg6vw0UO8Lz4LaUG26A/Gag awNw== X-Gm-Message-State: AKaTC02yMa9owLtXkefC57n4kWymxXzs6dqLR21uPCk9Za/MaO2mU8EB0/BatsOsvtiemo2ayxbTxwjhLoTptg== X-Received: by 10.194.95.35 with SMTP id dh3mr40124895wjb.141.1480686464449; Fri, 02 Dec 2016 05:47:44 -0800 (PST) In-Reply-To: <837f7ioez6.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126408 Archived-At: --047d7bb04050bcc6e70542ad2e29 Content-Type: text/plain; charset=UTF-8 Eli Zaretskii schrieb am Fr., 2. Dez. 2016 um 10:30 Uhr: > > From: Philipp Stephani > > Date: Sun, 27 Nov 2016 21:30:18 +0100 > > > > The function `ediff-janitor' has two required arguments, ASK and > > KEEP-JANITOR, which are not documented in the docstring. > > Thanks, fixed on the emacs-25 branch. > Thanks, however I'm still not quite sure about the meaning. "ASK non-nil means ask the user whether to keep each unmodified buffer, unless KEEP-VARIANTS is non-nil, in which case buffers are killed unconditionally." So if ASK = nil, KEEP-VARIANTS = nil: kill buffers, don't ask about any buffer ASK = (nil or non-nil), KEEP-VARIANTS = non-nil: don't kill any buffer, don't ask ASK = non-nil, KEEP-VARIANTS = nil: ask about each buffer If that's the case, shouldn't the documentation rather be something like: "If KEEP-VARIANTS is non-nil, only indirect buffers are killed [what does that mean for the user?], and ASK is ignored. Otherwise, if ASK is non-nil, ask the user for each unmodified buffer whether it should be killed. Otherwise (both ASK and KEEP-VARIANTS) are nil, all unmodified buffers are killed without confirmation." WDYT? --047d7bb04050bcc6e70542ad2e29 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= Fr., 2. Dez. 2016 um 10:30=C2=A0Uhr:
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Sun, 27 Nov 2016 21:30:18 +0100
>
> The function `ediff-janitor' has two required arguments, ASK and > KEEP-JANITOR, which are not documented in the docstring.

Thanks, fixed on the emacs-25 branch.
<= div>
Thanks, however I'm still not quite sure about the m= eaning.
"ASK non-nil means ask the user whether to keep each= unmodified buffer, unless KEEP-VARIANTS is non-nil, in which case buffers = are killed unconditionally."
So if ASK =3D nil, KEEP-VARIANT= S =3D nil: kill buffers, don't ask about any buffer
ASK =3D (= nil or non-nil), KEEP-VARIANTS =3D non-nil: don't kill any buffer, don&= #39;t ask
ASK =3D non-nil, KEEP-VARIANTS =3D nil: ask about each = buffer

If that's the case, shouldn't the d= ocumentation rather be something like:
"If KEEP-VARIANTS is = non-nil, only indirect buffers are killed [what does that mean for the user= ?], and ASK is ignored. Otherwise, if ASK is non-nil, ask the user for each= unmodified buffer whether it should be killed. Otherwise (both ASK and KEE= P-VARIANTS) are nil, all unmodified buffers are killed without confirmation= ."
WDYT?=C2=A0
--047d7bb04050bcc6e70542ad2e29--