bug#29345: 27.0.50; Error message for cl-destructuring-bind could be improved

bug#29345: 27.0.50; Error message for cl-destructuring-bind could be improved

[Philipp Stephani]

$ emacs -Q -batch -l cl-lib -eval '(cl-destructuring-bind (a b) (list 1))'
Wrong number of arguments: nil, 1

It would be nice if the first error data item weren't nil, but
e.g. `(cl-destructuring-bind (a b))` so that the error is obvious.


In GNU Emacs 27.0.50 (build 12, x86_64-pc-linux-gnu, GTK+ Version 3.22.17)
 of 2017-11-16 built on localhost
Repository revision: bc462efec89c3317a6ee3ef9404356c1c7e52bda
Windowing system distributor 'The X.Org Foundation', version 11.0.11903000
System Description:	Debian GNU/Linux

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Configured using:
 'configure --enable-gcc-warnings=warn-only
 --enable-gtk-deprecation-warnings --without-pop --with-mailutils
 --enable-checking --enable-check-lisp-object-type --with-modules
 'CFLAGS=-O0 -ggdb3''

Configured features:
XPM JPEG TIFF GIF PNG SOUND DBUS GSETTINGS NOTIFY GNUTLS FREETYPE XFT
ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv
bytecomp byte-compile cconv cl-loaddefs cl-lib dired dired-loaddefs
format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg
epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util mail-prsvr mail-utils elec-pair time-date
mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode elisp-mode lisp-mode prog-mode register page menu-bar
rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core term/tty-colors frame cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote dbusbind inotify
dynamic-setting system-font-setting font-render-setting move-toolbar gtk
x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 95121 6651)
 (symbols 48 20393 1)
 (miscs 40 41 120)
 (strings 32 28283 1508)
 (string-bytes 1 747240)
 (vectors 16 14057)
 (vector-slots 8 497412 8738)
 (floats 8 49 68)
 (intervals 56 224 0)
 (buffers 992 12))

-- 
Google Germany GmbH
Erika-Mann-Straße 33
80636 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado

If you received this communication by mistake, please don’t forward it to
anyone else (it may contain confidential or privileged information), please
erase all copies of it, including all attachments, and please let the sender
know it went to the wrong person.  Thanks.

bug#29345: 27.0.50; Error message for cl-destructuring-bind could be improved

[Lars Ingebrigtsen]

Philipp Stephani <p.stephani2@gmail.com> writes:

> $ emacs -Q -batch -l cl-lib -eval '(cl-destructuring-bind (a b) (list 1))'
> Wrong number of arguments: nil, 1
>
> It would be nice if the first error data item weren't nil, but
> e.g. `(cl-destructuring-bind (a b))` so that the error is obvious.

What about

Wrong number of arguments: (a b), 1

The following patch achieves that, but since it was explicitly 'cl-none
before (which is the magic value that gives you nil in that error
message), I'm not sure whether this has any negative effects?  Probably
not, because there's this:

(defvar cl--bind-block) ;Name of surrounding block, only use for `signal' data.

Any opinions?

diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el
index 4347b4b71b..8b9224bd1b 100644
--- a/lisp/emacs-lisp/cl-macs.el
+++ b/lisp/emacs-lisp/cl-macs.el
@@ -695,8 +695,11 @@ cl-destructuring-bind
   "Bind the variables in ARGS to the result of EXPR and execute BODY."
   (declare (indent 2)
            (debug (&define cl-macro-list1 def-form cl-declarations def-body)))
-  (let* ((cl--bind-lets nil) (cl--bind-forms nil)
-	 (cl--bind-defs nil) (cl--bind-block 'cl-none) (cl--bind-enquote nil))
+  (let* ((cl--bind-lets nil)
+         (cl--bind-forms nil)
+	 (cl--bind-defs nil)
+         (cl--bind-block args)
+         (cl--bind-enquote nil))
     (cl--do-arglist (or args '(&aux)) expr)
     (macroexp-let* (nreverse cl--bind-lets)
                    (macroexp-progn (append (nreverse cl--bind-forms) body)))))


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#29345: 27.0.50; Error message for cl-destructuring-bind could be improved

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Philipp Stephani <p.stephani2@gmail.com> writes:
>
>> $ emacs -Q -batch -l cl-lib -eval '(cl-destructuring-bind (a b) (list 1))'
>> Wrong number of arguments: nil, 1
>>
>> It would be nice if the first error data item weren't nil, but
>> e.g. `(cl-destructuring-bind (a b))` so that the error is obvious.
>
> What about
>
> Wrong number of arguments: (a b), 1
>
> The following patch achieves that, but since it was explicitly 'cl-none
> before (which is the magic value that gives you nil in that error
> message), I'm not sure whether this has any negative effects?  Probably
> not, because there's this:
>
> (defvar cl--bind-block) ;Name of surrounding block, only use for `signal' data.
>
> Any opinions?

There weren't any, so I'm applying the patch.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#29345: 27.0.50; Error message for cl-destructuring-bind could be improved

[Philipp Stephani]

Am Do., 25. Juli 2019 um 21:54 Uhr schrieb Lars Ingebrigtsen <larsi@gnus.org>:
>
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
> > Philipp Stephani <p.stephani2@gmail.com> writes:
> >
> >> $ emacs -Q -batch -l cl-lib -eval '(cl-destructuring-bind (a b) (list 1))'
> >> Wrong number of arguments: nil, 1
> >>
> >> It would be nice if the first error data item weren't nil, but
> >> e.g. `(cl-destructuring-bind (a b))` so that the error is obvious.
> >
> > What about
> >
> > Wrong number of arguments: (a b), 1
> >
> > The following patch achieves that, but since it was explicitly 'cl-none
> > before (which is the magic value that gives you nil in that error
> > message), I'm not sure whether this has any negative effects?  Probably
> > not, because there's this:
> >
> > (defvar cl--bind-block) ;Name of surrounding block, only use for `signal' data.
> >
> > Any opinions?
>
> There weren't any, so I'm applying the patch.

Thanks!