From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#26360: 26.0.50; ido-mode doesn't enable IDO for C-x 4 d Date: Sun, 23 Apr 2017 16:43:59 +0000 Message-ID: References: <87efwmqvym.fsf@users.sourceforge.net> <87efwkp1dp.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a114b391a27dc5d054dd83311 X-Trace: blaine.gmane.org 1492965916 17970 195.159.176.226 (23 Apr 2017 16:45:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 23 Apr 2017 16:45:16 +0000 (UTC) Cc: 26360-done@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 23 18:45:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2KdK-0004Xa-BG for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Apr 2017 18:45:10 +0200 Original-Received: from localhost ([::1]:39898 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2KdQ-0003lM-8d for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Apr 2017 12:45:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2KdH-0003ih-Pi for bug-gnu-emacs@gnu.org; Sun, 23 Apr 2017 12:45:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d2KdC-00036b-TX for bug-gnu-emacs@gnu.org; Sun, 23 Apr 2017 12:45:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38454) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d2KdC-00036T-Oy for bug-gnu-emacs@gnu.org; Sun, 23 Apr 2017 12:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d2KdC-00066s-Da for bug-gnu-emacs@gnu.org; Sun, 23 Apr 2017 12:45:02 -0400 Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Apr 2017 16:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 26360 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 26360@debbugs.gnu.org, p.stephani2@gmail.com, p.stephani2@gmail.com Original-Received: via spool by 26360-done@debbugs.gnu.org id=D26360.149296585723405 (code D ref 26360); Sun, 23 Apr 2017 16:45:02 +0000 Original-Received: (at 26360-done) by debbugs.gnu.org; 23 Apr 2017 16:44:17 +0000 Original-Received: from localhost ([127.0.0.1]:36651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2KcS-00065R-Op for submit@debbugs.gnu.org; Sun, 23 Apr 2017 12:44:16 -0400 Original-Received: from mail-wm0-f44.google.com ([74.125.82.44]:35841) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2KcR-00065C-P5 for 26360-done@debbugs.gnu.org; Sun, 23 Apr 2017 12:44:16 -0400 Original-Received: by mail-wm0-f44.google.com with SMTP id u65so7268531wmu.1 for <26360-done@debbugs.gnu.org>; Sun, 23 Apr 2017 09:44:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2iY9hl3rlYLJNIXi0/ShTpMKMIvAjVtEY6tvhUFyOJU=; b=eHke+70hro5BGy/tn2015MYLOQHvGYExQ2kWo/AFUgfHgDwAjQFdMb4a3NSs3q+3CN 12xnLW5FcQP6vgA0YLqsxfaIACcwhWideRQZ+nMDrAkwnPTgR7dtfHojTk4KcwuGqKel 8Md9ZMDECYAhaCL3RgdIii/8IpL5usmn3cnYc2CDbyvKwLkhnbN7TthDJArzAb7dx3uA mNjLCDISkgA7e7tyglOef4qFfdA1BwOBiWCjp9r5iG1oeery877zCRilfAvT5r9okqzx iDbO3DZ/Q8rrmu/30QOmoJb6kHYx/bdkoBlu/7H3DlIHLPeodkSReGoTBH7Ao59xGS3h e22g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2iY9hl3rlYLJNIXi0/ShTpMKMIvAjVtEY6tvhUFyOJU=; b=WuGCkTtQbkUY6+2mFYTnHj+cbzgLrsKV1q8nNQIvBEXvMiNoUKUK4PVy5XvMcp+TLh UIWwq2EU/uGTWxB7mTCCwoVUhYG1433vKdUhBIhjC768IEgyYazAoSYPWzzpBLYwSWRL Y+uFINI2ugz2oKRR+3B/mhuTQz2vmVux8U6AlsPWnmJKxhiYq9Knh97+J4hdCsWIxN4V 085mMB2crjS4US+qPnyrKjC9pzXsVCbd8CNOuvEFmEuGzx2ecNfp9rT5IZVnG1mWIxfm 51m47uTeZKCDjCmIr5bdQkLJ5Ojo8jCUkjviicrMPthydSt+LW4t7a6x67/kiodR2jDp Fn3A== X-Gm-Message-State: AN3rC/6nrUFQo6GKPPURfyYQupMlUFSjXhsUk+xm2P/Je9cT72IpBAyc hcT2Fd10d8l+I9Wh5I4Ujy+gGy8EsA== X-Received: by 10.28.156.13 with SMTP id f13mr6583345wme.44.1492965850076; Sun, 23 Apr 2017 09:44:10 -0700 (PDT) In-Reply-To: <87efwkp1dp.fsf@users.sourceforge.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:131907 Archived-At: --001a114b391a27dc5d054dd83311 Content-Type: text/plain; charset=UTF-8 schrieb am Sa., 22. Apr. 2017 um 23:38 Uhr: > Philipp Stephani writes: > > > schrieb am Fr., 21. Apr. 2017 um 05:28 > Uhr: > >> > >> Patch looks good, except the test seems redundant to me. I don't think > >> it's useful to test that a command is defined, or testing that specific > >> keybindings have been set (i.e., no need to test again that `defun' or > >> `define-key' are working). > > > > > > I've used a bit of TDD for this patch, thus the verbose test. > > I suppose my real objection is that 'make check' is already taking long > enough that it makes me reluctant to use it, so I don't really want to > see more tests of such marginal utility. But any single test isn't > adding a significant amount of time, so I'm not going to insist. > Agreed that it takes very long, but I think good coverage is more important (and the full suite should mostly be run on continuous integration, not manually). > > In conclusion, feel free to push this; as far as I'm concerned, the > decision about the test is up to you. > Thanks, pushed as a1f93c1dfa. --001a114b391a27dc5d054dd83311 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


<npostavs@users.sourceforge.= net> schrieb am Sa., 22. Apr. 2017 um 23:38=C2=A0Uhr:
Philipp Stephani <p.stephani2@gmail.com> writes:

> <npostavs@users.sourceforge.net> schrieb am Fr., 21. Apr. 2017 um 0= 5:28 Uhr:
>>
>> Patch looks good, except the test seems redundant to me.=C2=A0 I d= on't think
>> it's useful to test that a command is defined, or testing that= specific
>> keybindings have been set (i.e., no need to test again that `defun= ' or
>> `define-key' are working).
>
>
> I've used a bit of TDD for this patch, thus the verbose test.

I suppose my real objection is that 'make check' is already taking = long
enough that it makes me reluctant to use it, so I don't really want to<= br> see more tests of such marginal utility.=C2=A0 But any single test isn'= t
adding a significant amount of time, so I'm not going to insist.

Agreed that it takes very long, but I think g= ood coverage is more important (and the full suite should mostly be run on = continuous integration, not manually).
=C2=A0

In conclusion, feel free to push this; as far as I'm concerned, the
decision about the test is up to you.

Thanks, pushed as a1f93c1dfa.=C2=A0
--001a114b391a27dc5d054dd83311--