bug#41381: 28.0.50; Can't compile file containing a local pcase macro

bug#41381: 28.0.50; Can't compile file containing a local pcase macro

[Philipp Stephani]

$ cat test.el
;;; -*- lexical-binding: t; -*-
(pcase-defmacro test () '_)
(defun test () (pcase nil ((test))))

$ emacs -Q -batch -l bytecomp -f batch-byte-compile test.el

In toplevel form:
test.el:3:1: Error: Symbol’s function definition is void: test--pcase-macroexpander

It works if the pcase macro is surrounded with `eval-when-compile', but
that shouldn't be necessary I think.


In GNU Emacs 28.0.50 (build 12, x86_64-pc-linux-gnu, GTK+ Version 3.24.13, cairo version 1.16.0)
 of 2020-05-18
Repository revision: ca7224d5dbfd6f07d537f6159aae8df667a65497
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12007000
System Description: Debian GNU/Linux rodete

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Configured using:
 'configure --enable-gtk-deprecation-warnings --with-modules
 --without-pop --with-mailutils --enable-gcc-warnings=warn-only
 CFLAGS=-O3 LDFLAGS=-O3'

Configured features:
XPM JPEG TIFF GIF PNG CAIRO SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY
LIBSELINUX GNUTLS FREETYPE HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS GTK3 X11
XDBE XIM MODULES THREADS PDUMPER GMP

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc dired dired-loaddefs
format-spec rfc822 mml easymenu mml-sec epa epg epg-config gnus-util
rmail rmail-loaddefs text-property-search time-date mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail
rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils phst skeleton
derived edmacro kmacro pcase ffap thingatpt url url-proxy url-privacy
url-expand url-methods url-history url-cookie url-domsuf url-util
url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs
password-cache json map url-vars mailcap subr-x rx gnutls puny seq
byte-opt gv bytecomp byte-compile cconv dbus xml compile comint
ansi-color ring cl-loaddefs cl-lib tooltip eldoc electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote threads dbusbind inotify dynamic-setting system-font-setting
font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty
make-network-process emacs)

Memory information:
((conses 16 69142 7839)
 (symbols 48 8951 1)
 (strings 32 23800 1837)
 (string-bytes 1 769195)
 (vectors 16 13264)
 (vector-slots 8 181686 6586)
 (floats 8 25 34)
 (intervals 56 208 0)
 (buffers 992 11))

-- 
Google Germany GmbH
Erika-Mann-Straße 33
80636 München

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg

Diese E-Mail ist vertraulich.  Falls Sie diese fälschlicherweise erhalten haben
sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie
alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail
an die falsche Person gesendet wurde.

This e-mail is confidential.  If you received this communication by mistake,
please don’t forward it to anyone else, please erase all copies and
attachments, and please let me know that it has gone to the wrong person.

bug#41381: 28.0.50; Can't compile file containing a local pcase macro

[Pip Cet]

Philipp Stephani <p.stephani2@gmail.com> writes:
> $ cat test.el
> ;;; -*- lexical-binding: t; -*-
> (pcase-defmacro test () '_)
> (defun test () (pcase nil ((test))))
>
> $ emacs -Q -batch -l bytecomp -f batch-byte-compile test.el
>
> In toplevel form:
> test.el:3:1: Error: Symbol’s function definition is void: test--pcase-macroexpander
>
> It works if the pcase macro is surrounded with `eval-when-compile', but
> that shouldn't be necessary I think.

Wouldn't it be better to surround the pcase-defmacro call with
(eval-and-compile ...)?

I think it would be great if there were some clever way to make eager
macro expansion less eager, so things like evaluating the following two
expressions one after another

(defmacro foo () 3)

(progn
  (defmacro foo () 4)
  (foo))

would produce the right result (4 rather than 3). That would solve this
problem as well, but it's probably impossible to do with reasonable
performance.

bug#41381: 28.0.50; Can't compile file containing a local pcase macro

[Philipp Stephani]

Am Mi., 3. Juni 2020 um 23:59 Uhr schrieb Pip Cet <pipcet@gmail.com>:
>
> Philipp Stephani <p.stephani2@gmail.com> writes:
> > $ cat test.el
> > ;;; -*- lexical-binding: t; -*-
> > (pcase-defmacro test () '_)
> > (defun test () (pcase nil ((test))))
> >
> > $ emacs -Q -batch -l bytecomp -f batch-byte-compile test.el
> >
> > In toplevel form:
> > test.el:3:1: Error: Symbol’s function definition is void: test--pcase-macroexpander
> >
> > It works if the pcase macro is surrounded with `eval-when-compile', but
> > that shouldn't be necessary I think.
>
> Wouldn't it be better to surround the pcase-defmacro call with
> (eval-and-compile ...)?

How about neither? This should work without any "eval-when-..." form.

bug#41381: 28.0.50; Can't compile file containing a local pcase macro

[Michael Heerdegen]

Philipp Stephani <p.stephani2@gmail.com> writes:

> How about neither? This should work without any "eval-when-..." form.

That's what I would expect, too.

Michael.

bug#41381: 28.0.50; Can't compile file containing a local pcase macro

[Lars Ingebrigtsen]

Philipp Stephani <p.stephani2@gmail.com> writes:

> $ cat test.el
> ;;; -*- lexical-binding: t; -*-
> (pcase-defmacro test () '_)
> (defun test () (pcase nil ((test))))
>
> $ emacs -Q -batch -l bytecomp -f batch-byte-compile test.el
>
> In toplevel form:
> test.el:3:1: Error: Symbol’s function definition is void: test--pcase-macroexpander

I'm able to reproduce this in Emacs 27.1, but not on the current trunk,
so I'm going to go ahead and guess that this has been fixed now, and I'm
closing this bug report.  If there's still an issue here, please respond
to the debbugs address and we'll reopen.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#41381: 28.0.50; Can't compile file containing a local pcase macro

[Philipp]

> Am 31.07.2021 um 18:34 schrieb Lars Ingebrigtsen <larsi@gnus.org>:
> 
> Philipp Stephani <p.stephani2@gmail.com> writes:
> 
>> $ cat test.el
>> ;;; -*- lexical-binding: t; -*-
>> (pcase-defmacro test () '_)
>> (defun test () (pcase nil ((test))))
>> 
>> $ emacs -Q -batch -l bytecomp -f batch-byte-compile test.el
>> 
>> In toplevel form:
>> test.el:3:1: Error: Symbol’s function definition is void: test--pcase-macroexpander
> 
> I'm able to reproduce this in Emacs 27.1, but not on the current trunk,
> so I'm going to go ahead and guess that this has been fixed now, and I'm
> closing this bug report.  If there's still an issue here, please respond
> to the debbugs address and we'll reopen.

My guess is that this was fixed by commit 88ca2280ba430ad2fa681c72cc6ba8216709e63f.