From: Philipp Stephani <p.stephani2@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 45012@debbugs.gnu.org
Subject: bug#45012: 27.1.50; Emacs 27.1 release archive missing emacs-module.h
Date: Wed, 2 Dec 2020 19:47:49 +0100 [thread overview]
Message-ID: <CAArVCkR4Ca3u3pTf+HtXUnHe87Zc4AW2wO11LWTyWOT_rSHCoA@mail.gmail.com> (raw)
In-Reply-To: <83tut4f46r.fsf@gnu.org>
Am Mi., 2. Dez. 2020 um 19:33 Uhr schrieb Eli Zaretskii <eliz@gnu.org>:
>
> > From: Philipp Stephani <p.stephani2@gmail.com>
> > Date: Wed, 2 Dec 2020 19:11:44 +0100
> > Cc: 45012@debbugs.gnu.org
> >
> > > commit 1043cd30acffcc0b61da4a80dcf3f8a5ac459267
> > > Author: Paul Eggert <eggert@cs.ucla.edu>
> > > AuthorDate: Sat Jun 8 14:08:05 2019 -0700
> > > Commit: Paul Eggert <eggert@cs.ucla.edu>
> > > CommitDate: Sat Jun 8 14:42:10 2019 -0700
> > >
> > > Fix out-of-source make-dist problems
> > >
> > > Problem with jisx2131-filter reported by Phillip Lord in:
> > > https://lists.gnu.org/r/emacs-devel/2019-06/msg00147.html
> > > * admin/charsets/Makefile.in (SED_SCRIPT):
> > > Put it in $(srcdir), which is not necessarily the working directory.
> > > ($(SED_SCRIPT)): Rename from jisx2131-filter. All uses changed.
> > > (clean): Do not remove SED_SCRIPT.
> > > (extraclean): Remove it here instead.
> > > * make-dist (possibly_non_vc_files): Remove src/emacs-module.h.
> > > Although it is portable and could be distributed in the tarball,
> > > it's too much hassle to do that, so let each builder make it.
> > >
> > > Wasn't there some discussion about the problems with distributing it,
> > > as it is not entirely portable?
> >
> > If so, then we need to fix that. emacs-module.h must be 100% portable.
>
> Why is it a problem that emacs-module.h is built as part of Emacs?
How is that related? emacs-module.h is just a textual concatenation of
various fragments. There's nothing platform-specific that's part of
its build process.
A module author shouldn't need to care about whether emacs-module.h is
checked in or created by configure; it should just be part of the
release.
next prev parent reply other threads:[~2020-12-02 18:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 17:52 bug#45012: 27.1.50; Emacs 27.1 release archive missing emacs-module.h Philipp Stephani
2020-12-02 18:10 ` Eli Zaretskii
2020-12-02 18:11 ` Philipp Stephani
2020-12-02 18:33 ` Eli Zaretskii
2020-12-02 18:47 ` Philipp Stephani [this message]
2020-12-02 18:53 ` Eli Zaretskii
2020-12-06 17:13 ` Philipp Stephani
2020-12-06 19:12 ` Eli Zaretskii
2020-12-12 14:55 ` Philipp Stephani
2020-12-12 18:37 ` Eli Zaretskii
2021-01-24 19:01 ` Philipp Stephani
2020-12-12 18:57 ` Eli Zaretskii
2021-01-24 19:02 ` Philipp Stephani
2021-10-11 12:36 ` Stefan Kangas
2021-10-11 15:32 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAArVCkR4Ca3u3pTf+HtXUnHe87Zc4AW2wO11LWTyWOT_rSHCoA@mail.gmail.com \
--to=p.stephani2@gmail.com \
--cc=45012@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).