From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#44942: 28.0.50; Emacs should print a backtrace on uncaught errors in batch mode Date: Mon, 7 Dec 2020 11:29:16 +0100 Message-ID: References: <83lfeaan04.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8244"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44942@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 07 11:30:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmDmZ-00021l-4f for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Dec 2020 11:30:15 +0100 Original-Received: from localhost ([::1]:46288 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmDmX-0003kq-VV for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Dec 2020 05:30:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55996) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmDmN-0003hh-5Z for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2020 05:30:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40978) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kmDmM-0005AW-SO for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2020 05:30:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kmDmM-0008Oh-Mr for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2020 05:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Dec 2020 10:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44942 X-GNU-PR-Package: emacs Original-Received: via spool by 44942-submit@debbugs.gnu.org id=B44942.160733697432221 (code B ref 44942); Mon, 07 Dec 2020 10:30:02 +0000 Original-Received: (at 44942) by debbugs.gnu.org; 7 Dec 2020 10:29:34 +0000 Original-Received: from localhost ([127.0.0.1]:52524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmDlu-0008Nd-Bl for submit@debbugs.gnu.org; Mon, 07 Dec 2020 05:29:34 -0500 Original-Received: from mail-oo1-f46.google.com ([209.85.161.46]:37573) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmDls-0008NO-Tq for 44942@debbugs.gnu.org; Mon, 07 Dec 2020 05:29:33 -0500 Original-Received: by mail-oo1-f46.google.com with SMTP id t23so3073385oov.4 for <44942@debbugs.gnu.org>; Mon, 07 Dec 2020 02:29:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NUvzW2VmAZ25t9+iuWJSnudzpHvqzLU7oYrCzDDtaQc=; b=epQO2AYfkP0uk+Ou4/CcQvWcRKB5lftA8KaONLXuHH12sr8mpP5LI+du+3bEaYJgrY d7qL7pJVxvv+HdsrQkZ7eRk2g2IuI5wO13WQQ2dD7BJv6ifVcN/aWApawtsmjZ9i1EHO HYrifRrSP9wI9dQkdXp7xeSd1A/Yf0id46/sqBDblaipeMFVeKxbaD+lPWjxPADlzDcm RNjd2+cuzdSinWdLr3y2psePPawOjXKxJfB8auQdWVp3U0HITa/hrpQTmnQvDsMu6P4V kGK3Gh3GX2izyeYiGGK3BH6ZKmqv7fPRKWSCeMtwJ83db9LJvIUdYBKV25+4Dm68K1wH xOkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NUvzW2VmAZ25t9+iuWJSnudzpHvqzLU7oYrCzDDtaQc=; b=D4RKQjPPDs08kgrMgqEDet+U3ipupleJJeP06AI9mmk3pfkenh19St3KjrFZOUEDxI uC+djGUZXu1KJPKB0zkgw+Gyiv2/Oq//H5G+teVcIFojYalR7CvmW2k/dcNbbRQf3zuB x0fH6KwK1PMKaPYBJDJmhDnkBKF0r8Cd4X2YqmgQR/dJ3nin/InhV3XnBB7tS9kWwaqb pvXqcd4Lfo2wOwYafSC9VlZNTwm1y8WoT2oH91ryuDptgdEYqjQtotKOnHsl6Gk/qRnF kW5FTotAXhe+n+mMhbn1BP1w65faHKHAfmAlfxRM+lxKqkWz7ZAStB/+WFNGFZErTn82 RRKg== X-Gm-Message-State: AOAM531aURtQ+DC6mgGBEtTcVuoUlfA38andKgLmtmq82h+BjRMovriv Lm67GyUGM19HKI2MAVjkg3tFOehJu09vh5vVFC4= X-Google-Smtp-Source: ABdhPJyjIBIqlhAt90ZsT3WGAkRZuJRZelfF2rwrVZ8N25fpuC49/PrMkh1gQE5eB+9JZHOozcq7Qm7jdGBiuWnQfxU= X-Received: by 2002:a4a:8e16:: with SMTP id q22mr12119291ook.81.1607336967025; Mon, 07 Dec 2020 02:29:27 -0800 (PST) In-Reply-To: <83lfeaan04.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195214 Archived-At: Am So., 6. Dez. 2020 um 18:00 Uhr schrieb Eli Zaretskii : > > > From: Philipp Stephani > > Date: Sun, 6 Dec 2020 17:50:17 +0100 > > > > Am So., 29. Nov. 2020 um 16:27 Uhr schrieb Philipp Stephani > > : > > > > > > Am So., 29. Nov. 2020 um 11:48 Uhr schrieb Philipp Stephani > > > : > > > > > > > > > > > > $ emacs -Q -batch -eval '(progn (defun foo () (error "Boo")) (foo))' > > > > Boo > > > > > > > > Emacs should print a backtrace here to make it possible to debug such > > > > errors. It's possible to force Emacs to print a backtrace by binding > > > > `debug-on-error', however, that is incorrect because it changes the > > > > meaning of `with-demoted-errors' and `condition-case-unless-debug', > > > > causing code that would normally work to fail with an error. Instead, > > > > `signal' should print a backtrace if in batch mode and if it jumps to > > > > the top-level error handler. It looks like this logic could be > > > > special-cased in signal_or_quit, similar to the debugger logic. > > > > > > > > > > I've attached a patch. > > > > Pushed to master as commit 40e11743ca. > > This is an incompatible change. Is it? In other words, do we guarantee that no stack trace is being printed if debug-on-error is nil? I'd say that parsing error messages is brittle anyway, and we're not obliged to provide stable output. > Is there a way to get back previous > behavior? If so, please mention that in NEWS; if not, let's please > provide a way to get back the old behavior. I'd be OK adding a variable for this, but on the other hand I'm not really convinced that this is really a breaking change (see above).