From: Philipp Stephani <p.stephani2@gmail.com>
To: Vladimir Lomov <v.p.lomov@yandex.ru>, 24998@debbugs.gnu.org
Subject: bug#24998: Commit 'b5b997b95...' (Checkdoc: Don't require a space before an arg list) breaks defvar
Date: Sat, 31 Dec 2016 16:35:44 +0000 [thread overview]
Message-ID: <CAArVCkQsxoFC_2umEg6RVQ2tHz=ZUZXeDrUvzJ9h3JbjewR58Q@mail.gmail.com> (raw)
In-Reply-To: <20161231004358.GK1039@smoon.vl-lomov.ru>
[-- Attachment #1: Type: text/plain, Size: 968 bytes --]
Vladimir Lomov <v.p.lomov@yandex.ru> schrieb am Sa., 31. Dez. 2016 um
01:44 Uhr:
> ** Philipp Stephani [2016-12-30 17:04:04 +0000]:
>
> > Vladimir Lomov <lomov.vl@gmail.com> schrieb am Do., 29. Dez. 2016 um
> > 05:29 Uhr:
> >
> >> Hello,
> >>
> >> I found that the commit 'b5b997b95' breaks a valid defvar, see
> >> attached example file 'b.el'. If I run 'M-x checkdoc' in Emacs after
> >> that commit (I tried in Emacs compiled from commit 112460da70) it shows
> >> me error message (copy-pasted from *Message* buffer):
> >>
> >> forward-sexp: Scan error: "Containing expression ends prematurely",
> 60,
> >> 61
> >>
> >> while before that commit (I tested in Emacs compiled from commit
> >> e5ef59b87d) it works like a charm.
> >>
> >>
> > Thanks for reporting. I've attached a patch that replaces the regex
> > completely.
>
> Thank you, your patch works fine on my example and other real el file.
>
>
Thanks, pushed as 4bbd5424a2290ab4bd88c0af602b7aa7d53a407e.
[-- Attachment #2: Type: text/html, Size: 1975 bytes --]
prev parent reply other threads:[~2016-12-31 16:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 10:11 bug#24998: 25.1.50; Checkdoc ignores functions if there is no space before the argument list Philipp Stephani
2016-11-23 19:35 ` Philipp Stephani
2016-12-02 9:02 ` Eli Zaretskii
2016-12-26 20:17 ` Philipp Stephani
2016-12-29 4:28 ` bug#24998: Commit 'b5b997b95...' (Checkdoc: Don't require a space before an arg list) breaks defvar Vladimir Lomov
2016-12-29 6:42 ` Vladimir Lomov
2016-12-30 17:04 ` Philipp Stephani
2016-12-31 0:43 ` Vladimir Lomov
2016-12-31 16:35 ` Philipp Stephani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAArVCkQsxoFC_2umEg6RVQ2tHz=ZUZXeDrUvzJ9h3JbjewR58Q@mail.gmail.com' \
--to=p.stephani2@gmail.com \
--cc=24998@debbugs.gnu.org \
--cc=v.p.lomov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).