From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#26597: 25.1; Compilation error on master with --enable-check-lisp-object-type Date: Sat, 22 Apr 2017 11:57:11 +0000 Message-ID: References: <83mvb8riq0.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a114b33e4ac2aef054dc013a6 X-Trace: blaine.gmane.org 1492862295 10784 195.159.176.226 (22 Apr 2017 11:58:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 22 Apr 2017 11:58:15 +0000 (UTC) To: Eli Zaretskii , 26597-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 22 13:58:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1tg2-0002hr-6R for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Apr 2017 13:58:10 +0200 Original-Received: from localhost ([::1]:35185 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d1tg8-0004sL-2q for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Apr 2017 07:58:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60346) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d1tfz-0004r3-Mf for bug-gnu-emacs@gnu.org; Sat, 22 Apr 2017 07:58:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d1tfv-0005FE-0T for bug-gnu-emacs@gnu.org; Sat, 22 Apr 2017 07:58:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35041) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d1tfu-0005F4-Tm for bug-gnu-emacs@gnu.org; Sat, 22 Apr 2017 07:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d1tfu-00086y-Ha for bug-gnu-emacs@gnu.org; Sat, 22 Apr 2017 07:58:02 -0400 Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Apr 2017 11:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 26597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 26597@debbugs.gnu.org, p.stephani2@gmail.com, p.stephani2@gmail.com Original-Received: via spool by 26597-done@debbugs.gnu.org id=D26597.149286225031138 (code D ref 26597); Sat, 22 Apr 2017 11:58:02 +0000 Original-Received: (at 26597-done) by debbugs.gnu.org; 22 Apr 2017 11:57:30 +0000 Original-Received: from localhost ([127.0.0.1]:33240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1tfO-00086A-6E for submit@debbugs.gnu.org; Sat, 22 Apr 2017 07:57:30 -0400 Original-Received: from mail-wm0-f47.google.com ([74.125.82.47]:37162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1tfM-00085x-K4 for 26597-done@debbugs.gnu.org; Sat, 22 Apr 2017 07:57:29 -0400 Original-Received: by mail-wm0-f47.google.com with SMTP id m123so34721399wma.0 for <26597-done@debbugs.gnu.org>; Sat, 22 Apr 2017 04:57:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=d7G6zXMOfjVDxqbGJNeSLOdaPDr/bBd/TYvhDbCOoi8=; b=TrB3nBB2FXRmgoOZBQH1kOhqClehxVS34SZVauJYFIaUmYQgcwk7XYOAlvvvnjzSe2 dpUPMqo3KLuf3ExUVn667X/XFDRMBtvAt25mF/euUeuq4s1xdq7uuzgmh35qXOBOeQl5 xg3iX0s6r/6jfkwa71EGCws4f6c3ZMlJXzNvLS0yDQCLXH9aPzyHGrb1rpapMdNIhEbx sBynOtWbAclTS9AwF7nMP0fdPW21Oqp9WKzytEwzxBPeVmqfGl9sdyhl2/HkwA11OvS5 SWsMrDfUcOynwi4BENS0iNr7PZbQ5axkgb4T1FVwNO+V5Tb67gBOkNefxQVmIL+R96mU whPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=d7G6zXMOfjVDxqbGJNeSLOdaPDr/bBd/TYvhDbCOoi8=; b=C+0JujOZ0Ejwo+VxOrLZGpZY0G1tE6UDzS8Okh9G+X5qRz/dT+6xovoB1dmIjTR6IP VfX7GSNG9ROQkLfFbHOLVOWEeEe1beiNpTbxqvzDzlYaNo3vsShC3b7jeQY8+BauUCJo GHjWAp/vdFsnHAgkoNF8nxxggZf5peIil/KFCSOmTsimjUDFbKwiqbXkryfJR2C7MyfS HB7mL9eqGR1SGiuBe5/aOPICloTKYX23ahukEldr/5c1+blzfbiIC1D1rKX599pe/qyO +sFxUhMAFcPfHnt/uST2Mge6dIk/vwamGFxJdvYHEVkiLAyp0ml5z6Wj27W/Kcan9SK3 FsuA== X-Gm-Message-State: AN3rC/7LDDv+rsni57p5ryIFBON5+Ov/AZDIN+NNOwwZZy90YM/qHKeC anOm/Im75k/MALLifgNBVW2vGwustg== X-Received: by 10.28.150.86 with SMTP id y83mr2741127wmd.46.1492862242660; Sat, 22 Apr 2017 04:57:22 -0700 (PDT) In-Reply-To: <83mvb8riq0.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:131860 Archived-At: --001a114b33e4ac2aef054dc013a6 Content-Type: text/plain; charset=UTF-8 Eli Zaretskii schrieb am Sa., 22. Apr. 2017 um 09:42 Uhr: > > From: Philipp Stephani > > Date: Fri, 21 Apr 2017 22:05:58 +0200 > > > > nsterm.m:6969:8: error: member reference base type 'enum z_group' is not > a structure or union > > if (!NILP (FRAME_Z_GROUP (f))) > > ^~~~~~~~~~~~~~~~~~~~~~~~ > > It should compare against z_group_none instead. > Pushed eb52828a43 to fix. > > > (Tangentially, is there any reason not to define Lisp_Object as struct > > unconditionally, to avoid such coding errors?) > > Yes, it produces slower code. > Are you sure that's still the case? I've just diffed the assembly output for editfns.c with and without --enable-check-lisp-object-type, they seem identical (apart from minor diffs due to different register allocation and instruction ordering). Replacing a primitive value with a struct containing such a value should never degrade performance; that would be a compiler bug. --001a114b33e4ac2aef054dc013a6 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= Sa., 22. Apr. 2017 um 09:42=C2=A0Uhr:
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Fri, 21 Apr 2017 22:05:58 +0200
>
> nsterm.m:6969:8: error: member reference base type 'enum z_group&#= 39; is not a structure or union
>=C2=A0 =C2=A0if (!NILP (FRAME_Z_GROUP (f)))
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 ^~~~~~~~~~~~~~~~~~~~~~~~

It should compare against z_group_none instead.

Pushed eb52828a43 to fix.
=C2=A0

> (Tangentially, is there any reason not to define Lisp_Object as struct=
> unconditionally, to avoid such coding errors?)

Yes, it produces slower code.

Are you s= ure that's still the case? I've just diffed the assembly output for= editfns.c with and without --enable-check-lisp-object-type, they seem iden= tical (apart from minor diffs due to different register allocation and inst= ruction ordering). Replacing a primitive value with a struct containing suc= h a value should never degrade performance; that would be a compiler bug.= =C2=A0
--001a114b33e4ac2aef054dc013a6--