From mboxrd@z Thu Jan 1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Philipp Stephani
Newsgroups: gmane.emacs.bugs
Subject: bug#41989: 28.0.50; Edebug doesn't generate symbols for `cl-flet' etc.
Date: Mon, 1 Mar 2021 16:59:40 +0100
Message-ID:
References:
<87ft1e513b.fsf@gnus.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
logging-data="40290"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: 41989@debbugs.gnu.org
To: Lars Ingebrigtsen
Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 01 17:00:11 2021
Return-path:
Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92)
(envelope-from )
id 1lGkxu-000AKr-MG
for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Mar 2021 17:00:10 +0100
Original-Received: from localhost ([::1]:51336 helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from )
id 1lGkxt-00017r-Iv
for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Mar 2021 11:00:09 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40614)
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from )
id 1lGkxm-00017M-Jz
for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 11:00:02 -0500
Original-Received: from debbugs.gnu.org ([209.51.188.43]:38979)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from )
id 1lGkxm-0006Gj-Ac
for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 11:00:02 -0500
Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
(envelope-from ) id 1lGkxm-0001WW-95
for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 11:00:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Philipp Stephani
Original-Sender: "Debbugs-submit"
Resent-CC: bug-gnu-emacs@gnu.org
Resent-Date: Mon, 01 Mar 2021 16:00:02 +0000
Resent-Message-ID:
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 41989
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: moreinfo
Original-Received: via spool by 41989-submit@debbugs.gnu.org id=B41989.16146143985819
(code B ref 41989); Mon, 01 Mar 2021 16:00:02 +0000
Original-Received: (at 41989) by debbugs.gnu.org; 1 Mar 2021 15:59:58 +0000
Original-Received: from localhost ([127.0.0.1]:50525 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from )
id 1lGkxi-0001Vn-BM
for submit@debbugs.gnu.org; Mon, 01 Mar 2021 10:59:58 -0500
Original-Received: from mail-oi1-f181.google.com ([209.85.167.181]:39087)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from ) id 1lGkxg-0001Va-Rp
for 41989@debbugs.gnu.org; Mon, 01 Mar 2021 10:59:57 -0500
Original-Received: by mail-oi1-f181.google.com with SMTP id z126so18506673oiz.6
for <41989@debbugs.gnu.org>; Mon, 01 Mar 2021 07:59:56 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to
:cc:content-transfer-encoding;
bh=5vGW1jl6UlrEL+3zWTiNyFq0nJWSaOFHelSzSKzpVBk=;
b=QnVZeEGPcJWRAX47H93WEP0uoK90bY7XZt4BvO1V/AYCAVCyvyfXbYKANHT+kgLYKo
gMWLLN6FONI63w2YiEKJ8AEVnC6iIwvprNVCpFSYZUfx9oQRCFfApLVLTSpX55KkfiiA
h+wZPqrpeeRuUJuSSqczZ7EyxVOhkhnlp1qrOvH62gmLBz2NfsMjH5YES9FQdw3+EEID
94mJZj8Bj5KCNwERr/NeQzSu9nCLUO8Hw3azeeD2kb4wp1oXE68h+QTMCwGjGRCgZ+PN
2hQvZlHM3nsBbVH7AMj3kv95XnoeEKliyDtkmwQSH4ImnIhpeJp5gfkdWJfYFpVx3kRW
eIFQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc:content-transfer-encoding;
bh=5vGW1jl6UlrEL+3zWTiNyFq0nJWSaOFHelSzSKzpVBk=;
b=ZlNSbnGiQUiNLCMmu3otGHcyhqv5RWwhuXQ84uzBtEihIQKM4F/9P1/YdqJFxIzd6e
TaE0pmWJHdpcs7fYag0NPvariqgyZKL7PHlKzyUPDRSWmpd1aTp/eKg7+/zLahUvotrD
EioP6L9G4c5l6WyFbEHn5TqOu2qUWTXAr+BXuWpnK4oR1M48Q/df+LDt1i+SJ4zN/j7H
KNbuR+Wdo5TzU7hvhgup2G4ld29txsVAnmzCm6XO0of/eWqeKbnH8zVlDGn2KClZjXCQ
R2RjXHsQXdRRzD+Usg6A9vWoAp5Oyo607SuB837pK4SgM18HEqfRr98b/DDuz0aeqRV5
hdWw==
X-Gm-Message-State: AOAM531DUS35jmy4TG+hOetyVVIw7gE+hrqo/HjkvHFcQm7LTZOUH+AU
rsKlqUkwUYolgz0/sl7wAKomsDDaPS2MU2XUiN8=
X-Google-Smtp-Source: ABdhPJwRk5RYaDJ048z50Uw2fIq8bdzEr0XFuzyGf4aRtKpnsB9CdcvXQITgJoJr6nvieoNjaLcqTPtSj4MeAXaylpc=
X-Received: by 2002:aca:3742:: with SMTP id e63mr12360468oia.158.1614614391040;
Mon, 01 Mar 2021 07:59:51 -0800 (PST)
In-Reply-To: <87ft1e513b.fsf@gnus.org>
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: bug-gnu-emacs@gnu.org
List-Id: "Bug reports for GNU Emacs,
the Swiss army knife of text editors"
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org
Original-Sender: "bug-gnu-emacs"
Xref: news.gmane.io gmane.emacs.bugs:201116
Archived-At:
Am Mo., 1. M=C3=A4rz 2021 um 16:46 Uhr schrieb Lars Ingebrigtsen :
>
> Philipp Stephani writes:
>
> >> Edebug (using C-u C-M-x) a function like the following:
> >>
> >> (defun bar ()
> >> (cl-flet ((foo () 1)) (foo))
> >> (cl-flet ((foo () 2)) (foo)))
> >>
> >> *Messages* will now contain
> >>
> >> Edebug: foo [4 times]
> >> Edebug: bar
> >>
> >> Note how `foo' has been instrumented 4 times. A factor of 2 is due to
> >> Bug#41988; another factor of 2 is due to Edebug not generating a uniqu=
e
> >> symbol. Edebug should generate symbols such as `bar@foo@1' and
> >> `bar@foo@2' for these definitions.
> >
> > I've partially fixed this with commit d8ab98843e. It's not completely
> > fixed because Edebug doesn't yet detect the outer definition and adds
> > it to the inner symbol.
>
> I'm not quite sure what the status is here now. I tried `C-u C-M-x'-ing
> it now and got:
>
> Edebug: foo@cl-flet@118
> Edebug: foo@cl-flet@119
> Edebug: bar
> bar
>
> Which seems correct. And stepping through the function also works. So
> is there more to be done here?
It would be nice to include the outer function ("bar") in the
generated symbol, e.g. "bar@foo@cl-flet@118" or similar.
But that would really be the icing on the cake, and it's not necessary
to avoid duplicate symbols. So more of a nice to have; feel free to
close this bug if it's too hard to implement.