From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#41988: 28.0.50; Edebug unconditionally instruments definitions with &define specs Date: Tue, 2 Mar 2021 18:28:03 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="438"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41988@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 02 18:29:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lH8pZ-000AY4-4z for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Mar 2021 18:29:09 +0100 Original-Received: from localhost ([::1]:51594 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lH8pY-0003vU-7S for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Mar 2021 12:29:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51896) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lH8pR-0003uo-Tl for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 12:29:01 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42561) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lH8pR-0002ro-Kw for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 12:29:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lH8pR-0006R2-Ha for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 12:29:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Mar 2021 17:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41988 X-GNU-PR-Package: emacs Original-Received: via spool by 41988-submit@debbugs.gnu.org id=B41988.161470610324691 (code B ref 41988); Tue, 02 Mar 2021 17:29:01 +0000 Original-Received: (at 41988) by debbugs.gnu.org; 2 Mar 2021 17:28:23 +0000 Original-Received: from localhost ([127.0.0.1]:54107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lH8op-0006QB-Gk for submit@debbugs.gnu.org; Tue, 02 Mar 2021 12:28:23 -0500 Original-Received: from mail-ot1-f49.google.com ([209.85.210.49]:45806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lH8om-0006Pv-LN for 41988@debbugs.gnu.org; Tue, 02 Mar 2021 12:28:21 -0500 Original-Received: by mail-ot1-f49.google.com with SMTP id d9so20701433ote.12 for <41988@debbugs.gnu.org>; Tue, 02 Mar 2021 09:28:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=yXdivCJCmd7MlWmnK8Hu3RilSNwNwzMVl47jNyMIMGw=; b=NV86xJ3H2rLzZAuGO3xnSyDBA+ifQrvXbMUd5OsluIMFyUmcF+yQFyBPJq6am/LXSS 330hCoGNFa069s9zIyKIBK3Es+BvGciNuD7pFksH/jAtnDm1QkQX6dIerNhAEyYt+TXd uRIU6zphHGakqrw5upWkkPOREkSkLtKwwmAv7tGkk0uvWUBQltlddlXoTHLlr4KhzkIr uqHm8rLkwXmdV3pURQrMheysdVfCqPnbA1c2omAOASbW6N73GY+TKNJVJY9oxws3b5fp +3zABOqUS6aAbf/1yzfKEx2RFzcqdnuRAMHj7w0NiAucsP2LMd/e3Cphc2Iz3gMnuY3f ZQTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=yXdivCJCmd7MlWmnK8Hu3RilSNwNwzMVl47jNyMIMGw=; b=YMDy57NpPfsH5+s/IDAm7xZscjFtflySN1FuRguQUtBXup6yQjC5L3U4fxljA1f7j8 1+CE0lPnUBC8MqjXaGCBIP4+Kq7seyM9sRJtYDxYwsGnyw0Lv2Mvm+wBuhVxqx/dsTJ9 CxaxXcmwHghdFRMmRuMbeT82egx6uObcSI4ylILe/FaSi0Sbor1XLT0d7VxvS4lTpk+f XDGFMQmegKrW5MeyLuAq9K/H+UL0Z3REaZZ2Mo9Xy1yNEt0gKIW8h4cCmwaAGqd+yfZ7 k/l0mCL70fW5ihP6yg7+3LlNu1HdMCcsTRJPxcKgJNYmcq1FAxdJLwIy9AwRdb7ziB2W SoQw== X-Gm-Message-State: AOAM530gbon9pKxXsEEOAkFJtb+27ZMe6LMqkreMMl++fBqeWjzKWTWF WPzb00ncdmitdEYR1dWDa36CAsyKvmdp+/sx+J8= X-Google-Smtp-Source: ABdhPJy3/O7oI6w6act1wTYyDi/21UWv0d11d1eM4HY0hQEVu80VhpfcitNhmLqmHc45ZC7qf/GoGq7sZIbO8pAJDXM= X-Received: by 2002:a9d:3a34:: with SMTP id j49mr18347404otc.153.1614706094723; Tue, 02 Mar 2021 09:28:14 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201230 Archived-At: Am Di., 2. M=C3=A4rz 2021 um 16:59 Uhr schrieb Stefan Monnier : > > > As an example, edebug-instrument (C-u C-M-x) the following definition: > > > > (defun bar () > > (cl-flet ((foo () 1)) > > (foo))) > > > > The *Messages* buffer now says > > > > Edebug: foo [2 times] > > Edebug: bar > > I believe this is now fixed in `master`. > At least we only get a total of 2 messages rather than "3 collapsed to 2"= . > But I don't know enough about the code coverage to be sure that the > underlying problem you saw is also fixed. Can you confirm? Thanks! I'll check (hopefully in the next few days). For context, the tests that should now be fixed are https://github.com/phst/rules_elisp/blob/6050b4ecc35e1a450320420f3a652f2551= fc22b1/tests/ert_test.go#L215 and https://github.com/phst/rules_elisp/blob/6050b4ecc35e1a450320420f3a652f= 2551fc22b1/elisp/ert/runner.el#L138. But these run under Emacs 27 by default. I'm going to check whether I can make them run under "master" as well.