From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#52369: 28.0.90; Assertion failure when running Flycheck unit test suite Date: Sat, 11 Dec 2021 13:56:45 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000db30cc05d2de5fc4" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35095"; mail-complaints-to="usenet@ciao.gmane.io" To: 52369@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 11 13:58:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mw1x8-0008tO-Pr for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Dec 2021 13:58:14 +0100 Original-Received: from localhost ([::1]:37794 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mw1x7-0005QH-MA for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Dec 2021 07:58:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34974) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mw1ww-0005MC-PM for bug-gnu-emacs@gnu.org; Sat, 11 Dec 2021 07:58:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37190) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mw1ww-00045v-Gp for bug-gnu-emacs@gnu.org; Sat, 11 Dec 2021 07:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mw1ww-0004JW-GB for bug-gnu-emacs@gnu.org; Sat, 11 Dec 2021 07:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Dec 2021 12:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52369 X-GNU-PR-Package: emacs Original-Received: via spool by 52369-submit@debbugs.gnu.org id=B52369.163922742716506 (code B ref 52369); Sat, 11 Dec 2021 12:58:02 +0000 Original-Received: (at 52369) by debbugs.gnu.org; 11 Dec 2021 12:57:07 +0000 Original-Received: from localhost ([127.0.0.1]:48732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mw1w2-0004IA-NE for submit@debbugs.gnu.org; Sat, 11 Dec 2021 07:57:06 -0500 Original-Received: from mail-ot1-f45.google.com ([209.85.210.45]:33501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mw1vy-0004HX-Bo for 52369@debbugs.gnu.org; Sat, 11 Dec 2021 07:57:05 -0500 Original-Received: by mail-ot1-f45.google.com with SMTP id 35-20020a9d08a6000000b00579cd5e605eso12511308otf.0 for <52369@debbugs.gnu.org>; Sat, 11 Dec 2021 04:57:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=5lI0lNe+ZUrQcrVVLJswk96k8hS2NyXYbLAFBQq/60I=; b=mT329Bry9Kx6CHQJKpa7VH08ZeaMbWVhhkXFJFTccgqol7VwpzUOjHLQq4ylE6hTDV 7WEpYJ94zsipQ35SzO8D6JFNRL0hohgd40DkCObxeNDxmmuxRu5TFS+zcSZikuueE/Hv bAbC3jU6Y9L+CVBCgpVzIRfCw9Zq++4Ja4NQn+odx2GkpxJkiCcgije+XPBQ/dml7VDQ H1TdjLcMep4xVInCFV7OycL8cp333xWEGjDKWAk0Kj/b6y3Q44wDhBJMNwia8lmOvfMo LeesnPXst2UBQhWNkttCIvUyG1v4BmXcbimqUCjWQWCyw9cNR+bzIwvnGmBnL63/04Kt ew8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=5lI0lNe+ZUrQcrVVLJswk96k8hS2NyXYbLAFBQq/60I=; b=vD2jb7zlbDswMVPq42yU+T4IIX4HKb6IpsQWDS3MrVObNIwDe9qKv2Wiw6QsMlHxHD nBzUqZR2Gui1kpBPTQp6GzvPiklsj56mauU8vuGDPOgAhhsv8tVD6Rnhw+mOzqoM5TbJ 96c4+RSQgpTDL6xaStqfgYLgIHb3uHjh/lY6SKQ4tYsAHBZAW/yCEhqUYrhvVarYukjL FylBfk7R8A8MT3MMRkqP5iDCadqaGG6y8IEEEo4FPqx6F6/k31MBt0AqKLEReRDFGlNo xVdWPJX9Xv7l4/AFAS4EYRvQ81hWgnrIYaeS2iybdWvYGh18ovhxekbdX+uyIUyIQ6pe +0Sw== X-Gm-Message-State: AOAM530Jx1Lz7GOyy8ALNeiUQ7NgXmsXZ/trybJXMts8z2npV3l0Ugx1 t/E9mXcIsBImQdeDKaTouRQdh9n3UdeaGtrI43MnLhXp X-Google-Smtp-Source: ABdhPJxlO0MALRMPTz9LisTvuYUey1q3kIvsmum0X/lgvO68Uh1oQBnpbWrjsqyPs/xJeXJo66CRWhdvDEn7U92A1yI= X-Received: by 2002:a05:6830:314b:: with SMTP id c11mr15927984ots.224.1639227416279; Sat, 11 Dec 2021 04:56:56 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222115 Archived-At: --000000000000db30cc05d2de5fc4 Content-Type: text/plain; charset="UTF-8" Am Mi., 8. Dez. 2021 um 09:43 Uhr schrieb Philipp Stephani : > > > With the emacs-28 branch (haven't checked other branches so far), an > assertion failure consistently triggers when running the Flycheck unit > test suite. Unfortunately, I haven't been able to narrow down the > problem any further so far. To reproduce, clone the Flycheck repository > from https://github.com/flycheck/flycheck (at commit > 784f184cdd9f9cb4e3dbb997c09d93e954142842 in my case, though this > probably doesn't matter much), and run the unit tests like > > export EMACS=... > make init > make unit > > With an Emacs built with --enable-checking, I then get the following > assertion failure: > > [...] > passed 302/361 flycheck-set-checker-executable/non-existing-file (0.000481 sec) > passed 303/361 flycheck-set-checker-executable/real-executable (0.002321 sec) > passed 304/361 flycheck-standard-error-navigation/default-to-t (0.000198 sec) > > process.c:6521: Emacs fatal error: assertion failed: 0 <= outfd && outfd < FD_SETSIZE > make: *** [Makefile:128: unit] Aborted (core dumped) > Given that this is a serious bug (undefined behavior), I'd install the attached patch on the release branch. --000000000000db30cc05d2de5fc4 Content-Type: application/octet-stream; name="0001-Avoid-undefined-behavior-in-send-process-region-Bug-.patch" Content-Disposition: attachment; filename="0001-Avoid-undefined-behavior-in-send-process-region-Bug-.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kx1to5fv0 RnJvbSBkMzliZGZiYjY0Yzk1M2JkOTM4OWY3NjI0NDNkMTVlY2I0ZmIwY2JiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwIFN0ZXBoYW5pIDxwaHN0QGdvb2dsZS5jb20+CkRh dGU6IFNhdCwgMTEgRGVjIDIwMjEgMTM6NTE6MzQgKzAxMDAKU3ViamVjdDogW1BBVENIXSBBdm9p ZCB1bmRlZmluZWQgYmVoYXZpb3IgaW4gJ3NlbmQtcHJvY2Vzcy1yZWdpb24nCiAoQnVnIzUyMzY5 KS4KCiogc3JjL3Byb2Nlc3MuYyAoc2VuZF9wcm9jZXNzKTogU2lnbmFsIGFuIGVycm9yIGlmIHRo ZSBmaWxlIGRlc2NyaXB0b3IKaGFzIGFscmVhZHkgYmVlbiBjbG9zZWQuCi0tLQogc3JjL3Byb2Nl c3MuYyB8IDMgKysrCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0 IGEvc3JjL3Byb2Nlc3MuYyBiL3NyYy9wcm9jZXNzLmMKaW5kZXggNzViYTE5MWZhMS4uMWQzMDdk NTI0MiAxMDA2NDQKLS0tIGEvc3JjL3Byb2Nlc3MuYworKysgYi9zcmMvcHJvY2Vzcy5jCkBAIC02 NTIwLDYgKzY1MjAsOSBAQCBzZW5kX3Byb2Nlc3MgKExpc3BfT2JqZWN0IHByb2MsIGNvbnN0IGNo YXIgKmJ1ZiwgcHRyZGlmZl90IGxlbiwKIAkgIC8qIFNlbmQgdGhpcyBiYXRjaCwgdXNpbmcgb25l IG9yIG1vcmUgd3JpdGUgY2FsbHMuICAqLwogCSAgcHRyZGlmZl90IHdyaXR0ZW4gPSAwOwogCSAg aW50IG91dGZkID0gcC0+b3V0ZmQ7CisgICAgICAgICAgaWYgKG91dGZkIDwgMCkKKyAgICAgICAg ICAgIGVycm9yICgiT3V0cHV0IGZpbGUgZGVzY3JpcHRvciBvZiAlcyBpcyBjbG9zZWQiLAorICAg ICAgICAgICAgICAgICAgIFNEQVRBIChwLT5uYW1lKSk7CiAJICBlYXNzZXJ0ICgwIDw9IG91dGZk ICYmIG91dGZkIDwgRkRfU0VUU0laRSk7CiAjaWZkZWYgREFUQUdSQU1fU09DS0VUUwogCSAgaWYg KERBVEFHUkFNX0NIQU5fUCAob3V0ZmQpKQotLSAKMi4zMC4xIChBcHBsZSBHaXQtMTMwKQoK --000000000000db30cc05d2de5fc4--