From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#27587: 25.1; in the dynamic modules api, env->free_global_ref doesn't free anything Date: Sun, 09 Jul 2017 22:17:17 +0000 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a113e54cae660870553e9d40c" X-Trace: blaine.gmane.org 1499638696 16153 195.159.176.226 (9 Jul 2017 22:18:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 9 Jul 2017 22:18:16 +0000 (UTC) To: Valentin Gatien-Baron , 27587-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 10 00:18:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUKWm-0003oJ-HM for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Jul 2017 00:18:08 +0200 Original-Received: from localhost ([::1]:37690 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUKWr-0007hm-UK for geb-bug-gnu-emacs@m.gmane.org; Sun, 09 Jul 2017 18:18:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44807) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUKWk-0007gJ-9J for bug-gnu-emacs@gnu.org; Sun, 09 Jul 2017 18:18:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUKWg-0005J3-VO for bug-gnu-emacs@gnu.org; Sun, 09 Jul 2017 18:18:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56581) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dUKWg-0005Ie-PU for bug-gnu-emacs@gnu.org; Sun, 09 Jul 2017 18:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dUKWg-0004eM-Jy for bug-gnu-emacs@gnu.org; Sun, 09 Jul 2017 18:18:02 -0400 Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Jul 2017 22:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 27587 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 27587@debbugs.gnu.org, p.stephani2@gmail.com, vgatien-baron@janestreet.com Original-Received: via spool by 27587-done@debbugs.gnu.org id=D27587.149963865617835 (code D ref 27587); Sun, 09 Jul 2017 22:18:02 +0000 Original-Received: (at 27587-done) by debbugs.gnu.org; 9 Jul 2017 22:17:36 +0000 Original-Received: from localhost ([127.0.0.1]:59256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUKWG-0004db-9w for submit@debbugs.gnu.org; Sun, 09 Jul 2017 18:17:36 -0400 Original-Received: from mail-oi0-f53.google.com ([209.85.218.53]:36744) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUKWE-0004dO-LE for 27587-done@debbugs.gnu.org; Sun, 09 Jul 2017 18:17:35 -0400 Original-Received: by mail-oi0-f53.google.com with SMTP id x187so61477004oig.3 for <27587-done@debbugs.gnu.org>; Sun, 09 Jul 2017 15:17:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=Uu0GEzp4vGonpb5g6YoH/VOz4hD3pGvQhFGuLh4wg2k=; b=ZCJlrn7l7TmkfiwxYOKxqzSeFDyh3UIp4YKDiV06A3zAJVyJfXZAbRPaal3R5L/iyU 5oudbYA1OazSPehePz7B4od8ix01RkZzkiBR8/K0Bw6uk2k+UPLxYvxtTMRdmvhQAfsJ ikLD2mgbMVP9QINgo41MqlR9iL9P3TXU5JiAqnbCiLykIqrd6wk0DMiZ/7NyI6PftsFD IYff0WeRgn2mm/Q9u3DPlFJUGABS8xXRmJt+RjwxjZyVc1zZDy1f68/XfjiB8K8mAeWL KTnFQZKwl/EgDKIucMg+f2ucq0zfkhhR7XrlQZC/v6nlW+PYEwSzPZjadCQYQ67Ofg9C brmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=Uu0GEzp4vGonpb5g6YoH/VOz4hD3pGvQhFGuLh4wg2k=; b=UMWVpNL0awF8ww9j39pfDRezib8ogtBlETBk9rgWDXfCqXMAJZwtn9Wf0S1G5SESbR ahutm1Y+CKI12AbOIhrlY4nc5U2YR+zceGCJk9PsVL7FpvE7Q5+e4+e9TbQSswsR5FlS 0dbMx4kjFpWiVwh0VklN7FxDzuztT4RXrNKzIzYnD5b/ndNxDqD+k4OQp5vcFeUIyHGi B8RTGI86SxBHwt+hSX0pImocudCD2hBesePOsLkhEcSrj3tas3HUFu8bbgMt5ep1Rbim 38pjC80mkznqybWA93SKfwQpv/r8KSv6FNzFXya5SqdBp9ly+sWvrX6N+n9xr7FA5bWX k84g== X-Gm-Message-State: AIVw110FJbSR+yI88Syc3Y6en+F1IADZv6pJAscQBpo0Luq3zv1lVBNz qblTsQUewh2CqU9oyw29oBXppCWHtg== X-Received: by 10.202.71.15 with SMTP id u15mr5957747oia.133.1499638647904; Sun, 09 Jul 2017 15:17:27 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134379 Archived-At: --001a113e54cae660870553e9d40c Content-Type: text/plain; charset="UTF-8" Valentin Gatien-Baron schrieb am Mi., 5. Juli 2017 um 17:07 Uhr: > The following dynamic module takes unbounded memory: > > /* gcc -I . -g -ggdb -fPIC foo.c -shared -o foo.so && echo running && > emacs -Q -L . -batch -l foo */ > #include > > int plugin_is_GPL_compatible; > > int emacs_module_init(struct emacs_runtime *ert) { > emacs_env *env = ert->get_environment(ert); > while (1) { > int i; > for (i = 0; i < 10000; i++) { > emacs_value v = env->make_string(env, "asdads", 3); > env->free_global_ref(env, env->make_global_ref(env, v)); > } > env->funcall(env, env->intern(env, "garbage-collect"), 0, NULL); > } > } > > > This is because env->make_global_ref/env->free_global_ref leak memory. > env->free_global_ref fails to remove values from the hash table of > refcounts. The following patch makes the program above run in constant > space. > > > --- src/emacs-module.c 2017-06-30 16:00:36.776301646 -0400 > +++ src/emacs-module.c 2017-06-30 16:05:01.660120043 -0400 > @@ -308,7 +308,7 @@ > set_hash_value_slot (h, i, value); > } > else > - hash_remove_from_table (h, value); > + hash_remove_from_table (h, obj); > } > } > > Good catch, installed as 22af69906cca871fdb893e06d6f10dbbab4518e6. --001a113e54cae660870553e9d40c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Valent= in Gatien-Baron <vgatien= -baron@janestreet.com> schrieb am Mi., 5. Juli 2017 um 17:07=C2=A0Uh= r:
The following dynamic module takes unbounded memory:
=
/* gcc -I . -g -ggdb -fPIC foo.c -shared -o foo.s= o && echo running && emacs -Q -L . -batch -l foo */<= br>
#include <emacs-module.h>

int plugin_= is_GPL_compatible;

= int emacs_module_init(struct em= acs_runtime *ert) {
=C2=A0 emacs_env *env =3D ert->get_environ= ment(ert);
=C2=A0 while (1) {
=C2=A0 =C2=A0 int i;
=C2=A0 =C2=A0 for (i =3D 0; i < 10000; i++) {
=C2=A0 =C2= =A0 =C2=A0 emacs_value v =3D env->make_string(env, "asdads", 3= );
=C2=A0 =C2=A0 =C2=A0 env->free_global_ref(env, env->make= _global_ref(env, v));
=C2=A0 =C2=A0 }
=C2=A0 =C2=A0 e= nv->funcall(env, env->intern(env, "garbage-collect"), 0, NU= LL);
=C2=A0 }
}


<= /div>
This is because env->make_global_ref/env->free_global_ref leak mem= ory.
env->free_global_ref fails to remove values from the hash= table of
refcounts. The following patch makes the program above = run in constant
space.
<= font face=3D"arial, helvetica, sans-serif">

=
--= - src/emacs-module.c 2017-06-30= 16:00:36.776301646 -0400
+++ src/emacs-module.c 2017-06-30 16:05:01.660120043 -0400
@= @ -308,7 +308,7 @@
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0set_h= ash_value_slot (h, i, value);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}=
=C2=A0 =C2=A0 =C2=A0 =C2=A0else
- hash_remove_from_table (h, value);
+ hash_remove_from_table (h, obj);
=C2=A0 =C2=A0 =C2=A0}
=C2=A0}

=

Good catch, installed as 22af6= 9906cca871fdb893e06d6f10dbbab4518e6.=C2=A0
--001a113e54cae660870553e9d40c--