From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#48489: 28.0.50; Incorrect Edebug instrumentation for old `when-let' form Date: Tue, 18 May 2021 18:49:59 +0200 Message-ID: References: <87mtssc8mb.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11685"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Glenn Morris , 48489@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 18 18:51:50 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lj2wf-0002of-LZ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 18 May 2021 18:51:49 +0200 Original-Received: from localhost ([::1]:54252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lj2wc-0004FJ-VP for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 18 May 2021 12:51:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56192) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lj2vv-0004De-3m for bug-gnu-emacs@gnu.org; Tue, 18 May 2021 12:51:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45618) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lj2vu-0005zM-Sp for bug-gnu-emacs@gnu.org; Tue, 18 May 2021 12:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lj2vu-0007Xd-Rq for bug-gnu-emacs@gnu.org; Tue, 18 May 2021 12:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 May 2021 16:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48489 X-GNU-PR-Package: emacs Original-Received: via spool by 48489-submit@debbugs.gnu.org id=B48489.162135661728907 (code B ref 48489); Tue, 18 May 2021 16:51:02 +0000 Original-Received: (at 48489) by debbugs.gnu.org; 18 May 2021 16:50:17 +0000 Original-Received: from localhost ([127.0.0.1]:57159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj2vB-0007WA-K4 for submit@debbugs.gnu.org; Tue, 18 May 2021 12:50:17 -0400 Original-Received: from mail-oi1-f174.google.com ([209.85.167.174]:46837) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj2v9-0007Vo-O4 for 48489@debbugs.gnu.org; Tue, 18 May 2021 12:50:16 -0400 Original-Received: by mail-oi1-f174.google.com with SMTP id x15so10348977oic.13 for <48489@debbugs.gnu.org>; Tue, 18 May 2021 09:50:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c09D7NgF2YvplqTanFykSbhs7VOh4jqIKmtl9acfMCU=; b=i7Z+LFnMyoWgIF1JYgZbrN5R3gcTCbrRjrXVZgzilB4+YDBX/xZzXA3J/Pbe//RCxY qyzvE9FkX+rvcTgSpGSeHiZVoG142/uEWuJC0AqiBxHdKrcxvlOFVUcDxkINGokhJ/gT dEFl6Ha2gm0HaD1ztQyPAYFMJM6ua5JUN1iQyA8BEhroiXHnQ36xC1UqgGeaI5HmdYfX BteKj0GDyjTg4DM4GBtSZw9eZ8T4AntL2Eqi/1vALevxzJOfpXf3ABaif3iWleNmbwqL a37ISu35Wxbd2bk/sOy/VutCDdtnPVk7SGQVVrwGZ6ObuNE9CwhS3RjVHUOITEGdJQeJ aOIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c09D7NgF2YvplqTanFykSbhs7VOh4jqIKmtl9acfMCU=; b=aOmEo3gbSmksc61NZHxqqfPsl0FVS5v5NbG50KD/4u2a/xD5PQx68FPweyCMMHig5a 0muXtnMZeOoywMYy6XQhMQGh7E+7aqQZL3UymdG5BB760fTDKWkVXsrPIOXUd8bjg5ZG a44ITdoLx946G0gwHF5QzPpOBfSKqMvVJ/QgQi9OPZ0eZp0j6UrIUB/zXiz0J7YMNE5V 6tJZ8ZrTNa5nBHPneZr9U000XOLYrfa3h66bSCcXpxYzbGHnibDqQNceTZdfqpYoT8CW z2n8JjRJMFH00BT1gh+DZwpgQRwX8F5Upk50rehbUHUn8+iLRwHVM3day3uP/ZKhV764 cZxQ== X-Gm-Message-State: AOAM531zaLwWhLxEUTh8iAvCgOj8+++ZiF8GuhfboA1DqFjyxYTMH5dy TW2mLrzH9uakc/tM4vrVMmd34RVfC08t3N7dPLs= X-Google-Smtp-Source: ABdhPJzupyKn1NhcU4vwAPvwNUxWVzN3cvA0cxaqt7SP+T8Bp6V+yL8Wt7I4SX3rOtVT9Y4sVNIwvvfKf0CLrcWI5lE= X-Received: by 2002:aca:1a18:: with SMTP id a24mr4088010oia.150.1621356610097; Tue, 18 May 2021 09:50:10 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206815 Archived-At: Am Di., 18. Mai 2021 um 18:34 Uhr schrieb Philipp Stephani : > > Am Di., 18. Mai 2021 um 18:27 Uhr schrieb Philipp Stephani > : > > > > Am Di., 18. Mai 2021 um 18:25 Uhr schrieb Lars Ingebrigtsen : > > > > > > Philipp Stephani writes: > > > > > > > Hmm, I can't reproduce this on Debian. But I don't see how this could > > > > be OS-dependent. > > > > > > It reproduces fine here on Debian/bullseye, at least: > > > > > > 1 unexpected results: > > > FAILED edebug-tests-duplicate-symbol-backtrack > > > > > > > Yeah, I can also reproduce it now. Not sure what changed in the > > meantime on my system. > > Ah. See the FIXME in the test: > > ;; FIXME: There are twice as many inner > ;; definitions as expected due to Bug#42701. > ;; Once that bug is fixed, remove the duplicates. > > Bug#42701 still isn't fixed, but the fix to bug#48489 has "suppressed" > its symptom in this case. We can therefore resolve this FIXME. > However, then the edebug-tests-duplicate-symbol-backtrack doesn't > really test any more what it should be testing. So I'll see that I can > change it to restore the previous behavior (which requires > backtracking and overlapping &or branches). Done with commit 63e4ed1c8f1c5bbf59c366134d379bae972201f9.